Carlos Eduardo Arango Gutierrez
9966d2ae12
Deprecate gRPC API
...
Now that the NodeFeature API has been set enabled by default, the gRPC
mode will be deprecated and with it all flags and features around it.
For nfd-master, flags
-port, -key-file, -ca-file, -cert-file, -verify-node-name, -enable-nodefeature-api
are now marked as deprecated.
For nfd-worker flags
-enable-nodefeature-api, -ca-file, -cert-file, -key-file, -server, -server-name-override
are now marked as deprecated.
Deprecated flags, as well as gRPC related code will be removed in future
releases.
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
2023-09-07 06:48:15 +02:00
Kubernetes Prow Robot
db2719a19d
Merge pull request #1336 from marquiz/devel/custom-static-rules
...
sources/custom: convert static rules to new format
2023-09-06 05:12:51 -07:00
Markus Lehtonen
b1b3061738
sources/custom: convert static rules to new format
...
Also add a log message warning about legacy rule format.
2023-09-06 14:29:56 +03:00
Kubernetes Prow Robot
51c79fea9e
Merge pull request #1335 from AhmedGrati/feat-add-feature-file-size-limit
...
feat: add feature file size limit
2023-09-06 03:50:51 -07:00
AhmedGrati
124dfbf6df
docs: add notes in the customization guide about the feature file size limit
...
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-09-06 11:15:45 +01:00
AhmedGrati
026534e355
feat: add feature file size limit
...
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-09-06 10:23:33 +01:00
Kubernetes Prow Robot
aa6e140018
Merge pull request #1333 from ArangoGutierrez/grpc_gone
...
nfd_gc_test.go: fix multiple import of same pkg
2023-09-06 01:56:51 -07:00
Carlos Eduardo Arango Gutierrez
ade5833ee3
tls.md: Add note ( #1332 )
...
* tls.md: Add note
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
* Update docs/deployment/tls.md
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
---------
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
2023-09-06 01:06:52 -07:00
Carlos Eduardo Arango Gutierrez
30b8751515
nfd_gc_test.go: fix multiple import of same pkg
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-09-06 09:47:15 +02:00
Kubernetes Prow Robot
50dd128b23
Merge pull request #1329 from ArangoGutierrez/1187
...
Enable NodeFeature API by default
2023-09-05 11:56:51 -07:00
Carlos Eduardo Arango Gutierrez
04e954a7c3
Enable NodeFeature API by default
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
2023-09-05 20:21:31 +02:00
Kubernetes Prow Robot
0fa57b6986
Merge pull request #1328 from marquiz/devel/e2e-one-node
...
e2e/test: make the nfd-gc test pass on one-node cluster
2023-09-05 04:51:50 -07:00
Markus Lehtonen
f8162a0106
e2e/test: make the nfd-gc test pass on one-node cluster
...
Also remove some leftover debug print.
2023-09-05 14:16:50 +03:00
Kubernetes Prow Robot
16b96ff896
Merge pull request #1327 from marquiz/devel/grpc-health-probe
...
Dockerfile: bump grpc-health-probe to v0.4.19
2023-09-05 03:01:51 -07:00
Kubernetes Prow Robot
0b218a1eca
Merge pull request #1285 from AhmedGrati/feat-add-expiry-date-feature-files
...
Feat: add expiry date for feature files
2023-09-05 02:19:50 -07:00
Markus Lehtonen
9ce215a138
Dockerfile: bump grpc-health-probe to v0.4.19
2023-09-05 11:51:47 +03:00
Kubernetes Prow Robot
8a1facd46a
Merge pull request #1326 from marquiz/devel/docs-hooks
...
docs: demote hooks in the customization guide
2023-09-04 06:43:49 -07:00
Markus Lehtonen
cbd2c2f3df
docs: demote hooks in the customization guide
...
Hooks are deprecated so describe feature files first.
2023-09-04 16:06:51 +03:00
Kubernetes Prow Robot
19520c079c
Merge pull request #1325 from ffromani/nfd-updater-fix-events
...
nfd-updater: events: enable timer-only flow
2023-09-04 05:47:49 -07:00
Francesco Romani
000c919071
nfd-updater: events: enable timer-only flow
...
The nfd-topology-updater has state-directories notification mechanism
enabled by default.
In theory, we can have only timer-based updates, but if the option
is given to disable the state-directories event source, then all
the update mechanism is mistakenly disabled, including the
timer-based updates.
The two updaters mechanism should be decoupled.
So this PR changes this to make sure we can enable just and only
the timer-based updates.
Signed-off-by: Francesco Romani <fromani@redhat.com>
2023-09-04 13:05:50 +02:00
Kubernetes Prow Robot
9848ef9d43
Merge pull request #1321 from ffromani/nfd-topo-updater-fix-docs
...
docs: nfd-updater: clarify accounting
2023-09-04 00:33:49 -07:00
Francesco Romani
727875f240
docs: nfd-updater: clarify accounting
...
Clarify that we account, and we can account, only
resources exclusively allocated to Guaranteed QoS pods.
Signed-off-by: Francesco Romani <fromani@redhat.com>
2023-09-04 08:51:14 +02:00
AhmedGrati
47aec15ea1
test: add unit tests for the expiration date function
...
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-09-01 20:04:24 +01:00
Kubernetes Prow Robot
f852c32a55
Merge pull request #1252 from AhmedGrati/test-add-updater-pool-unit-tests
...
test: add node updater pool unit tests
2023-09-01 07:34:32 -07:00
Kubernetes Prow Robot
5ad0a28692
Merge pull request #1324 from marquiz/devel/readme
...
README: update to v0.13.4
2023-09-01 06:12:30 -07:00
Markus Lehtonen
f5fc8d4782
README: update to v0.13.4
2023-09-01 15:10:20 +03:00
Kubernetes Prow Robot
48f37070ed
Merge pull request #1319 from marquiz/devel/docs-build-image
...
docs: use ruby docker image for building docs
2023-08-31 00:26:47 -07:00
Markus Lehtonen
ae1a95f395
docs: update docs build dependencies
...
Add webrick as that is needed. Also update other deps to their latest
versions.
2023-08-30 19:31:35 +03:00
Markus Lehtonen
8985e003b5
docs: use ruby docker image for building docs
...
Get away with the jekyll:3.8 image which is already four years old. Use
the ruby instead. The jekyll image did not bring any value (more
problems, if anything) as we install/update jekyll and all other gems
with byndler nevertheless (image was jekyll:3.8 but we use jekyll
v3.9.3).
2023-08-30 19:31:35 +03:00
Kubernetes Prow Robot
8cf4a21d62
Merge pull request #1320 from marquiz/devel/github-golangci-lint
...
Makefile: increase golangci-lint timeout to 10min
2023-08-30 07:56:48 -07:00
Markus Lehtonen
2c8a6208f4
Makefile: increase golangci-lint timeout to 10min
2023-08-30 12:53:24 +03:00
Kubernetes Prow Robot
194e5cc056
Merge pull request #1315 from marquiz/devel/k8s-version
...
go.mod: update kubernetes to v1.28.1
2023-08-29 02:31:21 -07:00
Markus Lehtonen
4d9259d6cb
go.mod: update kubernetes to v1.28.1
2023-08-28 18:48:27 +03:00
Kubernetes Prow Robot
a658c54de3
Merge pull request #1297 from marquiz/devel/topology-updater-version
...
topology-updater: make -version always runnable
2023-08-28 04:05:43 -07:00
Kubernetes Prow Robot
e1f90a233b
Merge pull request #1305 from marquiz/devel/nf-gc
...
Garbage collection of NodeFeature objects
2023-08-28 02:59:42 -07:00
Kubernetes Prow Robot
6d95e59cd0
Merge pull request #1290 from marquiz/devel/metrics-new
...
metrics: additional metrics for nfd-master
2023-08-28 02:07:42 -07:00
Markus Lehtonen
a15b5690b6
docs: update to cover nfd-gc
2023-08-23 10:56:12 +03:00
Markus Lehtonen
ceb672bde0
deployment/helm: support nfd-gc
...
Rename files and parameters. Drop the container security context
parameters from the Helm chart. There should be no reason to run the
nfd-gc with other than the minimal privileges.
Also updates the documentation.
2023-08-23 10:56:12 +03:00
Markus Lehtonen
6cf29bd8ef
deployment/kustomize: support nfd-gc
...
Rename the old "topology-gc" to just "gc". Simplify the setup a bit by
including the RBAC rules in the "gc" base.
Note: we don't enable nfd-gc in the default overlay, yet, as the
NodeFeature API isn't enabled (gc is not needed).
2023-08-23 10:56:12 +03:00
Markus Lehtonen
f9fadd2102
test/e2e: add e2e test for nfd-gc
2023-08-22 21:24:26 +03:00
Markus Lehtonen
e3415ec484
nfd-gc: support garbage collection of NodeFeatures
...
Hook into the same logic already exercised for NodeResourceTopology
objects: GC watches for node delete events and immediately drops stale
objects (NRT and now also NF). In addition there is a periodic resync to
catch any missed node deletes, once every hour by default.
2023-08-22 21:24:26 +03:00
Markus Lehtonen
01c08d67b6
Rename nfd-topology-gc to nfd-gc
...
This is preparation for making it a generic garbage collector for all
nfd-managed api objects.
2023-08-21 21:46:11 +03:00
Kubernetes Prow Robot
e0c477090b
Merge pull request #1311 from marquiz/devel/refactor-gc-5
...
topology-gc: simplify listing of node objects
2023-08-21 11:40:05 -07:00
Kubernetes Prow Robot
277f54ae99
Merge pull request #1308 from marquiz/devel/refactor-gc-2
...
topology-gc: move initial GC out of startNodeInformer()
2023-08-21 00:57:23 -07:00
Markus Lehtonen
f05b0e26ea
topology-gc: move initial GC out of startNodeInformer()
...
Small refactor. Contextually this feels more like under periodicGC().
2023-08-21 10:11:46 +03:00
Kubernetes Prow Robot
a60502a313
Merge pull request #1307 from marquiz/devel/refactor-gc
...
topology-gc: refactor unit tests
2023-08-21 00:09:23 -07:00
Kubernetes Prow Robot
536f9d17d0
Merge pull request #1295 from marquiz/devel/topology-updater-metrics
...
nfd-topology-updater: add metrics support
2023-08-20 23:25:24 -07:00
Markus Lehtonen
2e8da8849a
topology-gc: simplify listing of node objects
...
Hopefully makes the code slightly more readable.
2023-08-21 09:13:41 +03:00
Markus Lehtonen
0b5e51bd35
topology-gc: refactor unit tests
...
Remove a lot of boilerplate code by defining reusable functions.
Also, test the Run() method instead of the functions callees of Run() as
it is the top level functionality that was tested in practice (we don't
have separate unit tests for the callee functions).
2023-08-21 09:10:24 +03:00
Kubernetes Prow Robot
4674bce27d
Merge pull request #1310 from marquiz/devel/refactor-gc-4
...
topology-gc: rename runGC to garbageCollect()
2023-08-18 11:26:34 -07:00