Markus Lehtonen
3b448ae623
apis/nfd: allow different types of features of the same name
...
This patch changes the handling of NodeFeatureRules so that one feature
name (say "cpu.cpuid") can hold different types of features (flags,
attributes and/or instances). Requiring features to choose one single
type has not been a limitation of the API itself (and there has been no
validation on this) but an implementation decision.
The new evalutation logic of match expressions is such that "flags" and
"attributes" are basically evaluated as an union - they are both maps
but "flags" just don't have any value associated with the key. However,
"instances" are handled separately as that is basically an array of
maps and needs to be evaluated in a different way (loop over the array
of instances and evaluate expressions against the attributes of each).
Because of this difference care must be taken if mixing "instance"
features with "flag" and/or "attribute" features.
Note that the API types or their validation is not changed - just the
implementation of how the NodeFeatureRules are evaluated.
2024-05-24 13:18:31 +03:00
Kubernetes Prow Robot
c2e3de68f6
Merge pull request #1693 from marquiz/devel/nfd-api-tests
...
apis/nfd: increase unit test coverage
2024-04-30 06:22:39 -07:00
Markus Lehtonen
bad7d1fcb1
apis/nfd: increase unit test coverage
...
Cover error cases of the "match name" functions.
2024-04-30 16:02:13 +03:00
Kubernetes Prow Robot
18980d8d59
Merge pull request #1688 from kubernetes-sigs/dependabot/go_modules/master/github.com/jaypipes/ghw-0.12.0
...
build(deps): bump github.com/jaypipes/ghw from 0.8.1-0.20210827132705-c7224150a17e to 0.12.0
2024-04-30 01:04:30 -07:00
Kubernetes Prow Robot
e2a66e6d71
Merge pull request #1690 from kubernetes-sigs/dependabot/go_modules/master/github.com/onsi/ginkgo/v2-2.17.2
...
build(deps): bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.17.2
2024-04-29 12:46:35 -07:00
dependabot[bot]
003dfdfe0d
build(deps): bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.17.2
...
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo ) from 2.15.0 to 2.17.2.
- [Release notes](https://github.com/onsi/ginkgo/releases )
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/ginkgo/compare/v2.15.0...v2.17.2 )
---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 17:15:35 +00:00
Kubernetes Prow Robot
0c4d1f405f
Merge pull request #1692 from kubernetes-sigs/dependabot/go_modules/master/github.com/onsi/gomega-1.33.0
...
build(deps): bump github.com/onsi/gomega from 1.31.0 to 1.33.0
2024-04-29 10:10:12 -07:00
Kubernetes Prow Robot
d3efe28839
Merge pull request #1691 from kubernetes-sigs/dependabot/go_modules/master/sigs.k8s.io/yaml-1.4.0
...
build(deps): bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0
2024-04-29 09:44:56 -07:00
Kubernetes Prow Robot
193921d5d4
Merge pull request #1689 from kubernetes-sigs/dependabot/go_modules/master/golang.org/x/net-0.24.0
...
build(deps): bump golang.org/x/net from 0.23.0 to 0.24.0
2024-04-29 09:44:42 -07:00
Kubernetes Prow Robot
c763ea99db
Merge pull request #1687 from kubernetes-sigs/dependabot/github_actions/master/actions/checkout-4
...
build(deps): bump actions/checkout from 1 to 4
2024-04-29 09:22:21 -07:00
Kubernetes Prow Robot
80ad416a54
Merge pull request #1686 from kubernetes-sigs/dependabot/github_actions/master/azure/setup-helm-4
...
build(deps): bump azure/setup-helm from 3 to 4
2024-04-29 09:19:39 -07:00
dependabot[bot]
2f50f17c8e
build(deps): bump github.com/onsi/gomega from 1.31.0 to 1.33.0
...
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega ) from 1.31.0 to 1.33.0.
- [Release notes](https://github.com/onsi/gomega/releases )
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md )
- [Commits](https://github.com/onsi/gomega/compare/v1.31.0...v1.33.0 )
---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 16:05:36 +00:00
dependabot[bot]
132469bc42
build(deps): bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0
...
Bumps [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml ) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/kubernetes-sigs/yaml/releases )
- [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/yaml/compare/v1.3.0...v1.4.0 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/yaml
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 16:05:32 +00:00
dependabot[bot]
a6d42da7c4
build(deps): bump golang.org/x/net from 0.23.0 to 0.24.0
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.23.0 to 0.24.0.
- [Commits](https://github.com/golang/net/compare/v0.23.0...v0.24.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 16:05:22 +00:00
dependabot[bot]
4b15b4aa85
build(deps): bump github.com/jaypipes/ghw
...
Bumps [github.com/jaypipes/ghw](https://github.com/jaypipes/ghw ) from 0.8.1-0.20210827132705-c7224150a17e to 0.12.0.
- [Release notes](https://github.com/jaypipes/ghw/releases )
- [Commits](https://github.com/jaypipes/ghw/commits/v0.12.0 )
---
updated-dependencies:
- dependency-name: github.com/jaypipes/ghw
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 16:05:17 +00:00
dependabot[bot]
130ef1070d
build(deps): bump actions/checkout from 1 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 1 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v1...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 16:04:57 +00:00
dependabot[bot]
2cf73f39a3
build(deps): bump azure/setup-helm from 3 to 4
...
Bumps [azure/setup-helm](https://github.com/azure/setup-helm ) from 3 to 4.
- [Release notes](https://github.com/azure/setup-helm/releases )
- [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md )
- [Commits](https://github.com/azure/setup-helm/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: azure/setup-helm
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-29 16:04:54 +00:00
Kubernetes Prow Robot
99b240112c
Merge pull request #1679 from ArangoGutierrez/dependabot2
...
Dependabot: Add proper dependabot config file
2024-04-29 09:04:35 -07:00
Carlos Eduardo Arango Gutierrez
3017d2e9ba
Dependabot: Add proper dependabot config file
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2024-04-29 16:00:37 +02:00
Kubernetes Prow Robot
bb36c21e15
Merge pull request #1681 from ArangoGutierrez/codegenv1.30
...
Update update_codegen.sh for v0.30 version of codegen tools
2024-04-26 10:40:30 -07:00
Kubernetes Prow Robot
122373c36a
Merge pull request #1685 from marquiz/devel/cloud-build
...
cloudbuild.yaml: downgrade machine type to e2-highcpu-8
2024-04-26 09:35:56 -07:00
Markus Lehtonen
cf6f0f70bf
cloudbuild.yaml: downgrade machine type to e2-highcpu-8
...
The higher tier builder didn't give any advantage, especially after
armv7 builds were disabled. Let's revert back to highcpu-8.
2024-04-26 18:39:18 +03:00
Kubernetes Prow Robot
f2c74684b4
Merge pull request #1677 from ArangoGutierrez/fix_cloudbuild
...
Disable armv7 builds
2024-04-26 08:13:57 -07:00
Kubernetes Prow Robot
f9ebb362a3
Merge pull request #1683 from marquiz/devel/hack
...
hack/init-buildx.sh: fix broken patter matching
2024-04-26 07:22:12 -07:00
Markus Lehtonen
38a38e57aa
hack/init-buildx.sh: fix broken patter matching
2024-04-26 16:04:37 +03:00
Carlos Eduardo Arango Gutierrez
bd554e75d2
Disable armv7 builds
...
This patch sets IMAGE_ALL_PLATFORMS=linux/amd64,linux/arm64 at
scripts/test-infra/push-image.sh to explicity set the archs to build
images during cloudbuild post prow steps
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2024-04-26 12:32:30 +02:00
Carlos Eduardo Arango Gutierrez
9931a2a529
Fix kube::codegen::gen_client for v0.30
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2024-04-26 12:30:36 +02:00
Kubernetes Prow Robot
21b624b494
Merge pull request #1680 from marquiz/devel/e2e-runner
...
test/e2e: stop importing kubernetes test/e2e
2024-04-26 03:15:27 -07:00
Carlos Eduardo Arango Gutierrez
52445432d5
Fix kube::codegen::gen_helpers for v0.30
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2024-04-26 10:57:52 +02:00
Markus Lehtonen
d2652cebb7
test/e2e: stop importing kubernetes test/e2e
...
Don't import the kubernetes tests/e2e "root" package (we still use the
test/e2e/framework). We only used the simple e2e runner function from
there so copy that over to the nfd test/e2e package. This change removes
a lot of dependencies speeding up builds.
2024-04-26 09:34:34 +03:00
Kubernetes Prow Robot
abb31ae41c
Merge pull request #1678 from marquiz/devel/cloudbuild
...
cloudbuild.yaml: change machine type to e1-highcpu-32
2024-04-25 08:11:51 -07:00
Markus Lehtonen
aa6969c09f
cloudbuild.yaml: change machine type to e1-highcpu-32
...
Mitigate the big increase of build time after enabling armv7 builds.
2024-04-25 17:50:18 +03:00
Kubernetes Prow Robot
4746c33915
Merge pull request #1675 from marquiz/devel/deps
...
go.mod: bump kubernetes to v1.30
2024-04-25 06:41:42 -07:00
Kubernetes Prow Robot
391865bbb2
Merge pull request #1651 from cmontemuino/doc-resource-limits
...
docs: document trade-offs in memory configuration
2024-04-25 06:41:29 -07:00
Kubernetes Prow Robot
688e3ce0ad
Merge pull request #1659 from Links2004/arm-support
...
add ARMv7 support
2024-04-25 06:21:22 -07:00
Kubernetes Prow Robot
cc9cb87516
Merge pull request #1674 from marquiz/devel/golangci-lint
...
scripts/test-infra: bump golangci-lint to v1.57.2
2024-04-24 06:47:57 -07:00
Markus Lehtonen
079db984bf
go.mod: bump kubernetes to v1.30
2024-04-24 15:39:00 +03:00
Markus Lehtonen
4ffc63b25f
scripts/test-infra: bump golangci-lint to v1.57.2
2024-04-24 15:17:47 +03:00
Kubernetes Prow Robot
ca13b4903d
Merge pull request #1669 from marquiz/devel/nfd-api-helpers-refactor
...
api/nfd: use varargs in the NewInstanceFeatures helper
2024-04-23 06:33:46 -07:00
Kubernetes Prow Robot
be44447dc0
Merge pull request #1670 from marquiz/devel/flag-feature-errors
...
apis/nfd: no error on ops that never match
2024-04-23 06:09:06 -07:00
Kubernetes Prow Robot
828acaa8cc
Merge pull request #1667 from marquiz/devel/api-tests
...
apis/nfd: add unit tests for match name functions
2024-04-23 06:08:48 -07:00
Kubernetes Prow Robot
8a2def761f
Merge pull request #1666 from kubernetes-sigs/dependabot/go_modules/api/nfd/golang.org/x/net-0.23.0
...
build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 in api/nfd
2024-04-23 04:42:19 -07:00
Markus Lehtonen
fbb7303562
apis/nfd: no error on ops that never match
...
Return false (i.e. "did not match") but no error when evaluating a match
expression against a "flag" type feature (which don't have any
associated value, just the name) if a MatchOp that never matches is
used.
This is preparation for supporting multi-type features, i.e. one
feature, like "cpu.cpuid", having e.g. "flag" and "attribute" type
features.
2024-04-23 11:07:49 +03:00
Markus Lehtonen
719c5186f6
api/nfd: use varargs in the NewInstanceFeatures helper
...
Make usage of this helper function more flexible.
2024-04-23 10:29:24 +03:00
Kubernetes Prow Robot
81bdf1dadb
Merge pull request #1668 from TessaIO/chore-remove-nfd-master-test-code-warnings
...
chore/nfd-master: remove warnings in nfd-master unit tests file
2024-04-23 00:20:39 -07:00
TessaIO
de50ac8800
chore/nfd-master: remove warnings in nfd-master unit tests file
...
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
2024-04-22 22:27:15 +02:00
Markus Lehtonen
6b1e9c7860
apis/nfd: add unit tests for match name functions
2024-04-22 17:20:33 +03:00
dependabot[bot]
a8bb9152f3
build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 in api/nfd
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.20.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.20.0...v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-22 14:09:10 +03:00
Kubernetes Prow Robot
7dd3034362
Merge pull request #1665 from kubernetes-sigs/dependabot/go_modules/golang.org/x/net-0.23.0
...
build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0
2024-04-19 06:35:12 -07:00
dependabot[bot]
864f52883d
build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0
...
Bumps [golang.org/x/net](https://github.com/golang/net ) from 0.20.0 to 0.23.0.
- [Commits](https://github.com/golang/net/compare/v0.20.0...v0.23.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/net
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-19 12:58:39 +00:00