From d1a7cd23f0ae1804322a31049ef1b7fd76b4229c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20R=C3=A4thlein?= Date: Sat, 5 Jun 2021 08:31:17 +0000 Subject: [PATCH 1/2] Make use of the $redisPort variable --- charts/matrix-synapse/templates/secrets.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/matrix-synapse/templates/secrets.yaml b/charts/matrix-synapse/templates/secrets.yaml index 4b69c56..71b8e3f 100644 --- a/charts/matrix-synapse/templates/secrets.yaml +++ b/charts/matrix-synapse/templates/secrets.yaml @@ -70,6 +70,9 @@ stringData: {{- else }} password: "@@REDIS_PASSWORD@@" {{- end }} + {{- if $redisPort }} + port: {{ $redisPort | quote }} + {{- end }} {{- end }} {{- with .Values.extraSecrets }} From 82d0a3053056076e4376777256b675d1c5e71dc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20R=C3=A4thlein?= Date: Sat, 5 Jun 2021 10:32:50 +0000 Subject: [PATCH 2/2] Redis port is a number and should not be quoted (see reviewer comment) --- charts/matrix-synapse/templates/secrets.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/matrix-synapse/templates/secrets.yaml b/charts/matrix-synapse/templates/secrets.yaml index 71b8e3f..02f3aea 100644 --- a/charts/matrix-synapse/templates/secrets.yaml +++ b/charts/matrix-synapse/templates/secrets.yaml @@ -71,7 +71,7 @@ stringData: password: "@@REDIS_PASSWORD@@" {{- end }} {{- if $redisPort }} - port: {{ $redisPort | quote }} + port: {{ $redisPort }} {{- end }} {{- end }}