synapse/changelog.d/12580.bugfix at f90d381c7b93b98a5b6d7353196e2ae0912ea822 - mirrors/synapse - Code den of a Norwegian 🐻

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2025-03-06 16:06:52 +00:00

Sean Quah 0b684b59e5

Fix logging of incorrect status codes for disconnected requests (#12580 )

The status code of requests must always be set, regardless of client
disconnection, otherwise they will always be logged as 200!.

Broken for `respond_with_json` in
f48792eec4.
Broken for `respond_with_json_bytes` in
3e58ce72b4.
Broken for `respond_with_html_bytes` in
ea26e9a98b.

Signed-off-by: Sean Quah <seanq@element.io>

2022-04-28 15:49:50 +00:00

1 line

189 B

Text

Raw Blame History

Fix a long standing bug where status codes would almost always get logged as 200!, irrespective of the actual status code, when clients disconnect before a request has finished processing.