synapse/changelog.d/17728.misc at b066b3aa04248260bd0cfb2ac3569a6e4a3236ea - mirrors/synapse - Code den of a Norwegian 🐻

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-12-14 11:57:44 +00:00

Eric Eastwood faf5b40520

Sliding Sync: Fix _bulk_get_max_event_pos(...) being inefficient (#17728 )

Fix `_bulk_get_max_event_pos(...)` being inefficient. It kept adding all
of the `batch_results` to the `results` over and over every time we
checked a single room in the batch.

I think we still ended up with the right answer before because we
accumulate `recheck_rooms` and actually recheck them to overwrite the
bad data we wrote to the `results` before.

Introduced in
https://github.com/element-hq/synapse/pull/17606/files#diff-cbd54e4b5a2a1646299d659a2d5884d6cb14e608efd2e1658e72b465bb66e31bR1481

2024-09-19 09:32:16 +01:00

1 line

49 B

Text

Raw Blame History

Fix `_bulk_get_max_event_pos` being inefficient.