mirrors/synapse
mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2025-03-06 16:06:52 +00:00
Code Activity

Use SQLite's PRAGMA user_version to check if the database file really matches the schema we have in mind

Browse source
This commit is contained in:
Paul "LeoNerd" Evans 2014-08-20 16:49:54 +01:00
parent 648796ef1d
commit e677a3114e
1 changed files with 28 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
synapse/app/homeserver.py
View file

@ -54,6 +54,11 @@ SCHEMAS = [
] ]
# Remember to update this number every time an incompatible change is made to
# database schema files, so the users will be informed on server restarts.
SCHEMA_VERSION = 1
class SynapseHomeServer(HomeServer): class SynapseHomeServer(HomeServer):
def build_http_client(self): def build_http_client(self):
@ -78,13 +83,30 @@ class SynapseHomeServer(HomeServer):
logging.info("Preparing database: %s...", self.db_name) logging.info("Preparing database: %s...", self.db_name)
with sqlite3.connect(self.db_name) as db_conn: with sqlite3.connect(self.db_name) as db_conn:
for sql_loc in SCHEMAS: c = db_conn.cursor()
sql_script = read_schema(sql_loc) c.execute("PRAGMA user_version")
row = c.fetchone()
c = db_conn.cursor() if row and row[0]:
c.executescript(sql_script) user_version = row[0]
c.close()
db_conn.commit() if user_version < SCHEMA_VERSION:
# TODO(paul): add some kind of intelligent fixup here
raise ValueError("Cannot use this database as the " +
"schema version (%d) does not match (%d)" %
(user_version, SCHEMA_VERSION)
)
else:
for sql_loc in SCHEMAS:
sql_script = read_schema(sql_loc)
c.executescript(sql_script)
db_conn.commit()
c.execute("PRAGMA user_version = %d" % SCHEMA_VERSION)
c.close()
logging.info("Database prepared in %s.", self.db_name) logging.info("Database prepared in %s.", self.db_name)