Remove Generator in _quarantine_media_txn() (#17813)

2024-12-14 11:57:44 +00:00 · 2024-10-30 19:34:11 -05:00 · 2024-10-30 19:34:11 -05:00 · 7987d5e638
commit 7987d5e638
parent 3ae80b0de4
2 changed files with 2 additions and 1 deletions
--- a/changelog.d/17813.bugfix
+++ b/changelog.d/17813.bugfix
@ -0,0 +1 @@
+Avoid lost data on some database query retries.
--- a/synapse/storage/databases/main/room.py
+++ b/synapse/storage/databases/main/room.py
@ -1175,7 +1175,7 @@ class RoomWorkerStore(CacheInvalidationWorkerStore):
                SET quarantined_by = ?
                WHERE media_origin = ? AND media_id = ?
            """,
-            ((quarantined_by, origin, media_id) for origin, media_id in remote_mxcs),
+            [(quarantined_by, origin, media_id) for origin, media_id in remote_mxcs],
        )
        total_media_quarantined += txn.rowcount if txn.rowcount > 0 else 0
				`@ -0,0 +1 @@`
				`Avoid lost data on some database query retries.`