From 77cda342be3c81fa8557d208e67dc1662ddb462a Mon Sep 17 00:00:00 2001
From: Eric Eastwood <erice@element.io>
Date: Tue, 16 May 2023 08:56:42 -0500
Subject: [PATCH] `traceback.format_exception(...)` usage that is compatible
with Python 3.7 and 3.11 (#15599)
* Usage that is compatible with Python 3.8 and 3.11
> Since Python 3.10, instead of passing value and tb, an exception object can
be passed as the first argument. If value and tb are provided, the first
argument is ignored in order to provide backwards compatibility.
>
> -- https://docs.python.org/3/library/traceback.html
* Add changelog
---
changelog.d/15599.bugfix | 1 +
synapse/app/_base.py | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
create mode 100644 changelog.d/15599.bugfix
diff --git a/changelog.d/15599.bugfix b/changelog.d/15599.bugfix
new file mode 100644
index 0000000000..b58af8ad55
--- /dev/null
+++ b/changelog.d/15599.bugfix
@@ -0,0 +1 @@
+Print full error and stack-trace of any exception that occurs during startup/initialization.
diff --git a/synapse/app/_base.py b/synapse/app/_base.py
index 4dfcf484fa..936b1b0430 100644
--- a/synapse/app/_base.py
+++ b/synapse/app/_base.py
@@ -214,7 +214,7 @@ def handle_startup_exception(e: Exception) -> NoReturn:
# the reactor are written to the logs, followed by a summary to stderr.
logger.exception("Exception during startup")
- error_string = "".join(traceback.format_exception(e))
+ error_string = "".join(traceback.format_exception(type(e), e, e.__traceback__))
indented_error_string = indent(error_string, " ")
quit_with_error(