mirror of
https://github.com/element-hq/synapse.git
synced 2024-12-14 11:57:44 +00:00
Add a mechanism for per-test configs (#5657)
It's useful to be able to tweak the homeserver config to be used for each test. This PR adds a mechanism to do so.
This commit is contained in:
parent
a83577d64f
commit
6bb0357c94
2 changed files with 55 additions and 1 deletions
1
changelog.d/5657.misc
Normal file
1
changelog.d/5657.misc
Normal file
|
@ -0,0 +1 @@
|
|||
Add a mechanism for per-test homeserver configuration in the unit tests.
|
|
@ -157,6 +157,21 @@ class HomeserverTestCase(TestCase):
|
|||
"""
|
||||
A base TestCase that reduces boilerplate for HomeServer-using test cases.
|
||||
|
||||
Defines a setUp method which creates a mock reactor, and instantiates a homeserver
|
||||
running on that reactor.
|
||||
|
||||
There are various hooks for modifying the way that the homeserver is instantiated:
|
||||
|
||||
* override make_homeserver, for example by making it pass different parameters into
|
||||
setup_test_homeserver.
|
||||
|
||||
* override default_config, to return a modified configuration dictionary for use
|
||||
by setup_test_homeserver.
|
||||
|
||||
* On a per-test basis, you can use the @override_config decorator to give a
|
||||
dictionary containing additional configuration settings to be added to the basic
|
||||
config dict.
|
||||
|
||||
Attributes:
|
||||
servlets (list[function]): List of servlet registration function.
|
||||
user_id (str): The user ID to assume if auth is hijacked.
|
||||
|
@ -168,6 +183,13 @@ class HomeserverTestCase(TestCase):
|
|||
hijack_auth = True
|
||||
needs_threadpool = False
|
||||
|
||||
def __init__(self, methodName, *args, **kwargs):
|
||||
super().__init__(methodName, *args, **kwargs)
|
||||
|
||||
# see if we have any additional config for this test
|
||||
method = getattr(self, methodName)
|
||||
self._extra_config = getattr(method, "_extra_config", None)
|
||||
|
||||
def setUp(self):
|
||||
"""
|
||||
Set up the TestCase by calling the homeserver constructor, optionally
|
||||
|
@ -276,7 +298,14 @@ class HomeserverTestCase(TestCase):
|
|||
Args:
|
||||
name (str): The homeserver name/domain.
|
||||
"""
|
||||
return default_config(name)
|
||||
config = default_config(name)
|
||||
|
||||
# apply any additional config which was specified via the override_config
|
||||
# decorator.
|
||||
if self._extra_config is not None:
|
||||
config.update(self._extra_config)
|
||||
|
||||
return config
|
||||
|
||||
def prepare(self, reactor, clock, homeserver):
|
||||
"""
|
||||
|
@ -534,3 +563,27 @@ class HomeserverTestCase(TestCase):
|
|||
)
|
||||
self.render(request)
|
||||
self.assertEqual(channel.code, 403, channel.result)
|
||||
|
||||
|
||||
def override_config(extra_config):
|
||||
"""A decorator which can be applied to test functions to give additional HS config
|
||||
|
||||
For use
|
||||
|
||||
For example:
|
||||
|
||||
class MyTestCase(HomeserverTestCase):
|
||||
@override_config({"enable_registration": False, ...})
|
||||
def test_foo(self):
|
||||
...
|
||||
|
||||
Args:
|
||||
extra_config(dict): Additional config settings to be merged into the default
|
||||
config dict before instantiating the test homeserver.
|
||||
"""
|
||||
|
||||
def decorator(func):
|
||||
func._extra_config = extra_config
|
||||
return func
|
||||
|
||||
return decorator
|
||||
|
|
Loading…
Reference in a new issue