From 3d7aead5d62e6da97e006199b3f957325e54b053 Mon Sep 17 00:00:00 2001
From: reivilibre <oliverw@matrix.org>
Date: Mon, 13 Feb 2023 16:30:58 +0000
Subject: [PATCH] Tweak comment on `_is_local_room_accessible` as part of room
visibility in `/hierarchy` to clarify the condition for a room being visible.
(#14834)
---
changelog.d/14834.misc | 1 +
synapse/handlers/room_summary.py | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
create mode 100644 changelog.d/14834.misc
diff --git a/changelog.d/14834.misc b/changelog.d/14834.misc
new file mode 100644
index 0000000000..e683212dc4
--- /dev/null
+++ b/changelog.d/14834.misc
@@ -0,0 +1 @@
+Tweak comment on `_is_local_room_accessible` as part of room visibility in `/hierarchy` to clarify the condition for a room being visible.
\ No newline at end of file
diff --git a/synapse/handlers/room_summary.py b/synapse/handlers/room_summary.py
index 4472019fbc..807245160d 100644
--- a/synapse/handlers/room_summary.py
+++ b/synapse/handlers/room_summary.py
@@ -521,8 +521,8 @@ class RoomSummaryHandler:
It should return true if:
- * The requester is joined or can join the room (per MSC3173).
- * The origin server has any user that is joined or can join the room.
+ * The requesting user is joined or can join the room (per MSC3173); or
+ * The origin server has any user that is joined or can join the room; or
* The history visibility is set to world readable.
Args: