mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-12-14 11:57:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Optimise the event_push_backfill_thread_id bg job (#14172)

Browse source 
Co-authored-by: Erik Johnston <erik@matrix.org>
This commit is contained in:
David Robertson 2022-10-13 18:32:16 +01:00 committed by GitHub
parent 821f74a8c0
commit 16c5d95b59
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/14172.bugfix Normal file
View file

@ -0,0 +1 @@
Fix poor performance of the `event_push_backfill_thread_id` background update, which was introduced in Synapse 1.68.0rc1.

10
synapse/storage/databases/main/event_push_actions.py
View file

@ -297,9 +297,15 @@ class EventPushActionsWorkerStore(ReceiptsWorkerStore, StreamWorkerStore, SQLBas
sql = f""" sql = f"""
UPDATE {table_name} UPDATE {table_name}
SET thread_id = 'main' SET thread_id = 'main'
WHERE stream_ordering <= ? AND thread_id IS NULL WHERE ? < stream_ordering AND stream_ordering <= ? AND thread_id IS NULL
""" """
txn.execute(sql, (max_stream_ordering,)) txn.execute(
sql,
(
start_stream_ordering,
max_stream_ordering,
),
)
# Update progress. # Update progress.
processed_rows = txn.rowcount processed_rows = txn.rowcount