Fix prometheus upgrade tests (#5926)

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>

.github/workflows/test-prom-version-upgrade.yaml

@@ -1,11 +1,11 @@
-name: e2e
+name: Test Prometheus upgrades
 on:
   schedule:
     - cron:  '37 15 * * *' # Every day 15:37
 
 jobs:
-  e2e-tests:
-    name: E2E tests
+  upgrade-prometheus:
+    name: Upgrade Prometheus
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4

test/e2e/main_test.go

@@ -413,13 +413,22 @@ const (
 // TestPrometheusVersionUpgrade tests that all Prometheus versions in the compatibility matrix can be upgraded
 func TestPrometheusVersionUpgrade(t *testing.T) {
 	skipPromVersionUpgradeTests(t)
-	testFuncs := map[string]func(t *testing.T){
-		"PromVersionMigration": testPromVersionMigration,
+
+	testCtx := framework.NewTestCtx(t)
+	defer testCtx.Cleanup(t)
+
+	ns := framework.CreateNamespace(context.Background(), t, testCtx)
+
+	finalizers, err := framework.CreateOrUpdatePrometheusOperator(context.Background(), ns, nil, nil, nil, nil, true, true, true)
+	if err != nil {
+		t.Fatal(err)
 	}
 
-	for name, f := range testFuncs {
-		t.Run(name, f)
+	for _, f := range finalizers {
+		testCtx.AddFinalizerFn(f)
 	}
+
+	t.Run("PromVersionMigration", testPromVersionMigration)
 }
 
 func testServerTLS(ctx context.Context, namespace string) func(t *testing.T) {

test/e2e/prometheus_test.go

@@ -870,7 +870,6 @@ func testPromNoServiceMonitorSelector(t *testing.T) {
 }
 
 func testPromVersionMigration(t *testing.T) {
-	t.Parallel()
 	testCtx := framework.NewTestCtx(t)
 	defer testCtx.Cleanup(t)
 	ns := framework.CreateNamespace(context.Background(), t, testCtx)