Feat: Implemented Github Action linter (#7123)

* ci: add actionlint workflow for GitHub Actions

This workflow integrates actionlint into the CI pipeline to lint and
validate GitHub Actions workflows.

Fixes #7094 

Signed-off-by: slashexx dhruvpuri.35@gmail.com
Co-authored-by: Simon Pasquier <spasquie@redhat.com>

.github/workflows/actionlint.yml

@@ -0,0 +1,22 @@
+name: Lint GitHub action workflows
+on:
+  push:
+    paths:
+      - ".github/workflows/**"
+  pull_request :
+    paths:
+      - ".github/workflows/**"
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - name: Download actionlint
+        id: get_actionlint
+        run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
+        shell: bash
+      - name: Check workflow files
+        run: ${{ steps.get_actionlint.outputs.executable }} -color
+        shell: bash

.github/workflows/changed-files.yaml

@@ -22,6 +22,6 @@ jobs:
     - name: get changed files
       id: changed-files
       run: |
-        echo non-markdown-files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep -iv .md$ | xargs) >> $GITHUB_OUTPUT
+        echo "non-markdown-files=$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep -iv .md$ | xargs)" >> "$GITHUB_OUTPUT"
     - run: |
         echo "${{ steps.changed-files.outputs.non-markdown-files}}"

.github/workflows/checks.yaml

@@ -24,7 +24,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: '${{ env.golang-version }}'
@@ -54,7 +54,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: '${{ env.golang-version }}'
@@ -84,7 +84,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Import environment variables from file
-        run: cat ".github/env" >> $GITHUB_ENV
+        run: cat ".github/env" >> "$GITHUB_ENV"
       - uses: actions/setup-go@v5
         with:
           go-version: '${{ env.golang-version }}'
@@ -103,7 +103,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: '${{ env.golang-version }}'
@@ -121,7 +121,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: '${{ env.golang-version }}'
@@ -134,7 +134,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: '${{ env.golang-version }}'

.github/workflows/e2e-feature-gated.yaml

@@ -25,8 +25,8 @@ jobs:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
       run: |
-        cat ".github/env" >> $GITHUB_ENV
-        echo E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d) >> $GITHUB_ENV
+        cat ".github/env" >> "$GITHUB_ENV"
+        echo "E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d)" >> "$GITHUB_ENV"
     - name: Install Go
       uses: actions/setup-go@v5
       with:

.github/workflows/e2e-prometheus3.yaml

@@ -30,8 +30,8 @@ jobs:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
       run: |
-        cat ".github/env" >> $GITHUB_ENV
-        echo E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d) >> $GITHUB_ENV
+        cat ".github/env" >> "$GITHUB_ENV"
+        echo "E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d)" >> "$GITHUB_ENV"
     - name: Install Go
       uses: actions/setup-go@v5
       with:
@@ -39,7 +39,7 @@ jobs:
         check-latest: true
     - name: Build images
       run: |
-        export SHELL=/bin/bash
+        export SHELL="/bin/bash"
         make build image
     - name: Start kind cluster
       uses: helm/kind-action@v1.10.0

.github/workflows/e2e.yaml

@@ -39,8 +39,8 @@ jobs:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
       run: |
-        cat ".github/env" >> $GITHUB_ENV
-        echo E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d) >> $GITHUB_ENV
+        cat ".github/env" >> "$GITHUB_ENV"
+        echo "E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d)" >> "$GITHUB_ENV"
     - name: Install Go
       uses: actions/setup-go@v5
       with:
@@ -48,7 +48,7 @@ jobs:
         check-latest: true
     - name: Build images
       run: |
-        export SHELL=/bin/bash
+        export SHELL="/bin/bash"
         make build image
     - name: Start kind cluster
       uses: helm/kind-action@v1.10.0

.github/workflows/publish.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Import environment variables from file
-        run: cat ".github/env" >> $GITHUB_ENV
+        run: cat ".github/env" >> "$GITHUB_ENV"
       - name: Reclaim disk space
         run: |
           docker image prune --force --all

.github/workflows/release.yaml

@@ -12,7 +12,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Import environment variables from file
-        run: cat ".github/env" >> $GITHUB_ENV
+        run: cat ".github/env" >> "$GITHUB_ENV"
       - name: Install Go
         uses: actions/setup-go@v5
         with:

.github/workflows/test-prom-version-upgrade.yaml

@@ -18,8 +18,8 @@ jobs:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
       run: |
-        cat ".github/env" >> $GITHUB_ENV
-        echo E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d) >> $GITHUB_ENV
+        cat ".github/env" >> "$GITHUB_ENV"
+        echo "E2E_DIAGNOSTIC_DIRECTORY=$(mktemp -d)" >> "$GITHUB_ENV"
     - name: Install Go
       uses: actions/setup-go@v5
       with:

.github/workflows/unit.yaml

@@ -23,7 +23,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: '${{ env.golang-version }}'
@@ -37,7 +37,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Import environment variables from file
-      run: cat ".github/env" >> $GITHUB_ENV
+      run: cat ".github/env" >> "$GITHUB_ENV"
     - uses: actions/setup-go@v5
       with:
         go-version: ${{ env.golang-version }}