mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2025-03-09 02:07:03 +00:00
Extend the format of feature matcher terms (the elements of the arrayspecified under under matchFeatures field) with new matchName field. The value of this field is an expression that is evaluated against the names of feature elements instead of their values (values are matched with the matchExpressions field, instead). The matchName field is useful e.g. in template rules for creating per-feature-element labels based on feature names (instead of values) and in non-template rules for checking if (at least) one of certain feature element names are present. If both matchExpressions and matchName for certain feature matcher term is specified, they both must match in order to get an overall match. Also, in this case the list of matched features (used in templating) is the union of the results from matchExpressions and matchName. An example of creating an "avx512" label if any AVX512* CPUID feature is present: - name: "avx wildcard rule" labels: avx512: "true" matchFeatures: - feature: cpu.cpuid matchName: {op: InRegexp, value: ["^AVX512"]} An example of a template rule creating a dynamic set of labels based on the existence of certain kconfig options. - name: "kconfig template rule" labelsTemplate: | {{ range .kernel.config }}kconfig-{{ .Name }}={{ .Value }} {{ end }} matchFeatures: - feature: kernel.config matchName: {op: In, value: ["SWAP", "X86", "ARM"]} NOTE: this patch changes the corner case of nil/null match expressions with instance features (i.e. "matchExpressions: null"). Previously, we returned all instances for templating but now a nil match expression is not evaluated and no instances for templating are returned.
288 lines
8.1 KiB
Go
288 lines
8.1 KiB
Go
/*
|
|
Copyright 2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package v1alpha1
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"maps"
|
|
"slices"
|
|
"strings"
|
|
"text/template"
|
|
|
|
corev1 "k8s.io/api/core/v1"
|
|
"k8s.io/klog/v2"
|
|
|
|
"sigs.k8s.io/node-feature-discovery/pkg/utils"
|
|
)
|
|
|
|
// RuleOutput contains the output out rule execution.
|
|
// +k8s:deepcopy-gen=false
|
|
type RuleOutput struct {
|
|
ExtendedResources map[string]string
|
|
Labels map[string]string
|
|
Annotations map[string]string
|
|
Vars map[string]string
|
|
Taints []corev1.Taint
|
|
}
|
|
|
|
// Execute the rule against a set of input features.
|
|
func (r *Rule) Execute(features *Features) (RuleOutput, error) {
|
|
labels := make(map[string]string)
|
|
vars := make(map[string]string)
|
|
|
|
if len(r.MatchAny) > 0 {
|
|
// Logical OR over the matchAny matchers
|
|
matched := false
|
|
for _, matcher := range r.MatchAny {
|
|
if isMatch, matches, err := matcher.match(features); err != nil {
|
|
return RuleOutput{}, err
|
|
} else if isMatch {
|
|
matched = true
|
|
klog.V(4).InfoS("matchAny matched", "ruleName", r.Name, "matchedFeatures", utils.DelayedDumper(matches))
|
|
|
|
if r.LabelsTemplate == "" && r.VarsTemplate == "" {
|
|
// there's no need to evaluate other matchers in MatchAny
|
|
// if there are no templates to be executed on them - so
|
|
// short-circuit and stop on first match here
|
|
break
|
|
}
|
|
|
|
if err := r.executeLabelsTemplate(matches, labels); err != nil {
|
|
return RuleOutput{}, err
|
|
}
|
|
if err := r.executeVarsTemplate(matches, vars); err != nil {
|
|
return RuleOutput{}, err
|
|
}
|
|
}
|
|
}
|
|
if !matched {
|
|
klog.V(2).InfoS("rule did not match", "ruleName", r.Name)
|
|
return RuleOutput{}, nil
|
|
}
|
|
}
|
|
|
|
if len(r.MatchFeatures) > 0 {
|
|
if isMatch, matches, err := r.MatchFeatures.match(features); err != nil {
|
|
return RuleOutput{}, err
|
|
} else if !isMatch {
|
|
klog.V(2).InfoS("rule did not match", "ruleName", r.Name)
|
|
return RuleOutput{}, nil
|
|
} else {
|
|
klog.V(4).InfoS("matchFeatures matched", "ruleName", r.Name, "matchedFeatures", utils.DelayedDumper(matches))
|
|
if err := r.executeLabelsTemplate(matches, labels); err != nil {
|
|
return RuleOutput{}, err
|
|
}
|
|
if err := r.executeVarsTemplate(matches, vars); err != nil {
|
|
return RuleOutput{}, err
|
|
}
|
|
}
|
|
}
|
|
|
|
maps.Copy(labels, r.Labels)
|
|
maps.Copy(vars, r.Vars)
|
|
|
|
ret := RuleOutput{
|
|
Labels: labels,
|
|
Vars: vars,
|
|
Annotations: maps.Clone(r.Annotations),
|
|
ExtendedResources: maps.Clone(r.ExtendedResources),
|
|
Taints: slices.Clone(r.Taints),
|
|
}
|
|
klog.V(2).InfoS("rule matched", "ruleName", r.Name, "ruleOutput", utils.DelayedDumper(ret))
|
|
return ret, nil
|
|
}
|
|
|
|
func (r *Rule) executeLabelsTemplate(in matchedFeatures, out map[string]string) error {
|
|
if r.LabelsTemplate == "" {
|
|
return nil
|
|
}
|
|
|
|
if r.labelsTemplate == nil {
|
|
t, err := newTemplateHelper(r.LabelsTemplate)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to parse LabelsTemplate: %w", err)
|
|
}
|
|
r.labelsTemplate = t
|
|
}
|
|
|
|
labels, err := r.labelsTemplate.expandMap(in)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to expand LabelsTemplate: %w", err)
|
|
}
|
|
for k, v := range labels {
|
|
out[k] = v
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (r *Rule) executeVarsTemplate(in matchedFeatures, out map[string]string) error {
|
|
if r.VarsTemplate == "" {
|
|
return nil
|
|
}
|
|
if r.varsTemplate == nil {
|
|
t, err := newTemplateHelper(r.VarsTemplate)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
r.varsTemplate = t
|
|
}
|
|
|
|
vars, err := r.varsTemplate.expandMap(in)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
for k, v := range vars {
|
|
out[k] = v
|
|
}
|
|
return nil
|
|
}
|
|
|
|
type matchedFeatures map[string]domainMatchedFeatures
|
|
|
|
type domainMatchedFeatures map[string][]MatchedElement
|
|
|
|
func (e *MatchAnyElem) match(features *Features) (bool, matchedFeatures, error) {
|
|
return e.MatchFeatures.match(features)
|
|
}
|
|
|
|
func (m *FeatureMatcher) match(features *Features) (bool, matchedFeatures, error) {
|
|
matches := make(matchedFeatures, len(*m))
|
|
|
|
// Logical AND over the terms
|
|
for _, term := range *m {
|
|
// Ignore case
|
|
featureName := strings.ToLower(term.Feature)
|
|
|
|
nameSplit := strings.SplitN(term.Feature, ".", 2)
|
|
if len(nameSplit) != 2 {
|
|
klog.InfoS("invalid feature name (not <domain>.<feature>), cannot be used for templating", "featureName", term.Feature)
|
|
nameSplit = []string{featureName, ""}
|
|
}
|
|
|
|
dom := nameSplit[0]
|
|
nam := nameSplit[1]
|
|
if _, ok := matches[dom]; !ok {
|
|
matches[dom] = make(domainMatchedFeatures)
|
|
}
|
|
|
|
var isMatch = true
|
|
var matchedElems []MatchedElement
|
|
var err error
|
|
if f, ok := features.Flags[featureName]; ok {
|
|
if term.MatchExpressions != nil {
|
|
isMatch, matchedElems, err = term.MatchExpressions.MatchGetKeys(f.Elements)
|
|
}
|
|
var meTmp []MatchedElement
|
|
if err == nil && isMatch && term.MatchName != nil {
|
|
isMatch, meTmp, err = term.MatchName.MatchKeyNames(f.Elements)
|
|
matchedElems = append(matchedElems, meTmp...)
|
|
}
|
|
} else if f, ok := features.Attributes[featureName]; ok {
|
|
if term.MatchExpressions != nil {
|
|
isMatch, matchedElems, err = term.MatchExpressions.MatchGetValues(f.Elements)
|
|
}
|
|
var meTmp []MatchedElement
|
|
if err == nil && isMatch && term.MatchName != nil {
|
|
isMatch, meTmp, err = term.MatchName.MatchValueNames(f.Elements)
|
|
matchedElems = append(matchedElems, meTmp...)
|
|
}
|
|
} else if f, ok := features.Instances[featureName]; ok {
|
|
if term.MatchExpressions != nil {
|
|
matchedElems, err = term.MatchExpressions.MatchGetInstances(f.Elements)
|
|
isMatch = len(matchedElems) > 0
|
|
}
|
|
var meTmp []MatchedElement
|
|
if err == nil && isMatch && term.MatchName != nil {
|
|
meTmp, err = term.MatchName.MatchInstanceAttributeNames(f.Elements)
|
|
isMatch = len(meTmp) > 0
|
|
matchedElems = append(matchedElems, meTmp...)
|
|
|
|
}
|
|
} else {
|
|
return false, nil, fmt.Errorf("feature %q not available", featureName)
|
|
}
|
|
matches[dom][nam] = append(matches[dom][nam], matchedElems...)
|
|
|
|
if err != nil {
|
|
return false, nil, err
|
|
} else if !isMatch {
|
|
return false, nil, nil
|
|
}
|
|
}
|
|
return true, matches, nil
|
|
}
|
|
|
|
type templateHelper struct {
|
|
template *template.Template
|
|
}
|
|
|
|
func newTemplateHelper(name string) (*templateHelper, error) {
|
|
tmpl, err := template.New("").Option("missingkey=error").Parse(name)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("invalid template: %w", err)
|
|
}
|
|
return &templateHelper{template: tmpl}, nil
|
|
}
|
|
|
|
// DeepCopy is a stub to augment the auto-generated code
|
|
func (h *templateHelper) DeepCopy() *templateHelper {
|
|
if h == nil {
|
|
return nil
|
|
}
|
|
out := new(templateHelper)
|
|
h.DeepCopyInto(out)
|
|
return out
|
|
}
|
|
|
|
// DeepCopyInto is a stub to augment the auto-generated code
|
|
func (h *templateHelper) DeepCopyInto(out *templateHelper) {
|
|
// HACK: just re-use the template
|
|
out.template = h.template
|
|
}
|
|
|
|
func (h *templateHelper) execute(data interface{}) (string, error) {
|
|
var tmp bytes.Buffer
|
|
if err := h.template.Execute(&tmp, data); err != nil {
|
|
return "", err
|
|
}
|
|
return tmp.String(), nil
|
|
}
|
|
|
|
// expandMap is a helper for expanding a template in to a map of strings. Data
|
|
// after executing the template is expexted to be key=value pairs separated by
|
|
// newlines.
|
|
func (h *templateHelper) expandMap(data interface{}) (map[string]string, error) {
|
|
expanded, err := h.execute(data)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Split out individual key-value pairs
|
|
out := make(map[string]string)
|
|
for _, item := range strings.Split(expanded, "\n") {
|
|
// Remove leading/trailing whitespace and skip empty lines
|
|
if trimmed := strings.TrimSpace(item); trimmed != "" {
|
|
split := strings.SplitN(trimmed, "=", 2)
|
|
if len(split) == 1 {
|
|
return nil, fmt.Errorf("missing value in expanded template line %q, (format must be '<key>=<value>')", trimmed)
|
|
}
|
|
out[split[0]] = split[1]
|
|
}
|
|
}
|
|
return out, nil
|
|
}
|