mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2024-12-14 11:57:51 +00:00
8709cccf71
Don't try to be too smart when kubeconfig is needed. In practice, the nfd-master really doesn't work anymore (with the NodeFeature API enabled) without a kubeconfig set. This patch fixes crashes happening when NoPublish is enabled, e.g. in listing all nodes in the nfd api handler and in getting single node objects in the node updater pool. This patch changes the kubeconfig parsing to happen at the creation of the nfd-master instance. We don't need to do that at reconfigure time as none of the dynamic config options affect it. Unit tests are adjusted, accordingly.
52 lines
1.7 KiB
Go
52 lines
1.7 KiB
Go
/*
|
|
Copyright 2019-2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package nfdmaster_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
fakeclient "k8s.io/client-go/kubernetes/fake"
|
|
m "sigs.k8s.io/node-feature-discovery/pkg/nfd-master"
|
|
)
|
|
|
|
func TestNewNfdMaster(t *testing.T) {
|
|
Convey("When initializing new NfdMaster instance", t, func() {
|
|
Convey("When one of -cert-file, -key-file or -ca-file is missing", func() {
|
|
_, err := m.NewNfdMaster(m.WithArgs(&m.Args{CertFile: "crt", KeyFile: "key"}))
|
|
_, err2 := m.NewNfdMaster(m.WithArgs(&m.Args{KeyFile: "key", CaFile: "ca"}))
|
|
_, err3 := m.NewNfdMaster(m.WithArgs(&m.Args{CertFile: "crt", CaFile: "ca"}))
|
|
Convey("An error should be returned", func() {
|
|
So(err, ShouldNotBeNil)
|
|
So(err2, ShouldNotBeNil)
|
|
So(err3, ShouldNotBeNil)
|
|
})
|
|
})
|
|
Convey("When -config is supplied", func() {
|
|
_, err := m.NewNfdMaster(
|
|
m.WithArgs(&m.Args{
|
|
CertFile: "crt",
|
|
KeyFile: "key",
|
|
CaFile: "ca",
|
|
ConfigFile: "master-config.yaml"}),
|
|
m.WithKubernetesClient(fakeclient.NewSimpleClientset()))
|
|
Convey("An error should not be returned", func() {
|
|
So(err, ShouldBeNil)
|
|
})
|
|
})
|
|
})
|
|
}
|