1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-14 11:57:51 +00:00
node-feature-discovery/source/memory/memory.go
TessaIO 316fe71918 fix: take into consideration possibility of having empty line in swap file
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
2024-07-11 22:02:39 +02:00

214 lines
5.8 KiB
Go

/*
Copyright 2018-2021 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package memory
import (
"fmt"
"os"
"path/filepath"
"strconv"
"strings"
"k8s.io/klog/v2"
nfdv1alpha1 "sigs.k8s.io/node-feature-discovery/api/nfd/v1alpha1"
"sigs.k8s.io/node-feature-discovery/pkg/utils"
"sigs.k8s.io/node-feature-discovery/pkg/utils/hostpath"
"sigs.k8s.io/node-feature-discovery/source"
)
// Name of this feature source
const Name = "memory"
// NvFeature is the name of the feature set that holds all discovered NVDIMM devices.
const NvFeature = "nv"
// NumaFeature is the name of the feature set that holds all NUMA related features.
const NumaFeature = "numa"
// SwapFeature is the name of the feature set that holds all Swap related features
const SwapFeature = "swap"
// memorySource implements the FeatureSource and LabelSource interfaces.
type memorySource struct {
features *nfdv1alpha1.Features
}
// Singleton source instance
var (
src memorySource
_ source.FeatureSource = &src
_ source.LabelSource = &src
)
// Name returns an identifier string for this feature source.
func (s *memorySource) Name() string { return Name }
// Priority method of the LabelSource interface
func (s *memorySource) Priority() int { return 0 }
// GetLabels method of the LabelSource interface
func (s *memorySource) GetLabels() (source.FeatureLabels, error) {
labels := source.FeatureLabels{}
features := s.GetFeatures()
// NUMA
if isNuma, ok := features.Attributes[NumaFeature].Elements["is_numa"]; ok && isNuma == "true" {
labels["numa"] = true
}
// Swap
if isSwap, ok := features.Attributes[SwapFeature].Elements["enabled"]; ok && isSwap == "true" {
labels["swap"] = true
}
// NVDIMM
if len(features.Instances[NvFeature].Elements) > 0 {
labels["nv.present"] = true
}
for _, dev := range features.Instances[NvFeature].Elements {
if dev.Attributes["devtype"] == "nd_dax" {
labels["nv.dax"] = true
break
}
}
return labels, nil
}
// Discover method of the FeatureSource interface
func (s *memorySource) Discover() error {
s.features = nfdv1alpha1.NewFeatures()
// Detect NUMA
if numa, err := detectNuma(); err != nil {
klog.ErrorS(err, "failed to detect NUMA nodes")
} else {
s.features.Attributes[NumaFeature] = nfdv1alpha1.AttributeFeatureSet{Elements: numa}
}
// Detect Swap
if swap, err := detectSwap(); err != nil {
klog.ErrorS(err, "failed to detect Swap nodes")
} else {
s.features.Attributes[SwapFeature] = nfdv1alpha1.AttributeFeatureSet{Elements: swap}
}
// Detect NVDIMM
if nv, err := detectNv(); err != nil {
klog.ErrorS(err, "failed to detect nvdimm devices")
} else {
s.features.Instances[NvFeature] = nfdv1alpha1.InstanceFeatureSet{Elements: nv}
}
klog.V(3).InfoS("discovered features", "featureSource", s.Name(), "features", utils.DelayedDumper(s.features))
return nil
}
// GetFeatures method of the FeatureSource Interface.
func (s *memorySource) GetFeatures() *nfdv1alpha1.Features {
if s.features == nil {
s.features = nfdv1alpha1.NewFeatures()
}
return s.features
}
// detectSwap detects Swap node information
func detectSwap() (map[string]string, error) {
procBasePath := hostpath.ProcDir.Path("swaps")
lines, err := getNumberOfNonEmptyLinesFromFile(procBasePath)
if err != nil {
return nil, fmt.Errorf("failed to read swaps file: %w", err)
}
// /proc/swaps has a header row
// If there is more than a header then we assume we have swap.
return map[string]string{
"enabled": strconv.FormatBool(lines > 1),
}, nil
}
// detectNuma detects NUMA node information
func detectNuma() (map[string]string, error) {
sysfsBasePath := hostpath.SysfsDir.Path("bus/node/devices")
nodes, err := os.ReadDir(sysfsBasePath)
if err != nil {
return nil, fmt.Errorf("failed to list numa nodes: %w", err)
}
return map[string]string{
"is_numa": strconv.FormatBool(len(nodes) > 1),
"node_count": strconv.Itoa(len(nodes)),
}, nil
}
// detectNv detects NVDIMM devices
func detectNv() ([]nfdv1alpha1.InstanceFeature, error) {
sysfsBasePath := hostpath.SysfsDir.Path("bus/nd/devices")
info := make([]nfdv1alpha1.InstanceFeature, 0)
devices, err := os.ReadDir(sysfsBasePath)
if os.IsNotExist(err) {
klog.V(1).InfoS("No NVDIMM devices present")
return info, nil
} else if err != nil {
return nil, fmt.Errorf("failed to list nvdimm devices: %w", err)
}
// Iterate over devices
for _, device := range devices {
i := readNdDeviceInfo(filepath.Join(sysfsBasePath, device.Name()))
info = append(info, i)
}
return info, nil
}
// ndDevAttrs is the list of sysfs files (under each nd device) that we're trying to read
var ndDevAttrs = []string{"devtype", "mode"}
func readNdDeviceInfo(path string) nfdv1alpha1.InstanceFeature {
attrs := map[string]string{"name": filepath.Base(path)}
for _, attrName := range ndDevAttrs {
data, err := os.ReadFile(filepath.Join(path, attrName))
if err != nil {
klog.V(3).ErrorS(err, "failed to read nd device attribute", "attributeName", attrName)
continue
}
attrs[attrName] = strings.TrimSpace(string(data))
}
return *nfdv1alpha1.NewInstanceFeature(attrs)
}
func getNumberOfNonEmptyLinesFromFile(path string) (int, error) {
data, err := os.ReadFile(path)
if err != nil {
return 0, err
}
length := 0
for _, line := range strings.Split(string(data), "\n") {
if strings.TrimSpace(line) != "" {
length++
}
}
return length, nil
}
func init() {
source.Register(&src)
}