mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2024-12-15 17:50:49 +00:00
81378a3235
Implement new registration infrastructure under the "source" package. This change loosens the coupling between label sources and the nfd-worker, making it easier to refactor and move the code around. Also, create a separate interface (ConfigurableSource) for configurable feature sources in order to eliminate boilerplate code. Add safety checks to the sources that they actually implement the interfaces they should. In sake of consistency and predictability (of behavior) change all methods of the sources to use pointer receivers. Add simple unit tests for the new functionality and include source/... into make test target.
152 lines
4.1 KiB
Go
152 lines
4.1 KiB
Go
/*
|
|
Copyright 2020-2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package custom
|
|
|
|
import (
|
|
"reflect"
|
|
|
|
"k8s.io/klog/v2"
|
|
|
|
"sigs.k8s.io/node-feature-discovery/pkg/utils"
|
|
"sigs.k8s.io/node-feature-discovery/source"
|
|
"sigs.k8s.io/node-feature-discovery/source/custom/rules"
|
|
)
|
|
|
|
const Name = "custom"
|
|
|
|
// Custom Features Configurations
|
|
type MatchRule struct {
|
|
PciID *rules.PciIDRule `json:"pciId,omitempty"`
|
|
UsbID *rules.UsbIDRule `json:"usbId,omitempty"`
|
|
LoadedKMod *rules.LoadedKModRule `json:"loadedKMod,omitempty"`
|
|
CpuID *rules.CpuIDRule `json:"cpuId,omitempty"`
|
|
Kconfig *rules.KconfigRule `json:"kConfig,omitempty"`
|
|
Nodename *rules.NodenameRule `json:"nodename,omitempty"`
|
|
}
|
|
|
|
type FeatureSpec struct {
|
|
Name string `json:"name"`
|
|
Value *string `json:"value,omitempty"`
|
|
MatchOn []MatchRule `json:"matchOn"`
|
|
}
|
|
|
|
type config []FeatureSpec
|
|
|
|
// newDefaultConfig returns a new config with pre-populated defaults
|
|
func newDefaultConfig() *config {
|
|
return &config{}
|
|
}
|
|
|
|
// customSource implements the LabelSource and ConfigurableSource interfaces.
|
|
type customSource struct {
|
|
config *config
|
|
}
|
|
|
|
// Singleton source instance
|
|
var (
|
|
src customSource
|
|
_ source.LabelSource = &src
|
|
_ source.ConfigurableSource = &src
|
|
)
|
|
|
|
// Name returns the name of the feature source
|
|
func (s *customSource) Name() string { return Name }
|
|
|
|
// NewConfig method of the LabelSource interface
|
|
func (s *customSource) NewConfig() source.Config { return newDefaultConfig() }
|
|
|
|
// GetConfig method of the LabelSource interface
|
|
func (s *customSource) GetConfig() source.Config { return s.config }
|
|
|
|
// SetConfig method of the LabelSource interface
|
|
func (s *customSource) SetConfig(conf source.Config) {
|
|
switch v := conf.(type) {
|
|
case *config:
|
|
s.config = v
|
|
default:
|
|
klog.Fatalf("invalid config type: %T", conf)
|
|
}
|
|
}
|
|
|
|
// Priority method of the LabelSource interface
|
|
func (s *customSource) Priority() int { return 10 }
|
|
|
|
// Discover features
|
|
func (s *customSource) Discover() (source.FeatureLabels, error) {
|
|
features := source.FeatureLabels{}
|
|
allFeatureConfig := append(getStaticFeatureConfig(), *s.config...)
|
|
allFeatureConfig = append(allFeatureConfig, getDirectoryFeatureConfig()...)
|
|
utils.KlogDump(2, "custom features configuration:", " ", allFeatureConfig)
|
|
// Iterate over features
|
|
for _, customFeature := range allFeatureConfig {
|
|
featureExist, err := s.discoverFeature(customFeature)
|
|
if err != nil {
|
|
klog.Errorf("failed to discover feature: %q: %s", customFeature.Name, err.Error())
|
|
continue
|
|
}
|
|
if featureExist {
|
|
var value interface{} = true
|
|
if customFeature.Value != nil {
|
|
value = *customFeature.Value
|
|
}
|
|
features[customFeature.Name] = value
|
|
}
|
|
}
|
|
return features, nil
|
|
}
|
|
|
|
// Process a single feature by Matching on the defined rules.
|
|
// A feature is present if all defined Rules in a MatchRule return a match.
|
|
func (s *customSource) discoverFeature(feature FeatureSpec) (bool, error) {
|
|
for _, matchRules := range feature.MatchOn {
|
|
|
|
allRules := []rules.Rule{
|
|
matchRules.PciID,
|
|
matchRules.UsbID,
|
|
matchRules.LoadedKMod,
|
|
matchRules.CpuID,
|
|
matchRules.Kconfig,
|
|
matchRules.Nodename,
|
|
}
|
|
|
|
// return true, nil if all rules match
|
|
matchRules := func(rules []rules.Rule) (bool, error) {
|
|
for _, rule := range rules {
|
|
if reflect.ValueOf(rule).IsNil() {
|
|
continue
|
|
}
|
|
if match, err := rule.Match(); err != nil {
|
|
return false, err
|
|
} else if !match {
|
|
return false, nil
|
|
}
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
if match, err := matchRules(allRules); err != nil {
|
|
return false, err
|
|
} else if match {
|
|
return true, nil
|
|
}
|
|
}
|
|
return false, nil
|
|
}
|
|
|
|
func init() {
|
|
source.Register(&src)
|
|
}
|