mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2025-03-19 06:43:10 +00:00
99d63d3d33
Additionally, testcases have been separated into distinct functions for better readability. Signed-off-by: Marcin Franczyk <marcin0franczyk@gmail.com>
497 lines
14 KiB
Go
497 lines
14 KiB
Go
/*
|
|
Copyright 2024 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package nodevalidator
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
|
|
compatv1alpha1 "sigs.k8s.io/node-feature-discovery/api/image-compatibility/v1alpha1"
|
|
"sigs.k8s.io/node-feature-discovery/api/nfd/v1alpha1"
|
|
artifactcli "sigs.k8s.io/node-feature-discovery/pkg/client-nfd/compat/artifact-client"
|
|
"sigs.k8s.io/node-feature-discovery/source"
|
|
"sigs.k8s.io/node-feature-discovery/source/fake"
|
|
)
|
|
|
|
func init() {
|
|
fs := source.GetConfigurableSource(fake.Name)
|
|
fs.SetConfig(fs.NewConfig())
|
|
}
|
|
|
|
func buildDefaultSpec(rules []v1alpha1.Rule) *compatv1alpha1.Spec {
|
|
return &compatv1alpha1.Spec{
|
|
Version: compatv1alpha1.Version,
|
|
Compatibilties: []compatv1alpha1.Compatibility{
|
|
{
|
|
Description: "Fake compatibility",
|
|
Rules: rules,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func buildDefaultExpectedOutput(status []ProcessedRuleStatus) []*CompatibilityStatus {
|
|
return []*CompatibilityStatus{
|
|
{
|
|
Description: "Fake compatibility",
|
|
Rules: status,
|
|
},
|
|
}
|
|
}
|
|
|
|
func assertOutput(ctx context.Context, spec *compatv1alpha1.Spec, expectedOutput []*CompatibilityStatus) {
|
|
validator := New(
|
|
WithArgs(&Args{}),
|
|
WithArtifactClient(newMock(ctx, spec)),
|
|
WithSources(map[string]source.FeatureSource{fake.Name: source.GetFeatureSource(fake.Name)}),
|
|
)
|
|
output, err := validator.Execute(ctx)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(output, ShouldEqual, expectedOutput)
|
|
}
|
|
|
|
func TestNodeValidator(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
Convey("With a single compatibility set", t, func() {
|
|
|
|
Convey("That contains flag which results in match", func() {
|
|
spec := buildDefaultSpec([]v1alpha1.Rule{
|
|
{
|
|
Name: "fake_1",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.flag",
|
|
MatchName: &v1alpha1.MatchExpression{Op: v1alpha1.MatchInRegexp, Value: v1alpha1.MatchValue{"^flag"}},
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
expectedOutput := buildDefaultExpectedOutput([]ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_1",
|
|
IsMatch: true,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.flag",
|
|
Name: "",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchInRegexp, Value: v1alpha1.MatchValue{"^flag"}},
|
|
MatcherType: MatchNameType,
|
|
IsMatch: true,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
assertOutput(ctx, spec, expectedOutput)
|
|
})
|
|
|
|
Convey("That contains flags and attribute which result in mismatch", func() {
|
|
spec := buildDefaultSpec([]v1alpha1.Rule{
|
|
{
|
|
Name: "fake_2",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.flag",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"flag_unknown": &v1alpha1.MatchExpression{Op: v1alpha1.MatchExists},
|
|
},
|
|
},
|
|
{
|
|
Feature: "fake.attribute",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"attr_1": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"true"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
expectedOutput := buildDefaultExpectedOutput([]ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_2",
|
|
IsMatch: false,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.attribute",
|
|
Name: "attr_1",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"true"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: true,
|
|
},
|
|
{
|
|
Feature: "fake.flag",
|
|
Name: "flag_unknown",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchExists},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: false,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
assertOutput(ctx, spec, expectedOutput)
|
|
})
|
|
|
|
Convey("That contains instances which results in mismatch", func() {
|
|
spec := buildDefaultSpec([]v1alpha1.Rule{
|
|
{
|
|
Name: "fake_3",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.instance",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"name": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_1"}},
|
|
"attr_1": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"true"}},
|
|
},
|
|
},
|
|
{
|
|
Feature: "fake.instance",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"name": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_2"}},
|
|
"attr_1": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
expectedOutput := buildDefaultExpectedOutput([]ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_3",
|
|
IsMatch: false,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.instance",
|
|
Name: "attr_1",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: false,
|
|
},
|
|
{
|
|
Feature: "fake.instance",
|
|
Name: "attr_1",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"true"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: true,
|
|
},
|
|
{
|
|
Feature: "fake.instance",
|
|
Name: "name",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_1"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: true,
|
|
},
|
|
{
|
|
Feature: "fake.instance",
|
|
Name: "name",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_2"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: true,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
assertOutput(ctx, spec, expectedOutput)
|
|
})
|
|
|
|
Convey("That contains instances which results in match", func() {
|
|
spec := buildDefaultSpec([]v1alpha1.Rule{
|
|
{
|
|
Name: "fake_4",
|
|
MatchAny: []v1alpha1.MatchAnyElem{
|
|
{
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.instance",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"name": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_1"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.instance",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"name": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_unknown"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
expectedOutput := buildDefaultExpectedOutput([]ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_4",
|
|
IsMatch: true,
|
|
MatchedAny: []MatchAnyElem{
|
|
{
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.instance",
|
|
Name: "name",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_1"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: true,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.instance",
|
|
Name: "name",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_unknown"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
assertOutput(ctx, spec, expectedOutput)
|
|
})
|
|
|
|
Convey("That contains spec with zero matches which results in mismatch", func() {
|
|
spec := buildDefaultSpec([]v1alpha1.Rule{
|
|
{
|
|
Name: "fake_5",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "unknown.unknown",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"name": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_1"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
expectedOutput := buildDefaultExpectedOutput([]ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_5",
|
|
IsMatch: false,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "unknown.unknown",
|
|
Name: "name",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"instance_1"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: false,
|
|
},
|
|
},
|
|
},
|
|
})
|
|
|
|
assertOutput(ctx, spec, expectedOutput)
|
|
})
|
|
|
|
})
|
|
|
|
Convey("With multiple compatibility sets", t, func() {
|
|
spec := &compatv1alpha1.Spec{
|
|
Version: compatv1alpha1.Version,
|
|
Compatibilties: []compatv1alpha1.Compatibility{
|
|
{
|
|
Tag: "prefered",
|
|
Weight: 90,
|
|
Description: "Fake compatibility 1",
|
|
Rules: []v1alpha1.Rule{
|
|
{
|
|
Name: "fake_1",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.attribute",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"attr_1": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Tag: "fallback",
|
|
Weight: 40,
|
|
Description: "Fake compatibility 2",
|
|
Rules: []v1alpha1.Rule{
|
|
{
|
|
Name: "fake_1",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.attribute",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"attr_2": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
expectedOutput := []*CompatibilityStatus{
|
|
{
|
|
Tag: "prefered",
|
|
Weight: 90,
|
|
Description: "Fake compatibility 1",
|
|
Rules: []ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_1",
|
|
IsMatch: false,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.attribute",
|
|
Name: "attr_1",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Tag: "fallback",
|
|
Weight: 40,
|
|
Description: "Fake compatibility 2",
|
|
Rules: []ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_1",
|
|
IsMatch: true,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.attribute",
|
|
Name: "attr_2",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: true,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
validator := New(
|
|
WithArgs(&Args{}),
|
|
WithArtifactClient(newMock(ctx, spec)),
|
|
WithSources(map[string]source.FeatureSource{fake.Name: source.GetFeatureSource(fake.Name)}),
|
|
)
|
|
output, err := validator.Execute(ctx)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(output, ShouldEqual, expectedOutput)
|
|
})
|
|
|
|
Convey("With compatibility sets filtered out by tags", t, func() {
|
|
spec := &compatv1alpha1.Spec{
|
|
Version: compatv1alpha1.Version,
|
|
Compatibilties: []compatv1alpha1.Compatibility{
|
|
{
|
|
Tag: "prefered",
|
|
Weight: 90,
|
|
Description: "Fake compatibility 1",
|
|
Rules: []v1alpha1.Rule{
|
|
{
|
|
Name: "fake_1",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.attribute",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"attr_1": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
Tag: "fallback",
|
|
Weight: 40,
|
|
Description: "Fake compatibility 2",
|
|
Rules: []v1alpha1.Rule{
|
|
{
|
|
Name: "fake_1",
|
|
MatchFeatures: v1alpha1.FeatureMatcher{
|
|
{
|
|
Feature: "fake.attribute",
|
|
MatchExpressions: &v1alpha1.MatchExpressionSet{
|
|
"attr_2": &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
expectedOutput := []*CompatibilityStatus{
|
|
{
|
|
Tag: "prefered",
|
|
Weight: 90,
|
|
Description: "Fake compatibility 1",
|
|
Rules: []ProcessedRuleStatus{
|
|
{
|
|
Name: "fake_1",
|
|
IsMatch: false,
|
|
MatchedExpressions: []MatchedExpression{
|
|
{
|
|
Feature: "fake.attribute",
|
|
Name: "attr_1",
|
|
Expression: &v1alpha1.MatchExpression{Op: v1alpha1.MatchIn, Value: v1alpha1.MatchValue{"false"}},
|
|
MatcherType: MatchExpressionType,
|
|
IsMatch: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
validator := New(
|
|
WithArgs(&Args{
|
|
Tags: []string{"prefered"},
|
|
}),
|
|
WithArtifactClient(newMock(ctx, spec)),
|
|
WithSources(map[string]source.FeatureSource{fake.Name: source.GetFeatureSource(fake.Name)}),
|
|
)
|
|
output, err := validator.Execute(ctx)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(output, ShouldEqual, expectedOutput)
|
|
})
|
|
}
|
|
|
|
func newMock(ctx context.Context, result *compatv1alpha1.Spec) *artifactcli.MockArtifactClient {
|
|
artifactClient := &artifactcli.MockArtifactClient{}
|
|
artifactClient.On("FetchCompatibilitySpec", ctx).Return(result, nil)
|
|
return artifactClient
|
|
}
|