mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2025-03-31 04:04:51 +00:00
8ad6210d5c
Sharing the same client between updater threads virtually serializes access, in practice making the effective parallelism close to 1. With this patch, in my bench cluster of 300 nodes, the time taken by updating all nodes drops from ~2 minutes to ~12 seconds (with the default parallelism of 10 node updater threads). This demonstrates the 10-fold increased parallelism from ~1 to 10. There might be other solutions that could be explored, e.g. caching nodes with an indexer/lister but otoh nfd doesn't necessarily need/want to watch every little change in each node. We only need to get the node when something in our own CRDs change (we don't react to any changes in the node object itself). Using multiple clients was the most obvious choice to solve the problem for now. |
||
|---|---|---|
| .. | ||
| metrics.go | ||
| nfd-api-controller.go | ||
| nfd-api-controller_test.go | ||
| nfd-master-internal_test.go | ||
| nfd-master.go | ||
| nfd-master_test.go | ||
| node-updater-pool.go | ||
| node-updater-pool_test.go | ||