mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2024-12-14 11:57:51 +00:00
f13ed2d91c
Drop the gRPC communication to nfd-master and connect to the Kubernetes API server directly when updating NodeResourceTopology objects. Topology-updater already has connection to the API server for listing Pods so this is not that dramatic change. It also simplifies the code a lot as there is no need for the NFD gRPC client and no need for managing TLS certs/keys. This change aligns nfd-topology-updater with the future direction of nfd-worker where the gRPC API is being dropped and replaced by a CRD-based API. This patch also update deployment files and documentation to reflect this change.
100 lines
3.8 KiB
Go
100 lines
3.8 KiB
Go
/*
|
|
Copyright 2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package main
|
|
|
|
import (
|
|
"flag"
|
|
"testing"
|
|
"time"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func TestArgsParse(t *testing.T) {
|
|
Convey("When parsing command line arguments", t, func() {
|
|
flags := flag.NewFlagSet(ProgramName, flag.ExitOnError)
|
|
|
|
Convey("When -no-publish and -oneshot flags are passed", func() {
|
|
args, finderArgs := parseArgs(flags, "-oneshot", "-no-publish", "-kubelet-config-uri=https://%s:%d/configz")
|
|
|
|
Convey("noPublish is set and args.sources is set to the default value", func() {
|
|
So(args.NoPublish, ShouldBeTrue)
|
|
So(args.Oneshot, ShouldBeTrue)
|
|
So(args.ConfigFile, ShouldEqual, "/etc/kubernetes/node-feature-discovery/nfd-topology-updater.conf")
|
|
So(finderArgs.SleepInterval, ShouldEqual, 60*time.Second)
|
|
So(finderArgs.PodResourceSocketPath, ShouldEqual, "/var/lib/kubelet/pod-resources/kubelet.sock")
|
|
})
|
|
})
|
|
|
|
Convey("When valid args are specified for -kubelet-config-url, -sleep-interval and -config,", func() {
|
|
args, finderArgs := parseArgs(flags,
|
|
"-kubelet-config-uri=file:///path/testconfig.yaml",
|
|
"-sleep-interval=30s",
|
|
"-config=/path/nfd-topology-updater.conf")
|
|
|
|
Convey("args.sources is set to appropriate values", func() {
|
|
So(args.NoPublish, ShouldBeFalse)
|
|
So(args.Oneshot, ShouldBeFalse)
|
|
So(args.ConfigFile, ShouldEqual, "/path/nfd-topology-updater.conf")
|
|
So(finderArgs.SleepInterval, ShouldEqual, 30*time.Second)
|
|
So(finderArgs.KubeletConfigURI, ShouldEqual, "file:///path/testconfig.yaml")
|
|
So(finderArgs.PodResourceSocketPath, ShouldEqual, "/var/lib/kubelet/pod-resources/kubelet.sock")
|
|
})
|
|
})
|
|
|
|
Convey("When valid args are specified for -podresources-socket flag and -sleep-interval is specified", func() {
|
|
args, finderArgs := parseArgs(flags,
|
|
"-kubelet-config-uri=https://%s:%d/configz",
|
|
"-podresources-socket=/path/testkubelet.sock",
|
|
"-sleep-interval=30s")
|
|
|
|
Convey("args.sources is set to appropriate values", func() {
|
|
So(args.NoPublish, ShouldBeFalse)
|
|
So(args.Oneshot, ShouldBeFalse)
|
|
So(finderArgs.SleepInterval, ShouldEqual, 30*time.Second)
|
|
So(finderArgs.PodResourceSocketPath, ShouldEqual, "/path/testkubelet.sock")
|
|
})
|
|
})
|
|
Convey("When valid -sleep-inteval is specified", func() {
|
|
args, finderArgs := parseArgs(flags,
|
|
"-kubelet-config-uri=https://%s:%d/configz",
|
|
"-sleep-interval=30s")
|
|
|
|
Convey("args.sources is set to appropriate values", func() {
|
|
So(args.NoPublish, ShouldBeFalse)
|
|
So(args.Oneshot, ShouldBeFalse)
|
|
So(finderArgs.SleepInterval, ShouldEqual, 30*time.Second)
|
|
So(finderArgs.PodResourceSocketPath, ShouldEqual, "/var/lib/kubelet/pod-resources/kubelet.sock")
|
|
})
|
|
})
|
|
|
|
Convey("When All valid args are specified", func() {
|
|
args, finderArgs := parseArgs(flags,
|
|
"-no-publish",
|
|
"-sleep-interval=30s",
|
|
"-kubelet-config-uri=file:///path/testconfig.yaml",
|
|
"-podresources-socket=/path/testkubelet.sock")
|
|
|
|
Convey("-no-publish is set and args.sources is set to appropriate values", func() {
|
|
So(args.NoPublish, ShouldBeTrue)
|
|
So(finderArgs.SleepInterval, ShouldEqual, 30*time.Second)
|
|
So(finderArgs.KubeletConfigURI, ShouldEqual, "file:///path/testconfig.yaml")
|
|
So(finderArgs.PodResourceSocketPath, ShouldEqual, "/path/testkubelet.sock")
|
|
})
|
|
})
|
|
})
|
|
}
|