mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2025-03-05 16:27:05 +00:00
Bring back the -enable-nodefeature-api command line flag and the
corresponding enableNodeFeatureApi helm config value that were
removed without deprecation when the NodeFeatureAPI feature gate was
introduced. The thinking behind this change is to not break existing
users (without warning) unless totally unavoidable. Now the
-enable-nodefeature-api flag is marked as deprecated and slated for
removal in NFD v0.17.
The NodeFeatureAPI feature gate and the -enable-nodefeature-api flag
work together so that the NodeFeature API is disabled (gRPC is enabled,
instead) if either of them is set to false.
This patch selectively reverts parts of
06c4733bc5
.
173 lines
6.4 KiB
Go
173 lines
6.4 KiB
Go
/*
|
|
Copyright 2019-2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package main
|
|
|
|
import (
|
|
"flag"
|
|
"fmt"
|
|
"os"
|
|
|
|
"k8s.io/klog/v2"
|
|
|
|
"sigs.k8s.io/node-feature-discovery/pkg/features"
|
|
worker "sigs.k8s.io/node-feature-discovery/pkg/nfd-worker"
|
|
"sigs.k8s.io/node-feature-discovery/pkg/utils"
|
|
klogutils "sigs.k8s.io/node-feature-discovery/pkg/utils/klog"
|
|
"sigs.k8s.io/node-feature-discovery/pkg/version"
|
|
)
|
|
|
|
const (
|
|
// ProgramName is the canonical name of this program
|
|
ProgramName = "nfd-worker"
|
|
GrpcHealthPort = 8082
|
|
)
|
|
|
|
func main() {
|
|
flags := flag.NewFlagSet(ProgramName, flag.ExitOnError)
|
|
|
|
printVersion := flags.Bool("version", false, "Print version and exit.")
|
|
|
|
// Add FeatureGates flag
|
|
if err := features.NFDMutableFeatureGate.Add(features.DefaultNFDFeatureGates); err != nil {
|
|
klog.ErrorS(err, "failed to add default feature gates")
|
|
os.Exit(1)
|
|
}
|
|
features.NFDMutableFeatureGate.AddFlag(flags)
|
|
|
|
args := parseArgs(flags, os.Args[1:]...)
|
|
|
|
if *printVersion {
|
|
fmt.Println(ProgramName, version.Get())
|
|
os.Exit(0)
|
|
}
|
|
|
|
// Assert that the version is known
|
|
if version.Undefined() {
|
|
klog.InfoS("version not set! Set -ldflags \"-X sigs.k8s.io/node-feature-discovery/pkg/version.version=`git describe --tags --dirty --always`\" during build or run.")
|
|
}
|
|
|
|
// Check deprecated flags
|
|
flags.Visit(func(f *flag.Flag) {
|
|
switch f.Name {
|
|
case "ca-file":
|
|
klog.InfoS("-ca-file is deprecated, will be removed in a future release along with the deprecated gRPC API")
|
|
case "cert-file":
|
|
klog.InfoS("-cert-file is deprecated, will be removed in a future release along with the deprecated gRPC API")
|
|
case "key-file":
|
|
klog.InfoS("-key-file is deprecated, will be removed in a future release along with the deprecated gRPC API")
|
|
case "enable-nodefeature-api":
|
|
klog.InfoS("-enable-nodefeature-api is deprecated and will be removed in the next release, use -feature-gate NodeFeatureAPI instead")
|
|
case "server":
|
|
klog.InfoS("-server is deprecated, will be removed in a future release along with the deprecated gRPC API")
|
|
case "server-name-override":
|
|
klog.InfoS("-server-name-override is deprecated, will be removed in a future release along with the deprecated gRPC API")
|
|
}
|
|
})
|
|
|
|
// Plug klog into grpc logging infrastructure
|
|
utils.ConfigureGrpcKlog()
|
|
|
|
// Get new NfdWorker instance
|
|
args.GrpcHealthPort = GrpcHealthPort
|
|
instance, err := worker.NewNfdWorker(args)
|
|
if err != nil {
|
|
klog.ErrorS(err, "failed to initialize NfdWorker instance")
|
|
os.Exit(1)
|
|
}
|
|
|
|
if err = instance.Run(); err != nil {
|
|
klog.ErrorS(err, "error while running")
|
|
os.Exit(1)
|
|
}
|
|
}
|
|
|
|
func parseArgs(flags *flag.FlagSet, osArgs ...string) *worker.Args {
|
|
args, overrides := initFlags(flags)
|
|
|
|
_ = flags.Parse(osArgs)
|
|
if len(flags.Args()) > 0 {
|
|
fmt.Fprintf(flags.Output(), "unknown command line argument: %s\n", flags.Args()[0])
|
|
flags.Usage()
|
|
os.Exit(2)
|
|
}
|
|
|
|
// Handle overrides
|
|
flags.Visit(func(f *flag.Flag) {
|
|
switch f.Name {
|
|
case "no-publish":
|
|
args.Overrides.NoPublish = overrides.NoPublish
|
|
case "feature-sources":
|
|
args.Overrides.FeatureSources = overrides.FeatureSources
|
|
case "label-sources":
|
|
args.Overrides.LabelSources = overrides.LabelSources
|
|
}
|
|
})
|
|
|
|
return args
|
|
}
|
|
|
|
func initFlags(flagset *flag.FlagSet) (*worker.Args, *worker.ConfigOverrideArgs) {
|
|
args := &worker.Args{}
|
|
|
|
flagset.StringVar(&args.CaFile, "ca-file", "",
|
|
"Root certificate for verifying connections."+
|
|
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")
|
|
flagset.StringVar(&args.CertFile, "cert-file", "",
|
|
"Certificate used for authenticating connections."+
|
|
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")
|
|
flagset.StringVar(&args.ConfigFile, "config", "/etc/kubernetes/node-feature-discovery/nfd-worker.conf",
|
|
"Config file to use.")
|
|
flagset.StringVar(&args.KeyFile, "key-file", "",
|
|
"Private key matching -cert-file."+
|
|
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")
|
|
flagset.BoolVar(&args.EnableNodeFeatureApi, "enable-nodefeature-api", true,
|
|
"Enable the NodeFeature CRD API for communicating with nfd-master. This will automatically disable the gRPC communication."+
|
|
" DEPRECATED: will be removed in NFD v0.17. Use -feature-gate NodeFeatureAPI instead.")
|
|
flagset.StringVar(&args.Kubeconfig, "kubeconfig", "",
|
|
"Kubeconfig to use")
|
|
flagset.BoolVar(&args.Oneshot, "oneshot", false,
|
|
"Do not publish feature labels")
|
|
flagset.IntVar(&args.MetricsPort, "metrics", 8081,
|
|
"Port on which to expose metrics.")
|
|
flagset.StringVar(&args.Options, "options", "",
|
|
"Specify config options from command line. Config options are specified "+
|
|
"in the same format as in the config file (i.e. json or yaml). These options")
|
|
flagset.StringVar(&args.Server, "server", "localhost:8080",
|
|
"NFD server address to connecto to."+
|
|
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")
|
|
flagset.StringVar(&args.ServerNameOverride, "server-name-override", "",
|
|
"Hostname expected from server certificate, useful in testing."+
|
|
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")
|
|
|
|
args.Klog = klogutils.InitKlogFlags(flagset)
|
|
|
|
// Flags overlapping with config file options
|
|
overrides := &worker.ConfigOverrideArgs{
|
|
FeatureSources: &utils.StringSliceVal{},
|
|
LabelSources: &utils.StringSliceVal{},
|
|
}
|
|
overrides.NoPublish = flagset.Bool("no-publish", false,
|
|
"Do not publish discovered features, disable connection to nfd-master and don't create NodeFeature object.")
|
|
flagset.Var(overrides.FeatureSources, "feature-sources",
|
|
"Comma separated list of feature sources. Special value 'all' enables all sources. "+
|
|
"Prefix the source name with '-' to disable it.")
|
|
flagset.Var(overrides.LabelSources, "label-sources",
|
|
"Comma separated list of label sources. Special value 'all' enables all sources. "+
|
|
"Prefix the source name with '-' to disable it.")
|
|
|
|
return args, overrides
|
|
}
|