mirror of
https://github.com/kubernetes-sigs/node-feature-discovery.git
synced 2024-12-14 11:57:51 +00:00
a2b9df5cd3
Extend the FeatureSource interface with new methods for configuration handling. This enables easier on-the fly reconfiguration of the feature sources. Further, it simplifies adding config support to feature sources in the future. Stub methods are added to sources that do not currently have any configurability. The patch fixes some (corner) cases with the overrides (--options) handling, too: - Overrides were not applied if config file was missing or its parsing failed - Overrides for a certain source did not have effect if an empty config for the source was specified in the config file. This was caused by the first pass of parsing (config file) setting a nil pointer to the source-specific config, effectively detaching it from the main config. The second pass would then create a new instance of the source specific config, but, this was not visible in the feature source, of course.
62 lines
1.9 KiB
Go
62 lines
1.9 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package storage
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
|
|
"sigs.k8s.io/node-feature-discovery/source"
|
|
)
|
|
|
|
// Source implements FeatureSource.
|
|
type Source struct{}
|
|
|
|
// Name returns an identifier string for this feature source.
|
|
func (s Source) Name() string { return "storage" }
|
|
|
|
// NewConfig method of the FeatureSource interface
|
|
func (s *Source) NewConfig() source.Config { return nil }
|
|
|
|
// GetConfig method of the FeatureSource interface
|
|
func (s *Source) GetConfig() source.Config { return nil }
|
|
|
|
// SetConfig method of the FeatureSource interface
|
|
func (s *Source) SetConfig(source.Config) {}
|
|
|
|
// Discover returns feature names for storage: nonrotationaldisk if any SSD drive present.
|
|
func (s Source) Discover() (source.Features, error) {
|
|
features := source.Features{}
|
|
|
|
// Check if there is any non-rotational block devices attached to the node
|
|
blockdevices, err := ioutil.ReadDir(source.SysfsDir.Path("block"))
|
|
if err == nil {
|
|
for _, bdev := range blockdevices {
|
|
fname := source.SysfsDir.Path("block", bdev.Name(), "queue/rotational")
|
|
bytes, err := ioutil.ReadFile(fname)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("can't read rotational status: %s", err.Error())
|
|
}
|
|
if bytes[0] == byte('0') {
|
|
// Non-rotational storage is present, add label.
|
|
features["nonrotationaldisk"] = true
|
|
break
|
|
}
|
|
}
|
|
}
|
|
return features, nil
|
|
}
|