AhmedGrati
87c2d7e184
nfd-master: fix resync period config option
...
This PR fixes the resync-period configuration option of the nfd-master.
In fact, previously, changes were not reflected in the nfd-master at
runtime. e2e tests are also implemented to make sure that the fix is
already working as expected.
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-05-02 13:17:01 +02:00
Kubernetes Prow Robot
0685769469
Merge pull request #1204 from marquiz/devel/helm
...
helm: fix mount for nfd-master config
2023-05-02 00:22:12 -07:00
Markus Lehtonen
b016def8a3
helm: fix mount for nfd-master config
...
Volume/mount setup for the ConfigMap was erroneously inside conditionals
so it was not mounted unless TLS was enabled.
2023-05-02 10:06:21 +03:00
Kubernetes Prow Robot
62cd9b3926
Merge pull request #1202 from marquiz/devel/nfd-master-refactor
...
nfd-master: refactor filtering of labels, taints and ERs
2023-04-30 20:16:17 -07:00
Markus Lehtonen
fb20388028
nfd-master: refactor filtering of taints
2023-04-28 18:13:54 +03:00
Markus Lehtonen
43ced0c1a1
nfd-master: refactor filtering of feature labels
...
More consistent error messages. Also preparation for dynamic labels
values (that '@' notation currently supported for extended resources).
2023-04-28 18:13:54 +03:00
Markus Lehtonen
6ca687fbef
nfd-master: refactor filtering of extended resources
...
Simplify code a bit and get more consistent error messages (in addition
to fixing some of those).
2023-04-28 18:13:54 +03:00
Kubernetes Prow Robot
e4dfa2d916
Merge pull request #1198 from marquiz/devel/nfd-api-controller
...
nfd-master: refactor api-controller object handling
2023-04-28 07:56:16 -07:00
Markus Lehtonen
131325fb2c
nfd-master: refactor api-controller object handling
...
Split out resolving of node name (of the node to be updated) into a
separate function. Makes it possible to add unit tests. Also. do
unconditional type casting in the handler functions – that shouldn't
fail unless there is a really serious internal inconsistency in the
codebase so it should be ok to panic.
2023-04-28 17:33:33 +03:00
Kubernetes Prow Robot
60998b5fb3
Merge pull request #1201 from fmuyassarov/codecov-target-patch
...
codecov: drop required minimum coverage ratio at patch level
2023-04-28 07:22:17 -07:00
Muyassarov, Feruzjon
6e423169d5
codecov: drop required minimum coverage ratio of at patch level
...
Signed-off-by: Muyassarov, Feruzjon <feruzjon.muyassarov@intel.com>
2023-04-28 17:00:14 +03:00
Kubernetes Prow Robot
64c1188928
Merge pull request #1200 from fmuyassarov/codecov-target-ratio
...
codecov: drop required minimum coverage ratio of a commit to 0%
2023-04-28 06:38:16 -07:00
Muyassarov, Feruzjon
013830184c
codecov: drop required minimum coverage ratio of commit to 0%
...
Signed-off-by: Muyassarov, Feruzjon <feruzjon.muyassarov@intel.com>
2023-04-28 15:55:39 +03:00
Kubernetes Prow Robot
1405290f19
Merge pull request #1199 from marquiz/devel/codecov
...
scripts/test-infra: provide PR base SHA to codecov
2023-04-28 04:18:16 -07:00
Markus Lehtonen
32072dddf1
scripts/test-infra: provide PR base SHA to codecov
...
In the hopes that codecov will be properly showing and calculating the
diff. Also quote the args for proper handling of empty values.
2023-04-28 13:47:41 +03:00
Kubernetes Prow Robot
9c1912cc7b
Merge pull request #1197 from ArangoGutierrez/notifyv0131
...
Update README to v0.13.1
2023-04-27 04:04:15 -07:00
Carlos Eduardo Arango Gutierrez
aabc698052
Update README to v0.13.1
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-04-27 10:42:19 +02:00
Kubernetes Prow Robot
d84248bc7d
Merge pull request #1190 from marquiz/devel/api-unit-tests
...
apis/nfd: add unit tests for Feature type
2023-04-26 23:32:15 -07:00
Kubernetes Prow Robot
9dd1806403
Merge pull request #1196 from ArangoGutierrez/fix_prepare-release
...
Match usage and example for prepare-release.sh
2023-04-26 02:58:16 -07:00
Kubernetes Prow Robot
7c3d29b9e8
Merge pull request #1194 from marquiz/devel/codecov
...
scripts/test-infra: provide PR info to codecov
2023-04-26 02:20:16 -07:00
Carlos Eduardo Arango Gutierrez
f5d04fca6b
Fix Usage example for prepare-release.sh
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-04-26 11:15:18 +02:00
Markus Lehtonen
611ed65e43
scripts/test-infra: provide PR info to codecov
...
Provide the commit SHA repo slug, PR number, prow build id and base
branch to the codecov tool so that it is able to do its job.
2023-04-26 11:55:13 +03:00
Kubernetes Prow Robot
dbb06905e5
Merge pull request #1191 from marquiz/devel/master-logging
...
nfd-master: log node name when processing NodeFeatureRules
2023-04-26 00:16:17 -07:00
Markus Lehtonen
77011a775f
nfd-master: log node name when processing NodeFeatureRules
2023-04-26 07:22:30 +03:00
Markus Lehtonen
dda7b195ee
apis/nfd: add unit tests for Feature type
2023-04-25 19:40:35 +03:00
Kubernetes Prow Robot
14fed5570b
Merge pull request #1189 from marquiz/devel/docs
...
docs: add missing .md suffix to internal references
2023-04-25 07:00:17 -07:00
Markus Lehtonen
9685d292a2
docs: add missing .md suffix to internal references
...
Commit bfbc47f55e
added a lot of those and
this patch tries to cover all that we missed there. Having .md suffixes
in references to internal files makes it convenient to browse the
document locally, just as text files as the references work correctly.
2023-04-25 15:28:07 +03:00
Kubernetes Prow Robot
54bd4c5d74
Merge pull request #1167 from PiotrProkop/fix-reactive-updates
...
nfd-topology-updater: fix wrong kubelet_internal_checkpoint path and compare basename to full path
2023-04-24 04:41:01 -07:00
pprokop
5a9a12151c
nfd-topology-updater: fix kubelet state file notifier
...
- kubelet_internal_checkpoint file is in /var/lib/kubelet/device-plugins not /var/lib/kubelet
fsWatcher doesn't watch dirs recursively
- e.Name returned from fsWatcher events is a full path not a basename
Signed-off-by: pprokop <pprokop@nvidia.com>
2023-04-24 13:21:56 +02:00
Kubernetes Prow Robot
2356223ffc
Merge pull request #1139 from AhmedGrati/feat-configure-master-resync
...
feat: add master resync period configurability
2023-04-24 03:49:02 -07:00
Kubernetes Prow Robot
72b524a597
Merge pull request #1180 from marquiz/devel/owners
...
OWNERS: add ArangoGutierrez as an approver
2023-04-24 03:07:01 -07:00
AhmedGrati
7917434d38
feat: add master resync period configurability
...
This PR adds a config option for setting the NFD API controller resync period.
The resync period is only activated when the NodeFeature API has been
enabled (with -enable-nodefeature-api).
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-04-24 11:52:38 +02:00
Markus Lehtonen
370f7716b2
OWNERS: add ArangoGutierrez as an approver
...
Also adds marquiz as a reviewer so that all approvers are also
reviewers.
2023-04-24 12:50:10 +03:00
Kubernetes Prow Robot
d980798564
Merge pull request #1178 from marquiz/devel/deps
...
go.mod: update deps
2023-04-24 01:34:27 -07:00
Kubernetes Prow Robot
64fe26ed37
Merge pull request #1169 from ArangoGutierrez/i1168
...
nfd-master: reject malformed extended resource dynamic capacity assignment
2023-04-24 00:17:15 -07:00
Markus Lehtonen
1cdaa44c03
go.mod: update deps
2023-04-22 10:12:49 +03:00
Carlos Eduardo Arango Gutierrez
f5df7b658c
nfd-master: reject malformed extended resource dynamic capacity assignment
...
Reject malformed extended resource dynamic capacity assignment
capacity should be in the form of domain.feature.element,
add logic at func filterExtendedResources to check if true or ignore
ExtendedResource, logging as an error.
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-04-22 08:43:50 +02:00
Kubernetes Prow Robot
d5bccda7c5
Merge pull request #1171 from ArangoGutierrez/foundon_typo
...
pkg/nfd-master/nfd-master.go: Fix typo
2023-04-21 12:21:11 -07:00
Kubernetes Prow Robot
c2c1e18908
Merge pull request #1173 from marquiz/devel/fix-master
...
nfd-master: fix a crash when processing NodeFeatureRules
2023-04-21 09:49:11 -07:00
Markus Lehtonen
9523f1e411
nfd-master: fix a crash when processing NodeFeatureRules
...
Fix a a bug where nfd-master with NodeFeature API enabled would crash
when NodeFeatureRule objects were processed in the case where no
NodeFeature objects existed. This was caused by trying to insert values
into a non-initialized NodeFeatureSpec in the code.
This patch adds two safety measures to prevent that from happening in
the future. First, add a constructor function for the NodeFeatureSpec
type, and second, check for uninitialized object in the function
inserting new functions.
TODO: add unit tests for the API helper functions.
2023-04-21 19:24:08 +03:00
Kubernetes Prow Robot
a425e30bad
Merge pull request #1166 from marquiz/devel/master-annotations
...
nfd-master: don't create emtpy annotations
2023-04-21 08:53:12 -07:00
Carlos Eduardo Arango Gutierrez
ae22031547
pkg/nfd-master/nfd-master.go: Fix typo
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-04-21 16:17:11 +02:00
Markus Lehtonen
37306662fe
nfd-master: don't create emtpy annotations
...
Make the nfd.node.kubernetes.io/feature-labels and
nfd.node.kubernetes.io/extended-resources annotations behave similary to
the taints annotation: only create the annotations if some labels or
extended resources are created.
2023-04-21 16:14:17 +03:00
Kubernetes Prow Robot
e0b076e08b
Merge pull request #1160 from marquiz/fixes/prune
...
nfd-master: fix -prune
2023-04-21 05:11:11 -07:00
Markus Lehtonen
f4de7ed8ee
deployment/kustomize: add master config to prune overlay
...
Otherwise pods error out with failed mount of nfd-master-conf ConfigMap.
2023-04-20 20:38:36 +03:00
Markus Lehtonen
f0f6bbcf36
nfd-master: configure before prune
...
Otherwise prune will crash because of uninitialized configuration.
2023-04-20 20:38:11 +03:00
Kubernetes Prow Robot
5d9907ae86
Merge pull request #1161 from marquiz/fixes/prune-no-publish
...
nfd-master: support noPublish with -prune
2023-04-19 10:01:11 -07:00
Markus Lehtonen
32db081f3a
nfd-master: support noPublish with -prune
...
Better this way than to crash which is what currently happens with this
combination.
2023-04-19 15:58:06 +03:00
Kubernetes Prow Robot
322574385f
Merge pull request #1159 from marquiz/devel/generate-mockery
...
generate: update mockery to v2.25.1
2023-04-19 04:09:11 -07:00
Markus Lehtonen
18f7bfa8e8
generate: update mockery to v2.25.1
...
Bump the vektra/mockery tool to the latest release.
2023-04-19 13:33:42 +03:00