1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-14 11:57:51 +00:00
Commit graph

2674 commits

Author SHA1 Message Date
Markus Lehtonen
54befffa94 nfd-gc: only fetch object metadata
Significantly reduce the apiserver and network load by only
listing/getting the object metadata.
2024-07-30 16:01:04 +03:00
Kubernetes Prow Robot
2d24a4bee4
Merge pull request #1811 from marquiz/devel/informer-listopts
nfd-master: tweak list options for NodeFeature informer
2024-07-30 03:56:04 -07:00
Kubernetes Prow Robot
83779243ad
Merge pull request #1822 from omerap12/issue_1820
Docs: Fixed feature-gates reference
2024-07-30 01:24:38 -07:00
Omer Aplatony
b7c18b949d Docs: Fixed featue-gates reference
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-07-29 17:34:03 +03:00
Kubernetes Prow Robot
f58b09833e
Merge pull request #1818 from kubernetes-sigs/dependabot/go_modules/master/github.com/onsi/ginkgo/v2-2.19.1
build(deps): bump github.com/onsi/ginkgo/v2 from 2.19.0 to 2.19.1
2024-07-29 00:00:29 -07:00
dependabot[bot]
67aadf7b63
build(deps): bump github.com/onsi/ginkgo/v2 from 2.19.0 to 2.19.1
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.19.0 to 2.19.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/ginkgo/compare/v2.19.0...v2.19.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-29 06:41:14 +00:00
Kubernetes Prow Robot
4564b0e25c
Merge pull request #1819 from kubernetes-sigs/dependabot/go_modules/master/github.com/onsi/gomega-1.34.0
build(deps): bump github.com/onsi/gomega from 1.33.1 to 1.34.0
2024-07-28 23:40:09 -07:00
dependabot[bot]
07e7eb9b09
build(deps): bump github.com/onsi/gomega from 1.33.1 to 1.34.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.33.1 to 1.34.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.33.1...v1.34.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-28 09:56:54 +00:00
Kubernetes Prow Robot
094e801b6d
Merge pull request #1812 from marquiz/devel/gc-cache-sync
nfd-gc: check that node informer cache sync succeeded
2024-07-26 07:34:14 -07:00
Markus Lehtonen
454d443b72 nfd-gc: check that node informer cache sync succeeded 2024-07-26 10:29:15 +03:00
Markus Lehtonen
a2068f7ce3 nfd-master: tweak list options for NodeFeature informer
Fix cache syncing problems on big clusters with thousands of NodeFeature
objects.

On the initial list (sync) the client-go cache reflector sets the
ResourceVersion to "0" (instead of leaving it empty). This causes
problems in the api server with (apiserver) logs like:

E writers.go:122] apiserver was unable to write a JSON response: http:
                  Handler timeout
E status.go:71] apiserver received an error that is not an
                metav1.Status: &errors.errorString{s:"http: Handler timeout"}:
                http: Handler timeout

On the nfd-master side we see corresponding log snippets like:

W reflector.go:547] failed to list *v1alpha1.NodeFeature: stream error
                    when reading response body, may be caused by closed
                    connection. Please retry. Original error: stream
                    error: stream ID 1521; INTERNAL_ERROR; received from
                    peer
I trace.go:236] "Reflector ListAndWatch" name:*** (***) (total time:
                61126ms): ---"Objects listed" error:stream error when
                reading response body, may be caused by closed
                connection. Please retry. Original error: stream
                error: stream ID 1521; INTERNAL_ERROR; received from
                peer 61126ms (***)

Decreasing the page size (opts.Limits) does not have any effect on the
timeouts. However, setting ResourceVersion to an empty value seems to
get the paging on its tracks, eliminating the timeouts.

TODO: investigate in Kubernetes upstream the root cause of the timeouts
with ResourceVersion="0".
2024-07-25 16:29:05 +03:00
Kubernetes Prow Robot
bd8d74d6f2
Merge pull request #1809 from marquiz/devel/informer-cache-sync
nfd-master: check nfd api informer cache sync result
2024-07-25 01:22:14 -07:00
Markus Lehtonen
ea3243fb00 nfd-master: check nfd api informer cache sync result
Bail out if there were errors in syncing the cache of any resource.
2024-07-25 09:58:40 +03:00
Carlos Eduardo Arango Gutierrez
cb53f9f3c2
Add helm migration guide
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2024-07-23 16:20:45 +02:00
Kubernetes Prow Robot
493aa0c80e
Merge pull request #1801 from omerap12/issue_1730
helm: add configurable liveness&readiness probes for master topology-updater and worker
2024-07-23 05:50:22 -07:00
Omer Aplatony
b2222e2c8c helm: add configurable liveness&readiness probes for master topology-updater and worker
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-07-22 21:54:25 +03:00
Kubernetes Prow Robot
4e4ccf8818
Merge pull request #1804 from kubernetes-sigs/dependabot/go_modules/master/k8sio-6d3858f6bd
build(deps): bump k8s.io/kubernetes from 1.30.2 to 1.30.3 in the k8sio group
2024-07-22 05:35:16 -07:00
dependabot[bot]
0a63965648 build(deps): bump k8s.io/kubernetes in the k8sio group
Bumps the k8sio group with 1 update: [k8s.io/kubernetes](https://github.com/kubernetes/kubernetes).

Updates `k8s.io/kubernetes` from 1.30.2 to 1.30.3
- [Release notes](https://github.com/kubernetes/kubernetes/releases)
- [Commits](https://github.com/kubernetes/kubernetes/compare/v1.30.2...v1.30.3)

---
updated-dependencies:
- dependency-name: k8s.io/kubernetes
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8sio
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 09:41:19 +03:00
Kubernetes Prow Robot
51f2794d4f
Merge pull request #1798 from marquiz/devel/docker-cache
Dockerfile: cache go modules on build
2024-07-18 09:14:03 -07:00
Markus Lehtonen
2f52f35720 Dockerfile: cache go modules on build 2024-07-18 15:58:16 +03:00
Rouke Broersma
1230d607ac
Helm: Add revision history limit for worker daemonset (#1797)
* Helm: Add revision history limit for worker daemonset

Signed-off-by: Rouke Broersma <mobrockers@gmail.com>

* Helm: Add revision history limit for topology updater daemonset

Signed-off-by: Rouke Broersma <mobrockers@gmail.com>

* chore: tidy table columns

---------

Signed-off-by: Rouke Broersma <mobrockers@gmail.com>
2024-07-18 05:31:49 -07:00
Kubernetes Prow Robot
876eea4374
Merge pull request #1796 from marquiz/devel/helm-lint
scripts/test-infra: bump helm to v3.15.3
2024-07-18 01:16:13 -07:00
Markus Lehtonen
5caaa88d51 scripts/test-infra: bump helm to v3.15.3
Helm is used for linting the chart in the CI.
2024-07-18 08:51:38 +03:00
Kubernetes Prow Robot
a4f41476b0
Merge pull request #1795 from marquiz/devel/golangci-lint
scripts/test-infra: bump golangci-lint to v1.59.1
2024-07-17 12:00:01 -07:00
Markus Lehtonen
4f60f4d8bf scripts/test-infra: bump golangci-lint to v1.59.1 2024-07-17 18:17:03 +03:00
Kubernetes Prow Robot
e30cf85f61
Merge pull request #1778 from marquiz/devel/nf-api-ga
feature-gates: mark NodeFeatureAPI as GA
2024-07-16 06:22:59 -07:00
Kubernetes Prow Robot
f21e694967
Merge pull request #1794 from marquiz/devel/readme
README: update to v0.16.3
2024-07-16 05:26:59 -07:00
Markus Lehtonen
8bef70c470 README: update to v0.16.3 2024-07-16 15:21:10 +03:00
Markus Lehtonen
25e827a4c8 feature-gates: mark NodeFeatureAPI as GA
The feature gate is locked to true. That is, it is not possible to revert
back to the gPRC-based communication which makes the gRPC API ready for
removal.
2024-07-16 13:53:31 +03:00
Kubernetes Prow Robot
57fc83f8c0
Merge pull request #1793 from marquiz/devel/e2e-topology-updater
test/e2e: specify -sleep-interval in topology-updater exclude-memory test
2024-07-16 03:08:48 -07:00
Markus Lehtonen
5aeea28957 test/e2e: specify -sleep-interval in topology-updater exclude-memory test
Make the test finish considerably faster.
2024-07-16 12:47:08 +03:00
Kubernetes Prow Robot
81320d1864
Merge pull request #1791 from marquiz/devel/docs-helm
docs: reformat tables of helm parameters
2024-07-16 01:38:57 -07:00
Kubernetes Prow Robot
8e0951385b
Merge pull request #1790 from marquiz/devel/helm-values
helm: drop trailing whitespace from values.yaml
2024-07-16 01:18:33 -07:00
Kubernetes Prow Robot
ea199c7e37
Merge pull request #1792 from marquiz/devel/e2e-timeout
test/e2e: set topology-updater sleep-interval in podfingerprint test
2024-07-16 01:01:12 -07:00
Markus Lehtonen
5a81f748bf test/e2e: set topology-updater sleep-interval in podfingerprint test
Run topology-updater with short sleep-interval to try to eliminate
flakiness in CI.
2024-07-16 10:22:46 +03:00
Markus Lehtonen
efdf1b8bd9 docs: reformat tables of helm parameters
Also correct the description of default value of master.tolerations.
2024-07-16 09:56:12 +03:00
Markus Lehtonen
fe6a1ac3d9 helm: drop trailing whitespace from values.yaml 2024-07-16 09:41:26 +03:00
Kubernetes Prow Robot
25ffe9c178
Merge pull request #1782 from omerap12/issue_1759
Helm: Add revision history limit for master replica
2024-07-15 01:09:09 -07:00
Kubernetes Prow Robot
4ae762acf5
Merge pull request #1786 from marquiz/devel/deps
go.mod: update kubernetes to v1.30.2 and klog to v2.130.1
2024-07-13 14:07:09 -07:00
Omer Aplatony
920306cba8 Add revision history limit for master replica and for garbage collector
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
2024-07-12 18:20:38 +03:00
Kubernetes Prow Robot
d25fdb64e8
Merge pull request #1788 from marquiz/devel/nfd-worker-tests
nfd-worker: change TestRun to use NodeFeature API
2024-07-12 06:20:07 -07:00
Markus Lehtonen
522b87e325 nfd-worker: change TestRun to use NodeFeature API
Run nfd-worker with NodeFeature API enabled (against a fake apiserver)
instead of using the deprecated gRPC (against a nfd-master instance).

Expand the test to verify the features and labels that are advertised as
a NodeFeature object.
2024-07-12 09:50:09 +03:00
Markus Lehtonen
490aa1d183 go.mod: update kubernetes to v1.30.2 and klog to v2.130.1 2024-07-12 07:52:54 +03:00
Kubernetes Prow Robot
98e9091084
Merge pull request #1781 from TessaIO/fix-swap-empty-line
fix: take into consideration possibility of having empty line in swap file
2024-07-11 21:39:51 -07:00
TessaIO
316fe71918 fix: take into consideration possibility of having empty line in swap file
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
2024-07-11 22:02:39 +02:00
Kubernetes Prow Robot
ee7795cda5
Merge pull request #1780 from marquiz/devel/nodefeatureapi-flag
Drop the -enable-nodefeature-api flag
2024-07-11 10:55:29 -07:00
Kubernetes Prow Robot
783b8dee8c
Merge pull request #1783 from ArangoGutierrez/v0162_readmne
README: update to v0.16.2
2024-07-11 06:41:55 -07:00
Carlos Eduardo Arango Gutierrez
bf164622b8
README: update to v0.16.2
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2024-07-11 15:29:52 +02:00
Markus Lehtonen
a269bf4d25 Drop the -enable-nodefeature-api flag
Was marked to be removed in v0.17.
2024-07-10 15:20:07 +03:00
Kubernetes Prow Robot
393af96a88
Merge pull request #1755 from ArangoGutierrez/1752
Use worker DS OwnerReference for NF's
2024-07-09 06:33:07 -07:00