hang.jiang
698031fc2d
Stop ticker in time to avoid memory leak
...
Because it will cause memory leak if we do not stop ticker when the function has completed.
Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
2023-07-05 18:35:01 +08:00
Kubernetes Prow Robot
f02d172d07
Merge pull request #1253 from adrianchiris/fix-typo-in-helm-template
...
fix typo in helm chart
2023-07-03 02:46:53 -07:00
adrianc
904f3739a3
fix typo in helm chart
...
else statement of crd-controller should
also refer to crd-controller flag.
Signed-off-by: adrianc <adrianc@nvidia.com>
2023-07-02 18:01:31 +03:00
Kubernetes Prow Robot
10bbc8f253
Merge pull request #1248 from testwill/pkg-import
...
Remove pkg's imported twice
2023-06-28 05:54:32 -07:00
guoguangwu
29118f67bb
fix: Drop the e2elog instead
...
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
2023-06-25 09:44:08 +08:00
Kubernetes Prow Robot
407a610e0c
Merge pull request #1182 from fmuyassarov/disable-hooks-by-default
...
hooks: disable hooks by default from v0.14
2023-06-22 04:43:40 -07:00
guoguangwu
92482e45d8
node_feature_discovery_test.go rm pkg imported twice
...
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
2023-06-21 16:55:25 +08:00
guoguangwu
b946bcc0f5
nfd-master-internal_test.go rm pkg imported twice
...
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
2023-06-21 16:53:55 +08:00
Kubernetes Prow Robot
aa55cd5999
Merge pull request #1247 from ArangoGutierrez/fix_docs_typo
...
Docs: Fix typo on customization-guide
2023-06-09 01:38:13 -07:00
Carlos Eduardo Arango Gutierrez
563cc862de
Docs: Fix typo on customization-guide
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-06-09 10:23:33 +02:00
Kubernetes Prow Robot
ad1bf43d25
Merge pull request #1246 from dipankardas011/fix-depricated-use-of-base-in-kustomize
...
Removal of the bases field as it is deprecated by kustomize
2023-06-09 00:30:13 -07:00
Dipankar Das
ebac4a25e7
Removal of the bases field as it is deprecated by kustomize
...
Signed-off-by: Dipankar Das <dipankardas0115@gmail.com>
2023-06-09 12:49:24 +05:30
Muyassarov, Feruzjon
19527be924
hooks: disable hooks by default
...
We have deprecated hooks in v0.12.0 but kept it enabled by default.
Starting from v0.14 we are starting to disable it by default and
plan to fully remove it in the near future.
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
2023-06-07 13:04:23 +03:00
Kubernetes Prow Robot
6b0cb6fc33
Merge pull request #1244 from ArangoGutierrez/quick_fix_main_cmd
...
Fix a typo on nfd-master cmd
2023-06-07 02:30:12 -07:00
Kubernetes Prow Robot
1da55b04f7
Merge pull request #1245 from sj14/fix-jq
...
Fix missing apostrophe for jq
2023-06-07 01:52:12 -07:00
Simon Jürgensmeyer
307a865465
Fix missing apostrophe for jq
2023-06-07 09:53:02 +02:00
Kubernetes Prow Robot
b9fa66b716
Merge pull request #1243 from marquiz/devel/kustomize-named-port
...
deployment/kustomize: use a named port for nfd gRPC service
2023-06-06 11:20:11 -07:00
Carlos Eduardo Arango Gutierrez
c02c3d83ed
Fix a typo on nfd-master cmd
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-06-06 20:05:07 +02:00
Markus Lehtonen
457fc8483b
deployment/kustomize: use a named port for nfd gRPC service
2023-06-06 21:00:42 +03:00
Kubernetes Prow Robot
febebd4afd
Merge pull request #1240 from fidencio/topic/add-tdx-protected-label-for-tdx-guests
...
cpu: Discover TDX guests based on cpuid information
2023-06-05 03:45:25 -07:00
Hairong Chen
e8a00ba7da
cpu: Discover TDX guests based on cpuid information
...
NFD already has the capability to discover whether baremetal / host
machines support Intel TDX. Now, the next step is to add support for
discovering whether a node is TDX protected (as in, a virtual machine
started using Intel TDX).
In order to do so, we've decided to go for a new `cpu-security.tdx`
property, called `protected` (`cpu-security.tdx.protected`).
Signed-off-by: Hairong Chen <hairong.chen@intel.com>
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
2023-06-05 11:06:28 +02:00
Fabiano Fidêncio
8a65d8f5a1
go.mod: Update cpuid to its v2.2.5 release
...
Let's update the cpuid to its v2.2.5 release, released on June 2nd,
2023, as it brings in information about TDX guests.
Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
2023-06-02 17:19:27 +02:00
Kubernetes Prow Robot
306969a945
Merge pull request #1133 from AhmedGrati/feat-parallelize-nodes-update
...
feat: parallelize nodes update
2023-06-02 05:28:57 -07:00
AhmedGrati
b3cfe17392
feat: parallelize nodes update
...
This PR aims to optimize the process of updating nodes with
corresponding features. In fact, previously, we were updating nodes
sequentially even though they are independent from each other.
Therefore, we integrated new components: LabelersNodePool which is
responsible for spininng a goroutine whenever there's a request for
updating nodes, and a Workqueue which is responsible for holding nodes names
that should be updated.
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-06-02 11:41:50 +01:00
Kubernetes Prow Robot
4dea63c9fc
Merge pull request #1226 from AhmedGrati/feat-support-dynamic-values-nfr-labels
...
feat: support dynamic values for labels in the NodeFeatureRule
2023-06-01 06:17:46 -07:00
Kubernetes Prow Robot
b07ae412b1
Merge pull request #1239 from marquiz/devel/issue-templates
...
github: update new-release issue template
2023-06-01 05:55:46 -07:00
Kubernetes Prow Robot
1c3d24d02b
Merge pull request #1238 from marquiz/devel/readme
...
Update README to v0.13.2
2023-06-01 05:53:46 -07:00
Markus Lehtonen
ab999b647e
github: update new-release issue template
...
Only instruct to spam kubernetes dev mailing list on major releases.
2023-06-01 15:43:49 +03:00
Markus Lehtonen
8774aef920
Update README to v0.13.2
2023-06-01 15:04:06 +03:00
AhmedGrati
08b9c3486e
feat: support dynamic values for labels in the NodeFeatureRule
...
This PR aims to support the dynamic values for labels in the
NodeFeatureRule CRD, it would offer more flexible labeling for users.
To achieve this, we check whether label value starts with "@", and if
it's the case, we will get the value of the feature value, and update
the value of the label with the feature value.
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
2023-05-31 23:30:26 +01:00
Kubernetes Prow Robot
d64398f85e
Merge pull request #1235 from marquiz/devel/logging
...
scripts/test-infra: add logcheck to verify script
2023-05-31 08:05:46 -07:00
Markus Lehtonen
01525de2f1
scripts/test-infra: add logcheck to verify script
...
Now that we've migrated to structured logging add a verification step to
verify that future additions/changes to logging comply.
2023-05-31 16:01:40 +03:00
Kubernetes Prow Robot
2331b0f14f
Merge pull request #1223 from marquiz/devel/logging
...
Migrate to structured logging
2023-05-31 05:17:46 -07:00
Markus Lehtonen
bf670de68d
pkg/utils: migrate KlogDump to structured logging
...
Drop the KlogDump helper in favor of klog.InfoS. However, that patch
introduces a new DelayedDumper() helper to avoid processing
(marshalling) of object unless really evaluated by the logging function.
2023-05-31 14:43:08 +03:00
Markus Lehtonen
fe267a634b
source: migrate to structured logging
...
The custom.d config file parsing is made a bit less verbose.
2023-05-31 14:43:08 +03:00
Markus Lehtonen
4947ebf336
pkg/util: migrate to structured logging
...
We gRPC logging interface is not compatible with structured logging so
grpcLogger is left intact.
2023-05-31 14:43:08 +03:00
Markus Lehtonen
64d5af016e
apis/nfd: migrate to structured logging
2023-05-31 14:43:08 +03:00
Markus Lehtonen
6e3b181ab4
topology-updater: migrate to structured logging
2023-05-31 14:43:08 +03:00
Markus Lehtonen
7be08f9e7f
nfd-worker: migrate to structured logging
2023-05-31 14:43:08 +03:00
Markus Lehtonen
8113d651c2
nfd-master: migrate to structured logging
2023-05-31 14:43:05 +03:00
Kubernetes Prow Robot
326521fe28
Merge pull request #1228 from marquiz/devel/label-validation
...
nfd-master: add validation of label names and values
2023-05-31 02:31:46 -07:00
Kubernetes Prow Robot
68b728fd34
Merge pull request #1230 from marquiz/devel/golangci-lint
...
scripts/test-infra: bump golangci-lint to v1.52.2
2023-05-31 00:21:46 -07:00
Markus Lehtonen
9b74e12f60
scripts/test-infra: bump golangci-lint to v1.52.2
2023-05-30 22:27:05 +03:00
Markus Lehtonen
2a3c7e4c93
nfd-master: add validation of label names and values
...
Validate labels before trying to update the node. Makes us fail early
nad prevent useless retries in case invalid labels are tried.
2023-05-29 16:54:14 +03:00
Kubernetes Prow Robot
7d715109e3
Merge pull request #1227 from marquiz/devel/master-stop
...
nfd-master: use close for stop channel
2023-05-26 02:02:53 -07:00
Markus Lehtonen
1809c24314
nfd-master: use close for stop channel
...
Simpler and more reliable (in case of multiple consumers) to just close
the channel.
2023-05-24 16:51:48 +03:00
Kubernetes Prow Robot
d28a02c5cd
Merge pull request #1222 from vaibhav2107/kustomize-type
...
Fixed typo in Header under deployment/kustomize.md
2023-05-22 00:42:21 -07:00
Kubernetes Prow Robot
70d5ef477f
Merge pull request #1219 from PiotrProkop/leader-elect
...
Add leader election for nfd-master
2023-05-22 00:36:21 -07:00
vaibhav2107
9f7854479f
Fixed type in Header under deployment/kustomize.md
2023-05-18 14:59:54 +05:30
PiotrProkop
272fd4784f
Add new flag enable-leader-election for nfd-master.
...
It allows NFD-master to be run in active-passive way when running
multiple instances of NFD-master to prevent multiple components
from updating same custom resources.
Signed-off-by: PiotrProkop <pprokop@nvidia.com>
2023-05-15 13:30:07 +02:00