1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2025-03-06 16:57:10 +00:00
Commit graph

694 commits

Author SHA1 Message Date
Markus Lehtonen
cdca6d667a nfd-master: make nodeName non-global 2021-02-10 13:46:59 +02:00
Markus Lehtonen
b146508e64 nfd-master: drop separate labelerServer type
Simplify code by changing nfdMaster to implement LabelerServer interface
by itself.
2021-02-10 13:46:59 +02:00
Kubernetes Prow Robot
01384d434f
Merge pull request #435 from marquiz/fixes/filepath
Replace improper usage of filepath.Join with path.Join
2021-02-10 03:44:59 -08:00
Kubernetes Prow Robot
fbde30a164
Merge pull request #436 from marquiz/devel/golangci-lint
scripts/test-infra: update golangci-lint to v1.36.0
2021-02-10 03:36:59 -08:00
Markus Lehtonen
44b52b69be scripts/test-infra: update golangci-lint to v1.36.0 2021-02-10 12:58:44 +02:00
Markus Lehtonen
76b95b6c55 Replace improper usage of filepath.Join with path.Join
In JSON and kubernetes API object names we want to use slashes instead
of the OS dependent file path separator.
2021-02-10 12:54:31 +02:00
Kubernetes Prow Robot
f0513eeda0
Merge pull request #434 from marquiz/devel/template-auto-update
Change the worker conf update mechanism of templates
2021-02-04 13:20:52 -08:00
Markus Lehtonen
569e0f2017 Change the worker conf update mechanism of templates
Rely on markers instead which makes the update work also in the middle
of a template file. Previously it relied on the configuration data to be
at the very end of the file to be updated.
2021-02-04 18:56:55 +02:00
Kubernetes Prow Robot
5094eadedc
Merge pull request #430 from marquiz/devel/templates-pull-policy
Set imagePullPolicy in the deployment templates to Always
2021-02-03 09:46:28 -08:00
Markus Lehtonen
040604eeb4 Set imagePullPolicy in the deployment templates to Always
Update prepare-release.sh so that the policy will be set to IfNotPresent
for releases.
2021-02-03 18:26:54 +02:00
Kubernetes Prow Robot
4af5311880
Merge pull request #421 from mythi/cpuid-v2.0.1
go.mod: update to klauspost/cpuid/v2@v2.0.2
2020-12-15 06:51:48 -08:00
Mikko Ylinen
07bc50d5a8 go.mod: update to klauspost/cpuid/v2@v2.02
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
2020-12-15 15:56:15 +02:00
Kubernetes Prow Robot
8be8d1b6db
Merge pull request #420 from marquiz/documentation/readme
README: update references to v0.7.0
2020-12-14 11:47:48 -08:00
Markus Lehtonen
5912177a03 README: update references to v0.7.0 2020-12-08 10:25:35 +02:00
Kubernetes Prow Robot
288b1869c1
Merge pull request #419 from marquiz/fixes/gh-pages
github: workflow fixes
2020-12-07 08:39:26 -08:00
Markus Lehtonen
30e3d0b8b9 github: switch to checkout v1
V2 handles tags incorrectly
(https://github.com/actions/checkout/issues/290) and the easiest
solution is to simply switch to v1.
2020-12-07 12:35:05 +02:00
Markus Lehtonen
ee02dd7033 scripts/update-gh-pages: add more details when stopping 2020-12-07 12:34:50 +02:00
Kubernetes Prow Robot
b59293c18b
Merge pull request #416 from ArangoGutierrez/cp-415
Cherry-pick: github: update new-release issue template
2020-12-04 10:15:59 -08:00
Markus Lehtonen
16acc2b433
github: update new-release issue template 2020-12-04 13:00:11 -05:00
Kubernetes Prow Robot
8aa9460e66
Merge pull request #406 from mythi/cpuid-v2.0
go.mod: update klauspost/cpuid
2020-12-04 06:21:59 -08:00
Kubernetes Prow Robot
c624c88b10
Merge pull request #412 from marquiz/devel/prune
Add namespace and RBAC rules to nfd-prune.yaml.template
2020-12-03 05:41:00 -08:00
Kubernetes Prow Robot
24937bbed6
Merge pull request #411 from marquiz/documentation/uninstall
docs: more options in uninstallation instructions
2020-12-03 04:50:59 -08:00
Markus Lehtonen
c7e66d910f Add namespace and RBAC rules to nfd-prune.yaml.template
Makes it possible to run prune on its own. Reflect this change in the
documentation.
2020-12-03 14:41:54 +02:00
Markus Lehtonen
d2bfa3c39b docs: more options in uninstallation instructions 2020-12-03 14:36:42 +02:00
Kubernetes Prow Robot
9ea5329ab6
Merge pull request #409 from marquiz/fixes/gh-pages-2
scripts/update-gh-pages: fix generated commit message
2020-12-03 04:18:59 -08:00
Kubernetes Prow Robot
1d021d02b8
Merge pull request #410 from marquiz/fixes/templates
Fix auto-generation of nfd-prune.yaml
2020-12-03 03:57:00 -08:00
Markus Lehtonen
7cb66bbba1 Fix auto-generation of nfd-prune.yaml
Change the template so that our sed magic updates the container image
name correctly.
2020-12-03 13:34:26 +02:00
Kubernetes Prow Robot
7f5d2390bf
Merge pull request #408 from marquiz/fixes/gh-pages
scripts/update-gh-pages: only update docs if version has been released
2020-12-03 03:01:00 -08:00
Markus Lehtonen
ad042f92f5 scripts/update-gh-pages: only update docs if version has been released
Only update documentation if the version has been released (i.e. a git
tag corresponding the version we're updating exists) or it is for the
master branch. Prevents us from pointing users to documentation of an
unreleased version.

Also updates github workflow to fetch full commit history (including
tags) so that git describe works correctly.
2020-12-03 12:54:14 +02:00
Markus Lehtonen
9d4e89ae8f scripts/update-gh-pages: fix generated commit message 2020-12-03 12:30:37 +02:00
Mikko Ylinen
94f49b9418 go.mod: update klauspost/cpuid
The latest changes in klauspost/cpuid add detection for Sapphire Rapids
new instructions.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
2020-11-30 19:04:41 +02:00
Kubernetes Prow Robot
42d3fa19ef
Merge pull request #404 from ArangoGutierrez/kubeconfig_env_e2e
be a bit more verbose on a required KUBECONFIG env var
2020-11-24 21:16:39 -08:00
Carlos Eduardo Arango Gutierrez
30e64468de
Makefile: require KUBECONFIG to be specified for e2e-test target
This Patch adds a check on make target e2e-test, to check if the
KUBECONFIG env var is set before running the test suite.

if not pressent return a valid error message.

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
2020-11-24 16:50:55 -05:00
Kubernetes Prow Robot
a27a69e452
Merge pull request #405 from marquiz/devel/gitignore
gitignore: add bin/
2020-11-24 11:46:40 -08:00
Markus Lehtonen
5528387bc4 gitignore: add bin/ 2020-11-24 21:23:15 +02:00
Kubernetes Prow Robot
a0f59ef22f
Merge pull request #336 from marquiz/devel/122
nfd-master: patch node object instead of rewriting it
2020-11-24 04:51:00 -08:00
Markus Lehtonen
19b8f2cd3d nfd-master: more detailed unit testing of extended resources 2020-11-24 12:45:06 +02:00
Markus Lehtonen
d17743a0b9 nfd-master: handle label annotations in the same func
Handle both creation and parsing of the "feature-labels" and
"extended-resources" annotations in the function. I think this is more
logical to keep them together.
2020-11-24 12:45:06 +02:00
Markus Lehtonen
95ff300d74 nfd-master: patch node object instead of rewriting it
When updating node labels and annotations use JSON patches instead of
doing a read-modify-write on the whole node object. Patching is already
being used in managing extended resources so some of the existing code
was re-usable.

This patch should mitigate the problem of node update failures caused by
race conditions (a change in the node object between our read and write)
resulting e.g. in errors/restarts in nfd worker pods.
2020-11-24 12:45:06 +02:00
Markus Lehtonen
1ea301d272 nfd-master: change statusOp to a more generalized JSON patch
Generalize and rename 'statusOp' type to a more flexible 'JsonPatch'.
Move it to the apihelper package.
2020-11-24 12:45:06 +02:00
Markus Lehtonen
bb1e4c60fb nfd-master: use namespaced label and annotation names internally
For historical reasons the labels in the default nfd namespace have been
internally represented without the namespace part. I.e. instead of
"feature.node.kubernetes.io/foo" we just use "foo". NFD worker uses this
representation, too, both internally and over the gRPC requests. The
same scheme has been used for annotations.

This patch changes NFD master to use fully namespaced label and
annotation names internally. This hopefully makes the code a bit more
understandable. It also addresses some corner cases making the handling
of label names consistent, making it possible to use both "truncated"
and fully namespaced names over the gRPC interface (and in the
annotations).
2020-11-24 12:45:06 +02:00
Kubernetes Prow Robot
7f3f9d7ed8
Merge pull request #403 from marquiz/fixes/e2e
test/e2e: fix e2e-config node matching
2020-11-24 02:09:00 -08:00
Markus Lehtonen
0512b06027 test/e2e: fix e2e-config node matching
Pick the correct rule when multiple node rules are present.
2020-11-24 11:35:35 +02:00
Kubernetes Prow Robot
9b8451209c
Merge pull request #402 from marquiz/fixes/kernel-version-sanitize
kernel: more agressively sanitize full kernel version
2020-11-23 09:57:34 -08:00
Kubernetes Prow Robot
def4b60d65
Merge pull request #386 from marquiz/devel/default-configmap
Add nfd-worker-conf ConfigMap to deployment templates
2020-11-23 09:07:34 -08:00
Markus Lehtonen
ba4ecfe7dc kernel: more agressively sanitize full kernel version
Trim illegal characters from the beginning and end of the kernel version
string. Label values must start and end with an alphanumeric and we want
to have some 'version.full' label, even if a sanitized one.
2020-11-23 19:04:12 +02:00
Markus Lehtonen
979d3b88fe Add nfd-worker-conf ConfigMap to deployment templates
Add a virtually empty ConfigMap that is mounted inside the workers.
Makes it easier to start customizing the worker deployment e.g. with just:

  $ kubectl -n ${NFD_NS} edit configmap nfd-worker-conf

Create a new 'templates' make target for inserting the content of
nfd-worker.conf.example into the configmap spec of the templates. Thus,
'make templates' should be run whenever the example config is update.
Update the verify.sh prow script to check that the templates are up to
date.

This patch also streamlines the documentation about configuration
management, reflecting the changes.
2020-11-23 18:49:52 +02:00
Markus Lehtonen
f72ec8f9b2 Sync nfd-worker-job.template with others
Add TLS placeholders.
2020-11-23 16:04:37 +02:00
Kubernetes Prow Robot
83e2a9defb
Merge pull request #356 from marquiz/devel/sources-flag
nfd-worker: add special handling for --sources=all
2020-11-22 01:53:33 -08:00
Kubernetes Prow Robot
16095ea6bc
Merge pull request #401 from dsb3/version-bump
Container base image version bump
2020-11-21 08:51:33 -08:00