Markus Lehtonen
b2d9e15a00
apis/nfd: drop the private template caching fields
...
Drop the private fields – that were supposed to be used for caching parsed
templates – from the Rule type. Keep the API typedefs cleaner and
simpler. Moreover, the caching was not even used in practice,
effectively complicating code without any benefit: the way the types
are used in nfd-master creates a local copy of Rule type storing the
cached template in the copy, wasting it from any future users.
There are also other possible caveats in caching like we tried to do it.
For example the objects returned by the api lister are supposed to be
treated as read-only - in particular if we would be to modify them there
should at least be proper locking in place as nfd-master potentially
processes the same rule (the same Go object) in parallel for multiple
nodes. If any optimization like this will be pursued it should be done
properly, probably with private type(s) at the consumer's end, not
contaminating the API types.
2023-12-15 10:48:07 +02:00
Kubernetes Prow Robot
443ff80748
Merge pull request #1481 from marquiz/devel/api-creation-funcs
...
apis/nfd: drop creation helper functions
2023-12-14 18:41:18 +01:00
Markus Lehtonen
0bc1b6c28f
apis/nfd: drop creation helper functions
...
Drop the creation helper functions as one step in an effort to tidy up
the api package. These functions were not much used outside unit tests
anyway, the static rules of the nfd-worker custom feature source being
the only exception (and if those happened to be invalid we'd catch that
e.g. in the e2e-tests).
2023-12-14 15:54:51 +02:00
Kubernetes Prow Robot
3ce5a1b218
Merge pull request #1482 from marquiz/devel/api-cleanup-2
...
apis/nfd: drop the private regexp caching field
2023-12-14 12:08:58 +01:00
Kubernetes Prow Robot
f0d3bce8c6
Merge pull request #1503 from marquiz/devel/maps
...
Use generics for maps and slices
2023-12-14 11:37:06 +01:00
Markus Lehtonen
cb0a46ec0e
Use generics for maps and slices
2023-12-13 12:09:53 +02:00
Kubernetes Prow Robot
6ef153e4c3
Merge pull request #1502 from marquiz/devel/maps
...
Use non-exp maps package
2023-12-12 17:14:05 +01:00
Markus Lehtonen
8e477cdfa4
Use non-exp maps package
...
The maps package became available as a standard non-experimental package
in Go 1.21.
2023-12-12 17:31:25 +02:00
Kubernetes Prow Robot
605c66974a
Merge pull request #1501 from marquiz/devel/fix-deny-ns
...
nfd-master: remove default denied ns from config
2023-12-12 15:29:54 +01:00
Markus Lehtonen
a77983556f
nfd-master: remove default denied ns from config
...
These are now handled by the validate package. If we have them here in
nfd-master, the default namespace (feature.node.kubernetes.io) gets
denied.
2023-12-12 16:12:53 +02:00
Kubernetes Prow Robot
efe5c03071
Merge pull request #1455 from ArangoGutierrez/validation
...
Create a Validate pkg
2023-12-12 11:04:06 +01:00
Kubernetes Prow Robot
c0d79051c0
Merge pull request #1500 from marquiz/devel/makefile-fix-e2e
...
Makefile: fix e2e-testing of the full image
2023-12-12 10:44:09 +01:00
Markus Lehtonen
4ebe58ffd9
Makefile: fix e2e-testing of the full image
...
Fix syntax error in the shell code. Also enable verbosity to print out
the shell script being run.
2023-12-12 11:25:03 +02:00
Kubernetes Prow Robot
795c35683d
Merge pull request #1499 from marquiz/devel/deps
...
go.mod: update dependencies
2023-12-11 17:21:43 +01:00
Carlos Eduardo Arango Gutierrez
affb93ea50
Create a Validate pkg
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-12-11 16:54:22 +01:00
Markus Lehtonen
c1c078e124
go.mod: update dependencies
2023-12-11 14:42:35 +02:00
Kubernetes Prow Robot
9a5b2447b6
Merge pull request #1498 from marquiz/devel/e2e-makefile
...
Makefile: more verbose output for e2e-tests
2023-12-08 19:48:29 +01:00
Markus Lehtonen
c04e022269
Makefile: more verbose output for e2e-tests
...
Also fixes some indentation,
2023-12-08 19:28:56 +02:00
Kubernetes Prow Robot
794630f7df
Merge pull request #1489 from ArangoGutierrez/ginkofocus
...
Makefile: add env var controls to make test targets configurable
2023-12-08 18:24:20 +01:00
Kubernetes Prow Robot
fae0825cae
Merge pull request #1496 from marquiz/devel/fix-e2e
...
test/e2e: fix broken test
2023-12-08 17:53:49 +01:00
Carlos Eduardo Arango Gutierrez
f9195ef6a4
Makefile: add env var controls to make test targets configurable
...
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
2023-12-08 17:48:00 +01:00
Markus Lehtonen
c5174a835d
test/e2e: fix broken test
...
Missed one check of NodeFeature API is enablement.
2023-12-08 18:35:37 +02:00
Kubernetes Prow Robot
a86369c371
Merge pull request #1495 from marquiz/devel/nf-owner-ref-test
...
test/e2e: test NodeFeature owner reference
2023-12-08 15:30:34 +01:00
Markus Lehtonen
c02e05245b
test/e2e: test NodeFeature owner reference
...
Add tests for verifying that the automatic garbage-colletion of
NodeFeature objects created by nfd-worker works as expected.
2023-12-08 16:04:03 +02:00
Kubernetes Prow Robot
04c4725dd1
Merge pull request #1491 from marquiz/devel/nf-owner-ref
...
nfd-worker: set owner reference in NodeFeature objects
2023-12-08 14:51:47 +01:00
Kubernetes Prow Robot
aa26bbf964
Merge pull request #1494 from marquiz/devel/master-service
...
deployment/kustomize: drop nfd-master service
2023-12-08 14:31:07 +01:00
Kubernetes Prow Robot
5a0623b024
Merge pull request #1493 from marquiz/devel/dockerignore
...
dockerignore: cleanup
2023-12-08 14:31:01 +01:00
Kubernetes Prow Robot
a56ff6be18
Merge pull request #1492 from marquiz/devel/deployment-combined
...
deployment/kustomize: drop default-combined overlay
2023-12-08 14:09:38 +01:00
Markus Lehtonen
34574f4211
nfd-worker: set owner reference in NodeFeature objects
...
This patch creates a owner-dependent relationship between the
nfd-worker pod and the NodeFeature object that it creates. With this
change the orphaned NodeFeature object(s) gets automatically
garbage-collected when the nfd-worker pod goes away, without the need
for manual clean-up actions.
2023-12-08 14:57:31 +02:00
Markus Lehtonen
9624d182ab
deployment/kustomize: drop nfd-master service
...
Not needed anymore as we're not relying on gRPC anymore.
2023-12-08 14:53:23 +02:00
Markus Lehtonen
b6ce6f3a9b
dockerignore: cleanup
2023-12-08 14:48:02 +02:00
Markus Lehtonen
53f5967555
deployment/kustomize: drop default-combined overlay
...
The "combined" overlay, deploying nfd-master and nfd-worker in the same
pod (with a daemonset) doesn't make sense anymore as we have enabled
NodeFeature API. There is no direct communication between nfd-master and
nfd-worker anymore, Moreover, the combined deployment can be seen as
broken as there is one NodeFeature controller (i.e. nfd-master) on each
node, causing them to race against each other, all processing all
NodeFeature objects.
2023-12-08 14:42:31 +02:00
Kubernetes Prow Robot
7f859ce568
Merge pull request #1448 from AhmedGrati/feat-discover-virtual-network-interface
...
feat: discover virtual network interface
2023-12-05 17:32:06 +01:00
Kubernetes Prow Robot
bdfef6df18
Merge pull request #1485 from marquiz/devel/docs-deployment
...
docs: remove outdated instructions for minimal image
2023-12-01 17:10:24 +01:00
Kubernetes Prow Robot
9386bf585a
Merge pull request #1486 from marquiz/devel/image-variants
...
Change the base image of full image variant to Debian Bookworm
2023-12-01 17:01:06 +01:00
Markus Lehtonen
e608fdac19
Change the base image of full image variant to Debian Bookworm
2023-12-01 16:38:41 +02:00
Markus Lehtonen
7ebf5c02c7
docs: remove outdated instructions for minimal image
...
The "minimal" image variant has been the default since v0.13.
2023-12-01 16:30:55 +02:00
Kubernetes Prow Robot
946bff2277
Merge pull request #1484 from marquiz/devel/docs-styling
...
docs: styling
2023-12-01 15:16:33 +01:00
Markus Lehtonen
15dc917ddb
docs: streamline language
2023-12-01 15:57:53 +02:00
Markus Lehtonen
4d56ffae8f
docs: fix typos
2023-12-01 15:53:19 +02:00
Markus Lehtonen
da64884d02
docs: drop "currently"
...
All the documentation describes the current version of NFD (it not
stated otherwise).
2023-12-01 15:47:18 +02:00
Markus Lehtonen
2f3cfbf209
docs: don't use "we"
2023-12-01 15:47:18 +02:00
Markus Lehtonen
fea395d005
docs: strip out some "easily", "just" etc
2023-12-01 15:38:26 +02:00
Markus Lehtonen
8d40524b88
apis/nfd: drop the private regexp caching field
...
Drop the private field for caching parsed regexp from the
MatchExpression type. This tidies up the API type definition and not so
tied with particular implementation details. The change also elimiates
potential concurrency problems as no locking is in place in the API
types.
If caching will be desired in the future, it's better to do it properly
in a separate package, not directly in the API types.
2023-12-01 15:28:55 +02:00
Kubernetes Prow Robot
cc6df8e74f
Merge pull request #1480 from marquiz/devel/api-expression-validation
...
apis/nfd: validate input when matching expression
2023-12-01 11:13:51 +01:00
Markus Lehtonen
b988139094
apis/nfd: validate input when matching expression
...
Don't assume that the fields are correct.
2023-12-01 09:22:32 +02:00
Kubernetes Prow Robot
ea1264ae68
Merge pull request #1478 from marquiz/devel/code-gen
...
generate: update kube code-gen to v1.28.4
2023-11-30 14:54:33 +01:00
Markus Lehtonen
94bffbf645
generate: update kube code-gen to v1.28.4
2023-11-29 18:37:19 +02:00
Kubernetes Prow Robot
b087c602c0
Merge pull request #1476 from marquiz/devel/docs-tls
...
docs/tls: update cert-manager deployment instructions
2023-11-28 20:31:43 +01:00
Kubernetes Prow Robot
7fed71d8d9
Merge pull request #1475 from marquiz/devel/docs-wording-fix
...
docs: correct description of no-publish for topology-updater
2023-11-28 20:23:19 +01:00