mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-14 11:57:51 +00:00
Code Activity

Merge pull request #1309 from marquiz/devel/refactor-gc-3

Browse source 
topology-gc: rename run()
This commit is contained in:
Kubernetes Prow Robot 2023-08-18 11:26:28 -07:00 committed by GitHub
commit f4cf4877f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/nfd-topology-gc/nfd-nrt-gc.go
View file

@ -158,7 +158,7 @@ func (n *topologyGC) periodicGC(gcPeriod time.Duration) {
}
}
func (n *topologyGC) run() error {
func (n *topologyGC) startNodeInformer() error {
nodeInformer := n.factory.Core().V1().Nodes().Informer()
if _, err := nodeInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
@ -178,7 +178,7 @@ func (n *topologyGC) run() error {
// Run is a blocking function that removes stale NRT objects when Node is deleted and runs periodic GC to make sure any obsolete objects are removed
func (n *topologyGC) Run() error {
if err := n.run(); err != nil {
if err := n.startNodeInformer(); err != nil {
return err
}
// run periodic GC

8
pkg/nfd-topology-gc/nfd-nrt-gc_test.go
View file

@ -51,7 +51,7 @@ func TestNRTGC(t *testing.T) {
gcPeriod: 10 * time.Minute,
}
err := gc.run()
err := gc.startNodeInformer()
So(err, ShouldBeNil)
nrts, err := fakeClient.TopologyV1alpha2().NodeResourceTopologies().List(context.TODO(), metav1.ListOptions{})
@ -90,7 +90,7 @@ func TestNRTGC(t *testing.T) {
gcPeriod: 10 * time.Minute,
}
err := gc.run()
err := gc.startNodeInformer()
So(err, ShouldBeNil)
nrts, err := fakeClient.TopologyV1alpha2().NodeResourceTopologies().List(context.TODO(), metav1.ListOptions{})
@ -136,7 +136,7 @@ func TestNRTGC(t *testing.T) {
gcPeriod: 10 * time.Minute,
}
err := gc.run()
err := gc.startNodeInformer()
So(err, ShouldBeNil)
nrts, err := fakeClient.TopologyV1alpha2().NodeResourceTopologies().List(context.TODO(), metav1.ListOptions{})
@ -197,7 +197,7 @@ func TestNRTGC(t *testing.T) {
gcPeriod: time.Second,
}
err := gc.run()
err := gc.startNodeInformer()
So(err, ShouldBeNil)
nrts, err := fakeClient.TopologyV1alpha2().NodeResourceTopologies().List(context.TODO(), metav1.ListOptions{})