mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-14 11:57:51 +00:00
Code Activity

helm: add configurable liveness&readiness probes for master topology-updater and worker

Browse source 
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
This commit is contained in:
Omer Aplatony 2024-07-18 20:26:07 +03:00
parent 51f2794d4f
commit b2222e2c8c
5 changed files with 48 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
deployment/helm/node-feature-discovery/templates/master.yaml
View file

@ -46,16 +46,9 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }} imagePullPolicy: {{ .Values.image.pullPolicy }}
livenessProbe: livenessProbe:
grpc: {{- toYaml .Values.master.livenessProbe | nindent 12 }}
port: 8082
initialDelaySeconds: 10
periodSeconds: 10
readinessProbe: readinessProbe:
grpc: {{- toYaml .Values.master.readinessProbe | nindent 12 }}
port: 8082
initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 10
ports: ports:
- containerPort: {{ .Values.master.port | default "8080" }} - containerPort: {{ .Values.master.port | default "8080" }}
name: grpc name: grpc

11
deployment/helm/node-feature-discovery/templates/topologyupdater.yaml
View file

@ -43,16 +43,9 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: "{{ .Values.image.pullPolicy }}" imagePullPolicy: "{{ .Values.image.pullPolicy }}"
livenessProbe: livenessProbe:
grpc: {{- toYaml .Values.topologyUpdater.livenessProbe | nindent 10 }}
port: 8082
initialDelaySeconds: 10
periodSeconds: 10
readinessProbe: readinessProbe:
grpc: {{- toYaml .Values.topologyUpdater.readinessProbe | nindent 10 }}
port: 8082
initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 10
env: env:
- name: NODE_NAME - name: NODE_NAME
valueFrom: valueFrom:

11
deployment/helm/node-feature-discovery/templates/worker.yaml
View file

@ -45,16 +45,9 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }} imagePullPolicy: {{ .Values.image.pullPolicy }}
livenessProbe: livenessProbe:
grpc: {{- toYaml .Values.worker.livenessProbe | nindent 12 }}
port: 8082
initialDelaySeconds: 10
periodSeconds: 10
readinessProbe: readinessProbe:
grpc: {{- toYaml .Values.worker.readinessProbe | nindent 12 }}
port: 8082
initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 10
env: env:
- name: NODE_NAME - name: NODE_NAME
valueFrom: valueFrom:

57
deployment/helm/node-feature-discovery/values.yaml
View file

@ -140,6 +140,19 @@ master:
- key: "node-role.kubernetes.io/control-plane" - key: "node-role.kubernetes.io/control-plane"
operator: In operator: In
values: [""] values: [""]
livenessProbe:
grpc:
port: 8082
initialDelaySeconds: 10
# failureThreshold: 3
# periodSeconds: 10
readinessProbe:
grpc:
port: 8082
initialDelaySeconds: 5
failureThreshold: 10
# periodSeconds: 10
worker: worker:
enable: true enable: true
@ -401,19 +414,18 @@ worker:
runAsNonRoot: true runAsNonRoot: true
# runAsUser: 1000 # runAsUser: 1000
# livenessProbe: {} livenessProbe:
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation. grpc:
# grpc: port: 8082
# port: 8082 initialDelaySeconds: 10
# initialDelaySeconds: 10 # failureThreshold: 3
# periodSeconds: 10 # periodSeconds: 10
# readinessProbe: {} readinessProbe:
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation. grpc:
# grpc: port: 8082
# port: 8082 initialDelaySeconds: 5
# initialDelaySeconds: 5 failureThreshold: 10
# periodSeconds: 10 # periodSeconds: 10
# failureThreshold: 10
serviceAccount: serviceAccount:
# Specifies whether a service account should be created. # Specifies whether a service account should be created.
@ -492,20 +504,19 @@ topologyUpdater:
drop: [ "ALL" ] drop: [ "ALL" ]
readOnlyRootFilesystem: true readOnlyRootFilesystem: true
runAsUser: 0 runAsUser: 0
# livenessProbe: {} livenessProbe:
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation. grpc:
# grpc: port: 8082
# port: 8082 initialDelaySeconds: 10
# initialDelaySeconds: 10 # failureThreshold: 3
# periodSeconds: 10 # periodSeconds: 10
# readinessProbe: {} readinessProbe:
## NOTE: Currently not configurable, defaults are provided for the sake of extra documentation. grpc:
# grpc: port: 8082
# port: 8082 initialDelaySeconds: 5
# initialDelaySeconds: 5 failureThreshold: 10
# periodSeconds: 10 # periodSeconds: 10
# failureThreshold: 10
resources: resources:
limits: limits:

10
docs/deployment/helm.md
View file

@ -144,6 +144,8 @@ API's you need to install the prometheus operator in your cluster.
| `master.config` | dict | | NFD master [configuration](../reference/master-configuration-reference) | | `master.config` | dict | | NFD master [configuration](../reference/master-configuration-reference) |
| `master.args` | array | [] | Additional [command line arguments](../reference/master-commandline-reference.md) to pass to nfd-master | | `master.args` | array | [] | Additional [command line arguments](../reference/master-commandline-reference.md) to pass to nfd-master |
| `master.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) | | `master.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) |
| `master.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | NFD master pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
| `master.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | NFD master pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
### Worker pod parameters ### Worker pod parameters
@ -168,7 +170,9 @@ API's you need to install the prometheus operator in your cluster.
| `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) | | `worker.annotations` | dict | {} | NFD worker pod [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
| `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) | | `worker.daemonsetAnnotations` | dict | {} | NFD worker daemonset [annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/) |
| `worker.args` | array | [] | Additional [command line arguments](../reference/worker-commandline-reference.md) to pass to nfd-worker | | `worker.args` | array | [] | Additional [command line arguments](../reference/worker-commandline-reference.md) to pass to nfd-worker |
| `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) | | `worker.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/ #DaemonSetSpec) |
| `worker.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | NFD worker pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
| `worker.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | NFD worker pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
### Topology updater parameters ### Topology updater parameters
@ -199,7 +203,9 @@ API's you need to install the prometheus operator in your cluster.
| `topologyUpdater.podSetFingerprint` | bool | true | Enables compute and report of pod fingerprint in NRT objects. | | `topologyUpdater.podSetFingerprint` | bool | true | Enables compute and report of pod fingerprint in NRT objects. |
| `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. | | `topologyUpdater.kubeletStateDir` | string | /var/lib/kubelet | Specifies kubelet state directory path for watching state and checkpoint files. Empty value disables kubelet state tracking. |
| `topologyUpdater.args` | array | [] | Additional [command line arguments](../reference/topology-updater-commandline-reference.md) to pass to nfd-topology-updater | | `topologyUpdater.args` | array | [] | Additional [command line arguments](../reference/topology-updater-commandline-reference.md) to pass to nfd-topology-updater |
| `topologyUpdater.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) | | `topologyUpdater.revisionHistoryLimit` | integer | | Specify how many old ControllerRevisions for this DaemonSet you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec) |
| `topologyUpdater.livenessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":10} | Topology updater pod [liveness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#liveness-probe) |
| `topologyUpdater.readinessProbe` | dict | {"grpc":{"port":8082},"initialDelaySeconds":5,"failureThreshold": 10} | Topology updater pod [readiness probe](https://kubernetes.io/docs/concepts/configuration/liveness-readiness-startup-probes/#readiness-probe)|
### Garbage collector parameters ### Garbage collector parameters