mirrors/node-feature-discovery
mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2025-03-31 04:04:51 +00:00
Code Activity

Allow post-delete job to be disabled

Browse source 
There are situations where the modifications performed by the NFD need to be
preserved even after its removal.

One such use case arises when NFD is installed as part of another project. By
design, uninstalling the parent project does not remove all its components.
However, the remaining components still rely on the labels created by NFD. If
NFD is removed, these labels will be deleted, causing dependent components to
fail.

To maintain system integrity and ensure continued functionality, adding the
'postDeleteCleanup' option that allows any modifications made by NFD to be
preserved upon its removal.

Signed-off-by: Aleksey Senin <alekseys@nvidia.com>
This commit is contained in:
Aleksey Senin 2025-03-25 09:34:39 -04:00
parent af706a819e
commit 8506bd7be0
3 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
deployment/helm/node-feature-discovery/templates/post-delete-job.yaml
View file

@ -1,3 +1,4 @@
{{- if .Values.postDeleteCleanup }}
apiVersion: v1
kind: ServiceAccount
metadata:
@ -96,3 +97,5 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- end }}

2
deployment/helm/node-feature-discovery/values.yaml
View file

@ -15,6 +15,8 @@ featureGates:
priorityClassName: ""
postDeleteCleanup: true
master:
enable: true
extraArgs: []

1
docs/deployment/helm.md
View file

@ -164,6 +164,7 @@ Chart parameters are available.
| `prometheus.labels` | dict | {} | Specifies labels for use with the prometheus operator to control how it is selected |
| `prometheus.scrapeInterval` | string | 10s | Specifies the interval by which metrics are scraped |
| `priorityClassName` | string | | The name of the PriorityClass to be used for the NFD pods. |
| `postDeleteCleanup` | bool | true | Controls behavior of post-delete hook. |
Metrics are configured to be exposed using prometheus operator API's by
default. If you want to expose metrics using the prometheus operator