1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-14 11:57:51 +00:00

Use worker DS OwnerReference for NF's

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This commit is contained in:
Carlos Eduardo Arango Gutierrez 2024-07-03 16:17:32 +02:00
parent 7a66da4dc4
commit 5d3ee1c51f
No known key found for this signature in database
GPG key ID: F19CDD72A695437A
3 changed files with 62 additions and 22 deletions

View file

@ -11,3 +11,9 @@ rules:
- create
- get
- update
- apiGroups:
- ""
resources:
- pods
verbs:
- get

View file

@ -15,5 +15,10 @@ rules:
- create
- get
- update
- apiGroups:
- ""
resources:
- pods
verbs:
- get
{{- end }}

View file

@ -39,6 +39,7 @@ import (
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/validation"
"k8s.io/client-go/kubernetes"
"k8s.io/klog/v2"
klogutils "sigs.k8s.io/node-feature-discovery/pkg/utils/klog"
"sigs.k8s.io/yaml"
@ -134,6 +135,7 @@ type nfdWorker struct {
stop chan struct{} // channel for signaling stop
featureSources []source.FeatureSource
labelSources []source.LabelSource
ownerReference []metav1.OwnerReference
}
// This ticker can represent infinite and normal intervals.
@ -271,6 +273,36 @@ func (w *nfdWorker) Run() error {
labelTrigger.Reset(w.config.Core.SleepInterval.Duration)
defer labelTrigger.Stop()
// Get pod owner reference
podName := os.Getenv("POD_NAME")
client, err := w.getKubeClient()
if err != nil {
return fmt.Errorf("failed to get kube client: %w", err)
}
selfPod, err := client.CoreV1().Pods(w.kubernetesNamespace).Get(context.TODO(), podName, metav1.GetOptions{})
if err != nil {
return fmt.Errorf("failed to get pod %q: %w", podName, err)
}
// Create owner ref
ownerReference := selfPod.OwnerReferences
// Add pod owner reference if it exists
podUID := os.Getenv("POD_UID")
if podName != "" && podUID != "" {
isTrue := true
ownerReference = append(ownerReference, metav1.OwnerReference{
APIVersion: "v1",
Kind: "Pod",
Name: podName,
UID: types.UID(podUID),
Controller: &isTrue,
})
}
w.ownerReference = ownerReference
// Register to metrics server
if w.args.MetricsPort > 0 {
m := utils.CreateMetricsServer(w.args.MetricsPort,
@ -713,25 +745,6 @@ func (m *nfdWorker) updateNodeFeatureObject(labels Labels) error {
features := source.GetAllFeatures()
// Create owner ref
ownerRefs := []metav1.OwnerReference{}
podName := os.Getenv("POD_NAME")
podUID := os.Getenv("POD_UID")
if podName != "" && podUID != "" {
isTrue := true
ownerRefs = []metav1.OwnerReference{
{
APIVersion: "v1",
Kind: "Pod",
Name: podName,
UID: types.UID(podUID),
Controller: &isTrue,
},
}
} else {
klog.InfoS("Cannot set NodeFeature owner reference, POD_NAME and/or POD_UID not specified")
}
// TODO: we could implement some simple caching of the object, only get it
// every 10 minutes or so because nobody else should really be modifying it
if nfr, err := cli.NfdV1alpha1().NodeFeatures(namespace).Get(context.TODO(), nodename, metav1.GetOptions{}); errors.IsNotFound(err) {
@ -740,7 +753,7 @@ func (m *nfdWorker) updateNodeFeatureObject(labels Labels) error {
Name: nodename,
Annotations: map[string]string{nfdv1alpha1.WorkerVersionAnnotation: version.Get()},
Labels: map[string]string{nfdv1alpha1.NodeFeatureObjNodeNameLabel: nodename},
OwnerReferences: ownerRefs,
OwnerReferences: m.ownerReference,
},
Spec: nfdv1alpha1.NodeFeatureSpec{
Features: *features,
@ -761,7 +774,7 @@ func (m *nfdWorker) updateNodeFeatureObject(labels Labels) error {
nfrUpdated := nfr.DeepCopy()
nfrUpdated.Annotations = map[string]string{nfdv1alpha1.WorkerVersionAnnotation: version.Get()}
nfrUpdated.Labels = map[string]string{nfdv1alpha1.NodeFeatureObjNodeNameLabel: nodename}
nfrUpdated.OwnerReferences = ownerRefs
nfrUpdated.OwnerReferences = m.ownerReference
nfrUpdated.Spec = nfdv1alpha1.NodeFeatureSpec{
Features: *features,
Labels: labels,
@ -801,6 +814,22 @@ func (m *nfdWorker) getNfdClient() (*nfdclient.Clientset, error) {
return c, nil
}
func (m *nfdWorker) getKubeClient() (*kubernetes.Clientset, error) {
// creates the in-cluster config
kubeconfig, err := utils.GetKubeconfig(m.args.Kubeconfig)
if err != nil {
return nil, err
}
// creates the clientset
clientset, err := kubernetes.NewForConfig(kubeconfig)
if err != nil {
return nil, err
}
return clientset, nil
}
// UnmarshalJSON implements the Unmarshaler interface from "encoding/json"
func (c *sourcesConfig) UnmarshalJSON(data []byte) error {
// First do a raw parse to get the per-source data