mirrors/node-feature-discovery
mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2025-03-30 19:54:46 +00:00
Code Activity

reactive updates: add an option to disable the feature

Browse source 
Access to the kubelet state directory may raise concerns in some setups, added an option to disable it.
The feature is enabled by default.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
This commit is contained in:
Talor Itzhak 2023-02-21 21:43:43 +02:00
parent 727de56191
commit 5c6be580f4
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/reference/topology-updater-commandline-reference.md
View file

@ -165,6 +165,8 @@ nfd-topology-updater -pods-fingerprint
The `-kubelet-state-dir` specifies the path to the Kubelet state directory, The `-kubelet-state-dir` specifies the path to the Kubelet state directory,
where state and checkpoint files are stored. where state and checkpoint files are stored.
The files are mount as read-only and cannot be change by the updater. The files are mount as read-only and cannot be change by the updater.
Enabled by default.
Passing an empty string will disable the watching.
Default: /host-var/lib/kubelet Default: /host-var/lib/kubelet

10
pkg/nfd-topology-updater/nfd-topology-updater.go
View file

@ -96,11 +96,13 @@ type nfdTopologyUpdater struct {
// NewTopologyUpdater creates a new NfdTopologyUpdater instance. // NewTopologyUpdater creates a new NfdTopologyUpdater instance.
func NewTopologyUpdater(args Args, resourcemonitorArgs resourcemonitor.Args, policy, scope string) (NfdTopologyUpdater, error) { func NewTopologyUpdater(args Args, resourcemonitorArgs resourcemonitor.Args, policy, scope string) (NfdTopologyUpdater, error) {
eventSource := make(chan kubeletnotifier.Info) eventSource := make(chan kubeletnotifier.Info)
ntf, err := kubeletnotifier.New(resourcemonitorArgs.SleepInterval, eventSource, args.KubeletStateDir) if args.KubeletStateDir != "" {
if err != nil { ntf, err := kubeletnotifier.New(resourcemonitorArgs.SleepInterval, eventSource, args.KubeletStateDir)
return nil, err if err != nil {
return nil, err
}
go ntf.Run()
} }
go ntf.Run()
nfd := &nfdTopologyUpdater{ nfd := &nfdTopologyUpdater{
args: args, args: args,
resourcemonitorArgs: resourcemonitorArgs, resourcemonitorArgs: resourcemonitorArgs,