mirrors/node-feature-discovery
mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2025-03-28 02:37:11 +00:00
Code Activity

Merge pull request #1589 from marquiz/devel/pci-unit-test

Browse source 
source/pci: add unit test for the pci source
This commit is contained in:
Kubernetes Prow Robot 2024-02-16 01:36:51 -08:00 • committed by GitHub
commit 41e903de1a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
263 changed files with 481 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

230
source/pci/pci_test.go
View file

@ -17,12 +17,24 @@ limitations under the License.
package pci
import (
"path/filepath"
"runtime"
"testing"
"github.com/stretchr/testify/assert"
nfdv1alpha1 "sigs.k8s.io/node-feature-discovery/pkg/apis/nfd/v1alpha1"
"sigs.k8s.io/node-feature-discovery/pkg/utils/hostpath"
"sigs.k8s.io/node-feature-discovery/source"
)
func TestPciSource(t *testing.T) {
var packagePath string
func init() {
_, thisFile, _, _ := runtime.Caller(0)
packagePath = filepath.Dir(thisFile)
}
func TestSingletonPciSource(t *testing.T) {
assert.Equal(t, src.Name(), Name)
// Check that GetLabels works with empty features
@ -31,5 +43,219 @@ func TestPciSource(t *testing.T) {
assert.Nil(t, err, err)
assert.Empty(t, l)
}
func TestPciSource(t *testing.T) {
// Specify expected "raw" features. These are always the same for the same
// mocked sysfs.
expectedFeatures := map[string]*nfdv1alpha1.Features{
"rootfs-empty": &nfdv1alpha1.Features{
Flags: map[string]nfdv1alpha1.FlagFeatureSet{},
Attributes: map[string]nfdv1alpha1.AttributeFeatureSet{},
Instances: map[string]nfdv1alpha1.InstanceFeatureSet{},
},
"rootfs-1": &nfdv1alpha1.Features{
Flags: map[string]nfdv1alpha1.FlagFeatureSet{},
Attributes: map[string]nfdv1alpha1.AttributeFeatureSet{},
Instances: map[string]nfdv1alpha1.InstanceFeatureSet{
"device": nfdv1alpha1.InstanceFeatureSet{
Elements: []nfdv1alpha1.InstanceFeature{
{
Attributes: map[string]string{
"class": "0880",
"device": "2021",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "ff00",
"device": "a1ed",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "0106",
"device": "a1d2",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "1180",
"device": "a1b1",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "0780",
"device": "a1ba",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "0604",
"device": "a193",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "0c80",
"device": "a1a4",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "0300",
"device": "2000",
"subsystem_device": "2000",
"subsystem_vendor": "1a03",
"vendor": "1a03",
},
},
{
Attributes: map[string]string{
"class": "0b40",
"device": "37c8",
"iommu/intel-iommu/version": "1:0",
"iommu_group/type": "identity",
"sriov_totalvfs": "16",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
{
Attributes: map[string]string{
"class": "0200",
"device": "37d2",
"sriov_totalvfs": "32",
"subsystem_device": "35cf",
"subsystem_vendor": "8086",
"vendor": "8086",
},
},
},
},
},
},
}
// Specify test cases
tests := []struct {
name string
config *Config
rootfs string
expectErr bool
expectedLabels source.FeatureLabels
}{
{
name: "detect with default config",
rootfs: "rootfs-1",
expectedLabels: source.FeatureLabels{
"0300_1a03.present": true,
"0b40_8086.present": true,
"0b40_8086.sriov.capable": true,
},
},
{
name: "test config with empty DeviceLabelFields",
rootfs: "rootfs-1",
config: &Config{
DeviceClassWhitelist: []string{"0c"},
DeviceLabelFields: []string{},
},
expectedLabels: source.FeatureLabels{
"0c80_8086.present": true,
},
},
{
name: "test config with empty DeviceLabelFields",
rootfs: "rootfs-1",
config: &Config{
DeviceClassWhitelist: []string{"0c"},
DeviceLabelFields: []string{},
},
expectedLabels: source.FeatureLabels{
"0c80_8086.present": true,
},
},
{
name: "test config with only invalid DeviceLabelFields",
rootfs: "rootfs-1",
config: &Config{
DeviceClassWhitelist: []string{"0c"},
DeviceLabelFields: []string{"foo", "bar"},
},
expectedLabels: source.FeatureLabels{
"0c80_8086.present": true,
},
},
{
name: "test config with some invalid DeviceLabelFields",
rootfs: "rootfs-1",
config: &Config{
DeviceClassWhitelist: []string{"0c"},
DeviceLabelFields: []string{"foo", "class"},
},
expectedLabels: source.FeatureLabels{
"0c80.present": true,
},
},
{
name: "test empty sysfs",
rootfs: "rootfs-empty",
expectErr: true,
expectedLabels: source.FeatureLabels{},
},
}
// Run test cases
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
hostpath.SysfsDir = hostpath.HostDir(filepath.Join(packagePath, "testdata", tc.rootfs, "sys"))
config := tc.config
if config == nil {
config = newDefaultConfig()
}
testSrc := pciSource{config: config}
// Discover mock PCI devices
err := testSrc.Discover()
if tc.expectErr {
assert.NotNil(t, err, err)
} else {
assert.Nil(t, err, err)
}
// Check features
f := testSrc.GetFeatures()
assert.Equal(t, expectedFeatures[tc.rootfs], f)
// Check labels
l, err := testSrc.GetLabels()
assert.Nil(t, err, err)
assert.Equal(t, tc.expectedLabels, l)
})
}
}

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/ari_enabled vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/broken_parity_status vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/class vendored Normal file
View file

@ -0,0 +1 @@
0x088000

BIN
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/config vendored Normal file
View file

Binary file not shown.

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/consistent_dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
64

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/current_link_speed vendored Normal file
View file

@ -0,0 +1 @@
Unknown

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/current_link_width vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/d3cold_allowed vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/device vendored Normal file
View file

@ -0,0 +1 @@
0x2021

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
64

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/driver_override vendored Normal file
View file

@ -0,0 +1 @@
(null)

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/enable vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/irq vendored Normal file
View file

@ -0,0 +1 @@
418

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/local_cpulist vendored Normal file
View file

@ -0,0 +1 @@
0-2,5-6,10-12,15-16,40-42,45-46,50-52,55-56

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/local_cpus vendored Normal file
View file

@ -0,0 +1 @@
0000,019c6700,00019c67

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/max_link_speed vendored Normal file
View file

@ -0,0 +1 @@
Unknown

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/max_link_width vendored Normal file
View file

@ -0,0 +1 @@
255

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/modalias vendored Normal file
View file

@ -0,0 +1 @@
pci:v00008086d00002021sv00008086sd000035CFbc08sc80i00

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/msi_bus vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/numa_node vendored Normal file
View file

@ -0,0 +1 @@
0

2
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/pools vendored Normal file
View file

@ -0,0 +1,2 @@
poolinfo - 0.1
completion_pool 0 64 64 1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/power_state vendored Normal file
View file

@ -0,0 +1 @@
D0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/revision vendored Normal file
View file

@ -0,0 +1 @@
0x04

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/subsystem_device vendored Normal file
View file

@ -0,0 +1 @@
0x35cf

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/subsystem_vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:04.0/vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/ari_enabled vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/broken_parity_status vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/class vendored Normal file
View file

@ -0,0 +1 @@
0xff0000

BIN
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/config vendored Normal file
View file

Binary file not shown.

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/consistent_dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
32

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/d3cold_allowed vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/device vendored Normal file
View file

@ -0,0 +1 @@
0xa1ed

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
32

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/driver_override vendored Normal file
View file

@ -0,0 +1 @@
(null)

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/enable vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/irq vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/local_cpulist vendored Normal file
View file

@ -0,0 +1 @@
0-2,5-6,10-12,15-16,40-42,45-46,50-52,55-56

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/local_cpus vendored Normal file
View file

@ -0,0 +1 @@
0000,019c6700,00019c67

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/modalias vendored Normal file
View file

@ -0,0 +1 @@
pci:v00008086d0000A1EDsv00008086sd000035CFbcFFsc00i00

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/msi_bus vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/numa_node vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/power_state vendored Normal file
View file

@ -0,0 +1 @@
unknown

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/revision vendored Normal file
View file

@ -0,0 +1 @@
0x04

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/subsystem_device vendored Normal file
View file

@ -0,0 +1 @@
0x35cf

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/subsystem_vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.1/waiting_for_supplier vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/ari_enabled vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/broken_parity_status vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/class vendored Normal file
View file

@ -0,0 +1 @@
0x010601

BIN
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/config vendored Normal file
View file

Binary file not shown.

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/consistent_dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
64

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/d3cold_allowed vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/device vendored Normal file
View file

@ -0,0 +1 @@
0xa1d2

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
64

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/driver_override vendored Normal file
View file

@ -0,0 +1 @@
(null)

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/enable vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/index vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/irq vendored Normal file
View file

@ -0,0 +1 @@
41

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/label vendored Normal file
View file

@ -0,0 +1 @@
PCH Integrated sSATA Controller

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/local_cpulist vendored Normal file
View file

@ -0,0 +1 @@
0-2,5-6,10-12,15-16,40-42,45-46,50-52,55-56

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/local_cpus vendored Normal file
View file

@ -0,0 +1 @@
0000,019c6700,00019c67

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/modalias vendored Normal file
View file

@ -0,0 +1 @@
pci:v00008086d0000A1D2sv00008086sd000035CFbc01sc06i01

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/msi_bus vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/numa_node vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/power_state vendored Normal file
View file

@ -0,0 +1 @@
D0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/remapped_nvme vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/revision vendored Normal file
View file

@ -0,0 +1 @@
0x04

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/subsystem_device vendored Normal file
View file

@ -0,0 +1 @@
0x35cf

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/subsystem_vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:11.5/vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/ari_enabled vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/broken_parity_status vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/class vendored Normal file
View file

@ -0,0 +1 @@
0x118000

BIN
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/config vendored Normal file
View file

Binary file not shown.

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/consistent_dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
32

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/d3cold_allowed vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/device vendored Normal file
View file

@ -0,0 +1 @@
0xa1b1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
32

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/driver_override vendored Normal file
View file

@ -0,0 +1 @@
(null)

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/enable vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/irq vendored Normal file
View file

@ -0,0 +1 @@
18

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/local_cpulist vendored Normal file
View file

@ -0,0 +1 @@
0-2,5-6,10-12,15-16,40-42,45-46,50-52,55-56

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/local_cpus vendored Normal file
View file

@ -0,0 +1 @@
0000,019c6700,00019c67

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/modalias vendored Normal file
View file

@ -0,0 +1 @@
pci:v00008086d0000A1B1sv00008086sd000035CFbc11sc80i00

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/msi_bus vendored Normal file
View file

@ -0,0 +1 @@
1

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/numa_node vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/power_state vendored Normal file
View file

@ -0,0 +1 @@
D0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/revision vendored Normal file
View file

@ -0,0 +1 @@
0x04

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/subsystem_device vendored Normal file
View file

@ -0,0 +1 @@
0x35cf

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/subsystem_vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:14.2/vendor vendored Normal file
View file

@ -0,0 +1 @@
0x8086

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:16.0/ari_enabled vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:16.0/broken_parity_status vendored Normal file
View file

@ -0,0 +1 @@
0

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:16.0/class vendored Normal file
View file

@ -0,0 +1 @@
0x078000

BIN
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:16.0/config vendored Normal file
View file

Binary file not shown.

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:16.0/consistent_dma_mask_bits vendored Normal file
View file

@ -0,0 +1 @@
32

1
source/pci/testdata/rootfs-1/sys/bus/pci/devices/0000:00:16.0/d3cold_allowed vendored Normal file
View file

@ -0,0 +1 @@
1

Some files were not shown because too many files have changed in this diff Show more