mirrors/node-feature-discovery
mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2025-03-15 04:57:56 +00:00
Code Activity

Merge pull request #1612 from marquiz/devel/deperecate-crd-controller-flag

Browse source 
nfd-master: mark the -crd-controller flag as deprecated
This commit is contained in:
Kubernetes Prow Robot 2024-03-13 07:57:51 -07:00 • committed by GitHub
commit 1ff7a9457b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cmd/nfd-master/main.go
View file

@ -55,6 +55,8 @@ func main() {
switch f.Name { switch f.Name {
case "featurerules-controller": case "featurerules-controller":
klog.InfoS("-featurerules-controller is deprecated, use '-crd-controller' flag instead") klog.InfoS("-featurerules-controller is deprecated, use '-crd-controller' flag instead")
case "crd-controller":
klog.InfoS("-crd-controller is deprecated, will be removed in a future release along with the deprecated gRPC API")
case "extra-label-ns": case "extra-label-ns":
args.Overrides.ExtraLabelNs = overrides.ExtraLabelNs args.Overrides.ExtraLabelNs = overrides.ExtraLabelNs
case "deny-label-ns": case "deny-label-ns":
@ -138,7 +140,8 @@ func initFlags(flagset *flag.FlagSet) (*master.Args, *master.ConfigOverrideArgs)
flagset.BoolVar(&args.CrdController, "featurerules-controller", true, flagset.BoolVar(&args.CrdController, "featurerules-controller", true,
"Enable NFD CRD API controller. DEPRECATED: use -crd-controller instead") "Enable NFD CRD API controller. DEPRECATED: use -crd-controller instead")
flagset.BoolVar(&args.CrdController, "crd-controller", true, flagset.BoolVar(&args.CrdController, "crd-controller", true,
"Enable NFD CRD API controller for processing NodeFeature and NodeFeatureRule objects.") "Enable NFD CRD API controller for processing NodeFeature and NodeFeatureRule objects."+
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")
flagset.IntVar(&args.Port, "port", 8080, flagset.IntVar(&args.Port, "port", 8080,
"Port on which to listen for gRPC connections."+ "Port on which to listen for gRPC connections."+
" DEPRECATED: will be removed in a future release along with the deprecated gRPC API.") " DEPRECATED: will be removed in a future release along with the deprecated gRPC API.")

3
docs/reference/master-commandline-reference.md
View file

@ -223,6 +223,9 @@ nfd-master -no-publish
### -crd-controller ### -crd-controller
> **NOTE** This flag will be removed in a future release at the same time with
> the deprecated gRPC API.
The `-crd-controller` flag specifies whether the NFD CRD API controller is The `-crd-controller` flag specifies whether the NFD CRD API controller is
enabled or not. The controller is responsible for processing enabled or not. The controller is responsible for processing
[NodeFeature](../usage/custom-resources.md#nodefeature) and [NodeFeature](../usage/custom-resources.md#nodefeature) and