mirrors/node-feature-discovery
mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2025-03-06 16:57:10 +00:00
Code Activity

Make DNS Policy configurable in helm chart (#2025)

Browse source 
* Make DNS Policy configurable in helm chart

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

* Add documentation for helm dnsPolicy values

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

* Reformat tables in helm docs

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>

---------

Signed-off-by: Killian Muldoon <kmuldoon@nvidia.com>
This commit is contained in:
killianmuldoon 2025-01-23 09:42:58 +00:00 • committed by GitHub
parent ab1bfd18c4
commit 0ff1987d2a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
deployment/helm/node-feature-discovery/templates/master.yaml
View file

@ -29,6 +29,7 @@ spec:
{{- toYaml . | nindent 8 }} {{- toYaml . | nindent 8 }}
{{- end }} {{- end }}
spec: spec:
dnsPolicy: {{ .Values.master.dnsPolicy }}
{{- with .Values.priorityClassName }} {{- with .Values.priorityClassName }}
priorityClassName: {{ . }} priorityClassName: {{ . }}
{{- end }} {{- end }}

2
deployment/helm/node-feature-discovery/templates/nfd-gc.yaml
View file

@ -29,7 +29,7 @@ spec:
{{- end }} {{- end }}
spec: spec:
serviceAccountName: {{ include "node-feature-discovery.gc.serviceAccountName" . }} serviceAccountName: {{ include "node-feature-discovery.gc.serviceAccountName" . }}
dnsPolicy: ClusterFirstWithHostNet dnsPolicy: {{ .Values.gc.dnsPolicy }}
{{- with .Values.priorityClassName }} {{- with .Values.priorityClassName }}
priorityClassName: {{ . }} priorityClassName: {{ . }}
{{- end }} {{- end }}

2
deployment/helm/node-feature-discovery/templates/topologyupdater.yaml
View file

@ -29,7 +29,7 @@ spec:
{{- end }} {{- end }}
spec: spec:
serviceAccountName: {{ include "node-feature-discovery.topologyUpdater.serviceAccountName" . }} serviceAccountName: {{ include "node-feature-discovery.topologyUpdater.serviceAccountName" . }}
dnsPolicy: ClusterFirstWithHostNet dnsPolicy: {{ .Values.topologyUpdater.dnsPolicy }}
{{- with .Values.priorityClassName }} {{- with .Values.priorityClassName }}
priorityClassName: {{ . }} priorityClassName: {{ . }}
{{- end }} {{- end }}

2
deployment/helm/node-feature-discovery/templates/worker.yaml
View file

@ -28,7 +28,7 @@ spec:
{{- toYaml . | nindent 8 }} {{- toYaml . | nindent 8 }}
{{- end }} {{- end }}
spec: spec:
dnsPolicy: ClusterFirstWithHostNet dnsPolicy: {{ .Values.worker.dnsPolicy }}
{{- with .Values.priorityClassName }} {{- with .Values.priorityClassName }}
priorityClassName: {{ . }} priorityClassName: {{ . }}
{{- end }} {{- end }}

4
deployment/helm/node-feature-discovery/values.yaml
View file

@ -20,6 +20,7 @@ master:
extraArgs: [] extraArgs: []
extraEnvs: [] extraEnvs: []
hostNetwork: false hostNetwork: false
dnsPolicy: ClusterFirstWithHostNet
config: ### <NFD-MASTER-CONF-START-DO-NOT-REMOVE> config: ### <NFD-MASTER-CONF-START-DO-NOT-REMOVE>
# noPublish: false # noPublish: false
# autoDefaultNs: true # autoDefaultNs: true
@ -173,6 +174,7 @@ worker:
extraArgs: [] extraArgs: []
extraEnvs: [] extraEnvs: []
hostNetwork: false hostNetwork: false
dnsPolicy: ClusterFirstWithHostNet
config: ### <NFD-WORKER-CONF-START-DO-NOT-REMOVE> config: ### <NFD-WORKER-CONF-START-DO-NOT-REMOVE>
#core: #core:
# labelWhiteList: # labelWhiteList:
@ -499,6 +501,7 @@ topologyUpdater:
extraArgs: [] extraArgs: []
extraEnvs: [] extraEnvs: []
hostNetwork: false hostNetwork: false
dnsPolicy: ClusterFirstWithHostNet
serviceAccount: serviceAccount:
create: true create: true
@ -563,6 +566,7 @@ gc:
extraEnvs: [] extraEnvs: []
hostNetwork: false hostNetwork: false
replicaCount: 1 replicaCount: 1
dnsPolicy: ClusterFirstWithHostNet
serviceAccount: serviceAccount:
create: true create: true

4
docs/deployment/helm.md
View file

@ -213,6 +213,7 @@ API's you need to install the prometheus operator in your cluster.
| `master.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. | | `master.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. |
| `master.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. | | `master.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. |
| `master.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. | | `master.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. |
| `master.dnsPolicy` | array | ClusterFirstWithHostNet | NFD master pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
> `[0]` Additional info for `master.resources.requests`: \ > `[0]` Additional info for `master.resources.requests`: \
> You may want to use the same value for `requests.memory` and `limits.memory`. > You may want to use the same value for `requests.memory` and `limits.memory`.
@ -261,6 +262,7 @@ API's you need to install the prometheus operator in your cluster.
| `worker.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. | | `worker.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. |
| `worker.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. | | `worker.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. |
| `worker.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. | | `worker.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. |
| `worker.dnsPolicy` | array | ClusterFirstWithHostNet | NFD worker pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
### Topology updater parameters ### Topology updater parameters
@ -304,6 +306,7 @@ API's you need to install the prometheus operator in your cluster.
| `topologyUpdater.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. | | `topologyUpdater.readinessProbe.periodSeconds` | integer | 10 (by Kubernetes) | Specifies how often (in seconds) to perform the readiness probe. |
| `topologyUpdater.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. | | `topologyUpdater.readinessProbe.timeoutSeconds` | integer | 1 (by Kubernetes) | Specifies the number of seconds after which the probe times out. |
| `topologyUpdater.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. | | `topologyUpdater.readinessProbe.successThreshold` | integer | 1 (by Kubernetes) | Specifies the number of consecutive successes of readiness probes before considering the pod as ready. |
| `topologyUpdater.dnsPolicy` | array | ClusterFirstWithHostNet | Topology updater pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
### Garbage collector parameters ### Garbage collector parameters
@ -329,6 +332,7 @@ API's you need to install the prometheus operator in your cluster.
| `gc.extraArgs` | array | [] | Additional [command line arguments](../reference/gc-commandline-reference.md) to pass to nfd-gc | | `gc.extraArgs` | array | [] | Additional [command line arguments](../reference/gc-commandline-reference.md) to pass to nfd-gc |
| `gc.extraEnvs` | array | [] | Additional environment variables to pass to nfd-gc | | `gc.extraEnvs` | array | [] | Additional environment variables to pass to nfd-gc |
| `gc.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) | | `gc.revisionHistoryLimit` | integer | | Specify how many old ReplicaSets for this Deployment you want to retain. [revisionHistoryLimit](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit) |
| `gc.dnsPolicy` | array | ClusterFirstWithHostNet | Garbage collector pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy) |
<!-- Links --> <!-- Links -->