1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-15 17:50:49 +00:00

source/network: ignore interface operational state

Ignore the operational state of network interface when creating the
network SR-IOV labels. Previously NFD only considered interfaces which
were "up".

Pre v0.9 we used to check the "administrative state" of interfaces
(managed by the sysadmin with e.g. with ip link set dev <dev> down/up).
In v0.10 we changed to checking the "operational state" of interfaces,
reflecting whether the it is actually able to transfer data. Both these
checks have caused confusion among users and it is more understandable
and more aligned with other HW discovery functions in NFD to just drop
the state check. Also, the documentation is aligned with this behavior.
This commit is contained in:
Markus Lehtonen 2022-05-13 12:21:53 +03:00 committed by k8s-infra-cherrypick-robot
parent 9f6a97905f
commit 0134090016

View file

@ -70,9 +70,6 @@ func (s *networkSource) GetLabels() (source.FeatureLabels, error) {
for _, dev := range features.Instances[DeviceFeature].Elements {
attrs := dev.Attributes
if attrs["operstate"] != "up" {
continue
}
for attr, feature := range map[string]string{
"sriov_totalvfs": "sriov.capable",
"sriov_numvfs": "sriov.configured"} {