mirrors/node-feature-discovery
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/node-feature-discovery.git synced 2024-12-14 11:57:51 +00:00
Code Activity
node-feature-discovery/Dockerfile

48 lines
1.1 KiB
Text
Raw Normal View History

Add support for configurable runtime full and minimal images. (#513) * Add support for configurable runtime full and minimal images. * Fixups and renamings. * Change variables *_IMG_* to *_IMAGE_* * Fix args in Dockerfile also.
2021-04-20 07:42:33 +00:00
ARG BASE_IMAGE_FULL
ARG BASE_IMAGE_MINIMAL
Utilize multi-stage build to reduce docker image size This reduces the size of the Docker image from ca. 1.2GB down to about 750MB. Also, move unit tests from .travis.yml to Dockerfile. Final production image is not able to run unit tests anymore, as sources are missing from there.
2018-05-28 10:47:56 +00:00
# Build node feature discovery
bump to go 1.16 Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
2021-03-24 15:00:36 +00:00
FROM golang:1.16.2-buster as builder
Fixed vulnerabilities in Docker image. - Updated to debian testing (stretch). - Updated to go v1.7. - Added .dockerignore file.
2016-09-20 17:42:00 +00:00
Dockerfile: store build deps in a separate layer Speeds up local builds considerably as the deps are cached (instead of downloading them all on every build) - as long as go.mod and go.sum are not changed.
2019-09-04 15:17:58 +00:00
# Get (cache) deps in a separate layer
COPY go.mod go.sum /go/node-feature-discovery/
1. Enabled RDT discovery. 2. Updated the ds to a job for node labelling. 3. Added script to run a job in each node. 4. Updated Readme.
2016-07-12 00:30:49 +00:00
Switch to using go modules Update go version in Docker build image to v1.12.
2019-11-20 13:41:48 +00:00
WORKDIR /go/node-feature-discovery
1. Enabled RDT discovery. 2. Updated the ds to a job for node labelling. 3. Added script to run a job in each node. 4. Updated Readme.
2016-07-12 00:30:49 +00:00
Dockerfile: store build deps in a separate layer Speeds up local builds considerably as the deps are cached (instead of downloading them all on every build) - as long as go.mod and go.sum are not changed.
2019-09-04 15:17:58 +00:00
RUN go mod download
# Do actual build
COPY . /go/node-feature-discovery
Dockerfile: rename version ARG Use the same naming across Makefile and Dockerfile.
2020-05-19 09:21:37 +00:00
ARG VERSION
Make host mount prefix configurable in Makefile and Dockerfile Introduce a new makefile variable and dockerfile build arg named HOSTMOUNT_PREFIX for changing the prefix used for mounting host directories inside the container. Adds a sed rule in Makefile to generate deployment yamls accordingly.
2020-05-20 16:55:54 +00:00
ARG HOSTMOUNT_PREFIX
enable nfd framework on Arm64 platform currently, nfd framework can't be work on Arm64 platform. Fix points: 1, removed rdt on Arm64 platform 2, optimized the code related to multi-arch Change-Id: If605041f6d2243ae2afb3248edbf102083c6dcb4 Signed-off-by: Bin Lu <bin.lu@arm.com> Jira: ENTOS-432
2017-12-20 06:51:56 +00:00
Dockerfile: rename version ARG Use the same naming across Makefile and Dockerfile.
2020-05-19 09:21:37 +00:00
RUN make install VERSION=$VERSION HOSTMOUNT_PREFIX=$HOSTMOUNT_PREFIX
1. Enabled RDT discovery. 2. Updated the ds to a job for node labelling. 3. Added script to run a job in each node. 4. Updated Readme.
2016-07-12 00:30:49 +00:00
Fix unit tests after master-worker split Refactor old tests and add tests for new functions. Add 'test' target in Makefile.
2019-01-23 08:15:47 +00:00
RUN make test
Utilize multi-stage build to reduce docker image size This reduces the size of the Docker image from ca. 1.2GB down to about 750MB. Also, move unit tests from .travis.yml to Dockerfile. Final production image is not able to run unit tests anymore, as sources are missing from there.
2018-05-28 10:47:56 +00:00
Dockerfile: add minimal image Build a "minimal" variant of the nfd image based on gcr.io/distroless/base. The motivations behind the minimal image are image hardening (security) and reducing the image footprint (from ca. 108MB down to about 40MB). The practical effect of deploying the minimal image is that no runtimes for running worker hooks are present, not even a shell. This means that only statically linked linked hook binaries are supported. Also, because of the image hardening live debugging of the minimal image by attaching to the container is not possible, and, the "full" image needs to be used for that purpose.
2021-03-09 09:53:52 +00:00
# Create full variant of the production image
Add support for configurable runtime full and minimal images. (#513) * Add support for configurable runtime full and minimal images. * Fixups and renamings. * Change variables *_IMG_* to *_IMAGE_* * Fix args in Dockerfile also.
2021-04-20 07:42:33 +00:00
FROM ${BASE_IMAGE_FULL} as full
Dockerfile: add minimal image Build a "minimal" variant of the nfd image based on gcr.io/distroless/base. The motivations behind the minimal image are image hardening (security) and reducing the image footprint (from ca. 108MB down to about 40MB). The practical effect of deploying the minimal image is that no runtimes for running worker hooks are present, not even a shell. This means that only statically linked linked hook binaries are supported. Also, because of the image hardening live debugging of the minimal image by attaching to the container is not possible, and, the "full" image needs to be used for that purpose.
2021-03-09 09:53:52 +00:00
# Run as unprivileged user
USER 65534:65534
# Use more verbose logging of gRPC
ENV GRPC_GO_LOG_SEVERITY_LEVEL="INFO"
COPY --from=builder /go/node-feature-discovery/nfd-worker.conf.example /etc/kubernetes/node-feature-discovery/nfd-worker.conf
COPY --from=builder /go/bin/* /usr/bin/
# Create minimal variant of the production image
Add support for configurable runtime full and minimal images. (#513) * Add support for configurable runtime full and minimal images. * Fixups and renamings. * Change variables *_IMG_* to *_IMAGE_* * Fix args in Dockerfile also.
2021-04-20 07:42:33 +00:00
FROM ${BASE_IMAGE_MINIMAL} as minimal
Utilize multi-stage build to reduce docker image size This reduces the size of the Docker image from ca. 1.2GB down to about 750MB. Also, move unit tests from .travis.yml to Dockerfile. Final production image is not able to run unit tests anymore, as sources are missing from there.
2018-05-28 10:47:56 +00:00
Dockerfile: run as non-root
2020-05-28 12:10:03 +00:00
# Run as unprivileged user
USER 65534:65534
Dockerfile: set verbosity of gRPC Makes solving issues easier when gRPC prints out information e.g. about TLS authentication problems on the server (nfd-master) side, too.
2019-02-05 19:35:51 +00:00
# Use more verbose logging of gRPC
ENV GRPC_GO_LOG_SEVERITY_LEVEL="INFO"
Dockerfile: use make for building Modify Makefile to have separate hostmount prefix settings for local and container builds in order to preserve the current behavior.
2020-05-19 07:43:14 +00:00
COPY --from=builder /go/node-feature-discovery/nfd-worker.conf.example /etc/kubernetes/node-feature-discovery/nfd-worker.conf
COPY --from=builder /go/bin/* /usr/bin/
Copy permalink