From d4b34322c52bc8c92ca79ba2a0687575c8503267 Mon Sep 17 00:00:00 2001 From: Daiderd Jordan Date: Wed, 17 Jan 2018 20:07:49 +0100 Subject: [PATCH] networking: don't set NetBIOSName This doesn't look like the hostname on my system, it has an extra unique prefix. --- modules/networking/default.nix | 2 -- tests/networking-hostname.nix | 1 - 2 files changed, 3 deletions(-) diff --git a/modules/networking/default.nix b/modules/networking/default.nix index 9f4ca8c8..b5456905 100644 --- a/modules/networking/default.nix +++ b/modules/networking/default.nix @@ -69,8 +69,6 @@ in (mkIf (cfg.knownNetworkServices == [] && cfg.search != []) "networking.knownNetworkServices is empty, dns searchdomains will not be configured.") ]; - system.defaults.smb.NetBIOSName = cfg.hostName; - system.activationScripts.networking.text = '' echo "configuring networking..." >&2 diff --git a/tests/networking-hostname.nix b/tests/networking-hostname.nix index f89277aa..450c955a 100644 --- a/tests/networking-hostname.nix +++ b/tests/networking-hostname.nix @@ -9,6 +9,5 @@ grep "scutil --set LocalHostName 'EVE'" ${config.out}/activate grep "scutil --set HostName 'EVE'" ${config.out}/activate echo checking defaults write in ${config.out}/activate-user >&2 - grep "defaults write /Library/Preferences/SystemConfiguration/com.apple.smb.server 'NetBIOSName' -string 'EVE'" ${config.out}/activate-user ''; }