From 8b27551e094666e6beb273c484392fa205bb0c97 Mon Sep 17 00:00:00 2001
From: Michael Hoang <enzime@users.noreply.github.com>
Date: Mon, 11 Nov 2024 00:08:42 +1100
Subject: [PATCH] users: warn users to use `pkgs.bashInteractive` instead of
 `pkgs.bash`

---
 modules/users/default.nix | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/modules/users/default.nix b/modules/users/default.nix
index ade4ffbc..574f5a4e 100644
--- a/modules/users/default.nix
+++ b/modules/users/default.nix
@@ -129,6 +129,12 @@ in
       ]
     ));
 
+    warnings = flatten (flip mapAttrsToList cfg.users (name: user:
+      mkIf
+        (user.shell.pname or null == "bash")
+        "Set `users.users.${name}.shell = pkgs.bashInteractive;` instead of `pkgs.bash` as it does not include `readline`."
+    ));
+
     users.gids = mkMerge gids;
     users.uids = mkMerge uids;