From 7d1e77fb76985843bc1214c47c51a58295f9acf6 Mon Sep 17 00:00:00 2001
From: Austin Horstman <khaneliman12@gmail.com>
Date: Tue, 17 Dec 2024 22:32:32 -0600
Subject: [PATCH 1/2] services/sketchybar: cleanup

---
 modules/services/sketchybar/default.nix | 35 ++++++++++++++++++-------
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/modules/services/sketchybar/default.nix b/modules/services/sketchybar/default.nix
index c29eec27..90326841 100644
--- a/modules/services/sketchybar/default.nix
+++ b/modules/services/sketchybar/default.nix
@@ -1,15 +1,26 @@
-{ config, lib, pkgs, ... }:
-
+{
+  config,
+  lib,
+  pkgs,
+  ...
+}:
 let
-  inherit (lib) literalExpression maintainers mkEnableOption mkIf mkPackageOption mkOption optionals types;
+  inherit (lib)
+    literalExpression
+    maintainers
+    mkEnableOption
+    mkIf
+    mkPackageOption
+    mkOption
+    optionals
+    types
+    ;
 
   cfg = config.services.sketchybar;
 
   configFile = pkgs.writeScript "sketchybarrc" cfg.config;
 in
-
 {
-
   meta.maintainers = [
     maintainers.azuwis or "azuwis"
   ];
@@ -50,10 +61,16 @@ in
 
     launchd.user.agents.sketchybar = {
       path = [ cfg.package ] ++ cfg.extraPackages ++ [ config.environment.systemPath ];
-      serviceConfig.ProgramArguments = [ "${cfg.package}/bin/sketchybar" ]
-        ++ optionals (cfg.config != "") [ "--config" "${configFile}" ];
-      serviceConfig.KeepAlive = true;
-      serviceConfig.RunAtLoad = true;
+      serviceConfig = {
+        ProgramArguments =
+          [ "${cfg.package}/bin/sketchybar" ]
+          ++ optionals (cfg.config != "") [
+            "--config"
+            "${configFile}"
+          ];
+        KeepAlive = true;
+        RunAtLoad = true;
+      };
     };
   };
 }

From c77b5db4a0b877e57856c6c87e84330b70f15e72 Mon Sep 17 00:00:00 2001
From: Austin Horstman <khaneliman12@gmail.com>
Date: Tue, 17 Dec 2024 22:33:18 -0600
Subject: [PATCH 2/2] services/sketchybar: add logFile

---
 modules/services/sketchybar/default.nix | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/modules/services/sketchybar/default.nix b/modules/services/sketchybar/default.nix
index 90326841..68f169b2 100644
--- a/modules/services/sketchybar/default.nix
+++ b/modules/services/sketchybar/default.nix
@@ -54,6 +54,20 @@ in
         and [example](https://github.com/FelixKratz/SketchyBar/blob/master/sketchybarrc).
       '';
     };
+
+    errorLogFile = mkOption {
+      type = types.nullOr types.path;
+      default = "/tmp/sketchybar.err.log";
+      example = "/Users/khaneliman/Library/Logs/sketchybar.log";
+      description = "Absolute path to log all stderr output.";
+    };
+
+    outLogFile = mkOption {
+      type = types.nullOr types.path;
+      default = "/tmp/sketchybar.out.log";
+      example = "/Users/khaneliman/Library/Logs/sketchybar.log";
+      description = "Absolute path to log all stdout output.";
+    };
   };
 
   config = mkIf cfg.enable {
@@ -70,6 +84,8 @@ in
           ];
         KeepAlive = true;
         RunAtLoad = true;
+        StandardErrorPath = cfg.errorLogFile;
+        StandardOutPath = cfg.outLogFile;
       };
     };
   };