mirror of
https://github.com/kyverno/kyverno.git
synced 2025-03-09 17:37:12 +00:00
* spec.background field implementation for PolicyExceptions Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * generated files Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * add kuttl test Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * set background to false Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * checks for variables Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * check if aggregate is nil Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * reject variables in polex Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * update Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * Update pkg/validation/exception/validate.go Signed-off-by: shuting <shutting06@gmail.com> * updates Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * change error Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * remove file Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * fix Signed-off-by: damilola olayinka <holayinkajr@gmail.com> * fix lint error Signed-off-by: damilola olayinka <holayinkajr@gmail.com> --------- Signed-off-by: damilola olayinka <holayinkajr@gmail.com> Signed-off-by: shuting <shutting06@gmail.com> Co-authored-by: Charles-Edouard Brétéché <charled.breteche@gmail.com> Co-authored-by: shuting <shuting@nirmata.com> Co-authored-by: shuting <shutting06@gmail.com>
108 lines
3.8 KiB
Go
108 lines
3.8 KiB
Go
package exception
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/kyverno/kyverno/api/kyverno/v2alpha1"
|
|
"github.com/kyverno/kyverno/pkg/logging"
|
|
admissionutils "github.com/kyverno/kyverno/pkg/utils/admission"
|
|
"gotest.tools/assert"
|
|
)
|
|
|
|
func Test_Validate(t *testing.T) {
|
|
type args struct {
|
|
opts ValidationOptions
|
|
resource []byte
|
|
}
|
|
tc := []struct {
|
|
name string
|
|
args args
|
|
want int
|
|
}{
|
|
{
|
|
name: "PolicyExceptions disabled.",
|
|
args: args{
|
|
opts: ValidationOptions{
|
|
Enabled: false,
|
|
Namespace: "kyverno",
|
|
},
|
|
resource: []byte(`{"apiVersion":"kyverno.io/v2alpha1","kind":"PolicyException","metadata":{"name":"enforce-label-exception","namespace":"delta"},"spec":{"exceptions":[{"policyName":"enforce-label","ruleNames":["enforce-label"]}],"match":{"any":[{"resources":{"kinds":["Pod"]}}]}}}`),
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "PolicyExceptions enabled. Defined namespace doesn't match namespace passed.",
|
|
args: args{
|
|
opts: ValidationOptions{
|
|
Enabled: true,
|
|
Namespace: "kyverno",
|
|
},
|
|
resource: []byte(`{"apiVersion":"kyverno.io/v2alpha1","kind":"PolicyException","metadata":{"name":"enforce-label-exception","namespace":"delta"},"spec":{"exceptions":[{"policyName":"enforce-label","ruleNames":["enforce-label"]}],"match":{"any":[{"resources":{"kinds":["Pod"]}}]}}}`),
|
|
},
|
|
want: 1,
|
|
},
|
|
{
|
|
name: "PolicyExceptions enabled. Defined namespace matches namespace passed",
|
|
args: args{
|
|
opts: ValidationOptions{
|
|
Enabled: true,
|
|
Namespace: "kyverno",
|
|
},
|
|
resource: []byte(`{"apiVersion":"kyverno.io/v2alpha1","kind":"PolicyException","metadata":{"name":"enforce-label-exception","namespace":"kyverno"},"spec":{"exceptions":[{"policyName":"enforce-label","ruleNames":["enforce-label"]}],"match":{"any":[{"resources":{"kinds":["Pod"]}}]}}}`),
|
|
},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "PolicyExceptions enabled. No namespace defined",
|
|
args: args{
|
|
opts: ValidationOptions{
|
|
Enabled: true,
|
|
Namespace: "",
|
|
},
|
|
resource: []byte(`{"apiVersion":"kyverno.io/v2alpha1","kind":"PolicyException","metadata":{"name":"enforce-label-exception","namespace":"kyverno"},"spec":{"exceptions":[{"policyName":"enforce-label","ruleNames":["enforce-label"]}],"match":{"any":[{"resources":{"kinds":["Pod"]}}]}}}`),
|
|
},
|
|
want: 0,
|
|
},
|
|
}
|
|
for _, c := range tc {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
polex, err := admissionutils.UnmarshalPolicyException(c.args.resource)
|
|
assert.NilError(t, err)
|
|
warnings, err := Validate(context.Background(), logging.GlobalLogger(), polex, c.args.opts)
|
|
assert.NilError(t, err)
|
|
assert.Assert(t, len(warnings) == c.want)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_ValidateVariables(t *testing.T) {
|
|
tc := []struct {
|
|
name string
|
|
resource []byte
|
|
error bool
|
|
}{
|
|
{
|
|
name: "Variable used.",
|
|
resource: []byte(`{"apiVersion":"kyverno.io/v2alpha1","kind":"PolicyException","metadata":{"name":"enforce-label-polex"},"spec":{"background":true,"exceptions":[{"policyName":"enforce-label","ruleNames":["enforce-label"]}],"match":{"any":[{"resources":{"kinds":["Pod"],"namespaces":["{{request.object.name}}"],"names":["{{request.userInfo.username}}"]}}]}}}`),
|
|
error: true,
|
|
},
|
|
{
|
|
name: "Variable not used.",
|
|
resource: []byte(`{"apiVersion":"kyverno.io/v2alpha1","kind":"PolicyException","metadata":{"name":"enforce-label-polex"},"spec":{"background":true,"exceptions":[{"policyName":"enforce-label","ruleNames":["enforce-label"]}],"match":{"any":[{"resources":{"kinds":["Pod"]}}]}}}`),
|
|
error: false,
|
|
},
|
|
}
|
|
for _, c := range tc {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
polex, err := admissionutils.UnmarshalPolicyException(c.resource)
|
|
assert.NilError(t, err)
|
|
err = v2alpha1.ValidateVariables(polex)
|
|
if c.error {
|
|
assert.Assert(t, err != nil)
|
|
} else {
|
|
assert.Assert(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|