mirror of
https://github.com/kyverno/kyverno.git
synced 2025-03-06 16:06:56 +00:00
* updates for foreach and mutate Signed-off-by: Jim Bugwadia <jim@nirmata.com> * allow tests to pass on Windows Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fix tests Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fix linter check Signed-off-by: Jim Bugwadia <jim@nirmata.com> * add elementIndex variable Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fmt Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fix jsonResult usage Signed-off-by: Jim Bugwadia <jim@nirmata.com> * add mutate validation and fix error in validate.foreach Signed-off-by: Jim Bugwadia <jim@nirmata.com> * format Signed-off-by: Jim Bugwadia <jim@nirmata.com> * update message Signed-off-by: Jim Bugwadia <jim@nirmata.com> * do not skip validation for all array entries when one is skipped Signed-off-by: Jim Bugwadia <jim@nirmata.com> * add foreach tests Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fix fmt Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fix format errors Signed-off-by: Jim Bugwadia <jim@nirmata.com> * remove unused declarations Signed-off-by: Jim Bugwadia <jim@nirmata.com> * revert namespaceWithLabelYaml Signed-off-by: Jim Bugwadia <jim@nirmata.com> * fix mutate of element list Signed-off-by: Jim Bugwadia <jim@nirmata.com> * update CRDs Signed-off-by: Jim Bugwadia <jim@nirmata.com> * Update api/kyverno/v1/policy_types.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/forceMutate.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/forceMutate.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/forceMutate.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/mutation.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/mutation.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/mutation.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/validate/validate.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update pkg/engine/validate/validate.go Co-authored-by: Steven E. Harris <seh@panix.com> * Update test/cli/test/custom-functions/policy.yaml Co-authored-by: Steven E. Harris <seh@panix.com> * Update test/cli/test/foreach/policies.yaml Co-authored-by: Steven E. Harris <seh@panix.com> * accept review comments and format Signed-off-by: Jim Bugwadia <jim@nirmata.com> * add comments to strategicMergePatch buffer Signed-off-by: Jim Bugwadia <jim@nirmata.com> * load context and evaluate preconditions foreach element Signed-off-by: Jim Bugwadia <jim@nirmata.com> * add test for foreach mutate context and precondition * precondition testcase * address review comments Signed-off-by: Jim Bugwadia <jim@nirmata.com> * update message Signed-off-by: Jim Bugwadia <jim@nirmata.com> * format Signed-off-by: Jim Bugwadia <jim@nirmata.com> Co-authored-by: Steven E. Harris <seh@panix.com> Co-authored-by: Vyankatesh Kudtarkar <vyankateshkd@gmail.com>
148 lines
4.7 KiB
Go
148 lines
4.7 KiB
Go
package generate
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
|
|
commonAnchors "github.com/kyverno/kyverno/pkg/engine/anchor"
|
|
|
|
"github.com/go-logr/logr"
|
|
kyverno "github.com/kyverno/kyverno/api/kyverno/v1"
|
|
dclient "github.com/kyverno/kyverno/pkg/dclient"
|
|
"github.com/kyverno/kyverno/pkg/engine/variables"
|
|
"github.com/kyverno/kyverno/pkg/policy/common"
|
|
)
|
|
|
|
// Generate provides implementation to validate 'generate' rule
|
|
type Generate struct {
|
|
// rule to hold 'generate' rule specifications
|
|
rule kyverno.Generation
|
|
// authCheck to check access for operations
|
|
authCheck Operations
|
|
//logger
|
|
log logr.Logger
|
|
}
|
|
|
|
//NewGenerateFactory returns a new instance of Generate validation checker
|
|
func NewGenerateFactory(client *dclient.Client, rule kyverno.Generation, log logr.Logger) *Generate {
|
|
g := Generate{
|
|
rule: rule,
|
|
authCheck: NewAuth(client, log),
|
|
log: log,
|
|
}
|
|
|
|
return &g
|
|
}
|
|
|
|
//Validate validates the 'generate' rule
|
|
func (g *Generate) Validate() (string, error) {
|
|
rule := g.rule
|
|
if rule.Data != nil && rule.Clone != (kyverno.CloneFrom{}) {
|
|
return "", fmt.Errorf("only one of data or clone can be specified")
|
|
}
|
|
|
|
kind, name, namespace := rule.Kind, rule.Name, rule.Namespace
|
|
|
|
if name == "" {
|
|
return "name", fmt.Errorf("name cannot be empty")
|
|
}
|
|
if kind == "" {
|
|
return "kind", fmt.Errorf("kind cannot be empty")
|
|
}
|
|
// Can I generate resource
|
|
|
|
if !reflect.DeepEqual(rule.Clone, kyverno.CloneFrom{}) {
|
|
if path, err := g.validateClone(rule.Clone, kind); err != nil {
|
|
return fmt.Sprintf("clone.%s", path), err
|
|
}
|
|
}
|
|
if rule.Data != nil {
|
|
//TODO: is this required ?? as anchors can only be on pattern and not resource
|
|
// we can add this check by not sure if its needed here
|
|
if path, err := common.ValidatePattern(rule.Data, "/", []commonAnchors.IsAnchor{}); err != nil {
|
|
return fmt.Sprintf("data.%s", path), fmt.Errorf("anchors not supported on generate resources: %v", err)
|
|
}
|
|
}
|
|
|
|
// Kyverno generate-controller create/update/deletes the resources specified in generate rule of policy
|
|
// kyverno uses SA 'kyverno-service-account' and has default ClusterRoles and ClusterRoleBindings
|
|
// instructions to modify the RBAC for kyverno are mentioned at https://github.com/kyverno/kyverno/blob/master/documentation/installation.md
|
|
// - operations required: create/update/delete/get
|
|
// If kind and namespace contain variables, then we cannot resolve then so we skip the processing
|
|
if err := g.canIGenerate(kind, namespace); err != nil {
|
|
return "", err
|
|
}
|
|
return "", nil
|
|
}
|
|
|
|
func (g *Generate) validateClone(c kyverno.CloneFrom, kind string) (string, error) {
|
|
if c.Name == "" {
|
|
return "name", fmt.Errorf("name cannot be empty")
|
|
}
|
|
|
|
namespace := c.Namespace
|
|
// Skip if there is variable defined
|
|
if !variables.IsVariable(kind) && !variables.IsVariable(namespace) {
|
|
// GET
|
|
ok, err := g.authCheck.CanIGet(kind, namespace)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if !ok {
|
|
return "", fmt.Errorf("kyverno does not have permissions to 'get' resource %s/%s. Update permissions in ClusterRole 'kyverno:generatecontroller'", kind, namespace)
|
|
}
|
|
} else {
|
|
g.log.V(4).Info("name & namespace uses variables, so cannot be resolved. Skipping Auth Checks.")
|
|
}
|
|
return "", nil
|
|
}
|
|
|
|
//canIGenerate returns a error if kyverno cannot perform operations
|
|
func (g *Generate) canIGenerate(kind, namespace string) error {
|
|
// Skip if there is variable defined
|
|
authCheck := g.authCheck
|
|
if !variables.IsVariable(kind) && !variables.IsVariable(namespace) {
|
|
// CREATE
|
|
ok, err := authCheck.CanICreate(kind, namespace)
|
|
if err != nil {
|
|
// machinery error
|
|
return err
|
|
}
|
|
if !ok {
|
|
return fmt.Errorf("kyverno does not have permissions to 'create' resource %s/%s. Update permissions in ClusterRole 'kyverno:generatecontroller'", kind, namespace)
|
|
}
|
|
// UPDATE
|
|
ok, err = authCheck.CanIUpdate(kind, namespace)
|
|
if err != nil {
|
|
// machinery error
|
|
return err
|
|
}
|
|
if !ok {
|
|
return fmt.Errorf("kyverno does not have permissions to 'update' resource %s/%s. Update permissions in ClusterRole 'kyverno:generatecontroller'", kind, namespace)
|
|
}
|
|
// GET
|
|
ok, err = authCheck.CanIGet(kind, namespace)
|
|
if err != nil {
|
|
// machinery error
|
|
return err
|
|
}
|
|
if !ok {
|
|
return fmt.Errorf("kyverno does not have permissions to 'get' resource %s/%s. Update permissions in ClusterRole 'kyverno:generatecontroller'", kind, namespace)
|
|
}
|
|
|
|
// DELETE
|
|
ok, err = authCheck.CanIDelete(kind, namespace)
|
|
if err != nil {
|
|
// machinery error
|
|
return err
|
|
}
|
|
if !ok {
|
|
return fmt.Errorf("kyverno does not have permissions to 'delete' resource %s/%s. Update permissions in ClusterRole 'kyverno:generatecontroller'", kind, namespace)
|
|
}
|
|
|
|
} else {
|
|
g.log.V(4).Info("name & namespace uses variables, so cannot be resolved. Skipping Auth Checks.")
|
|
}
|
|
|
|
return nil
|
|
}
|