mirror of
https://github.com/kyverno/kyverno.git
synced 2024-12-15 17:51:20 +00:00
838d02c475
* - support wildcards for namespaces * do not annotate resource, unless policy is an autogen policy * close HTTP body * improve messages * remove policy store Policy store was not fully implemented and simply provided a way to list all polices and get a policy by name, which can be done via standard client-go interfaces. We need to revisit and design a better PolicyStore that provides fast lookups for matching policies based on names, namespaces, etc. * handle wildcard namespaces in background processing * fix unit tests 1) remove platform dependent path usage 2) remove policy store * add test case for mutate with wildcard namespaces
143 lines
3.9 KiB
Go
143 lines
3.9 KiB
Go
package policystatus
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
kyvernolister "github.com/nirmata/kyverno/pkg/client/listers/kyverno/v1"
|
|
"sync"
|
|
"time"
|
|
|
|
"k8s.io/apimachinery/pkg/util/wait"
|
|
|
|
"github.com/nirmata/kyverno/pkg/client/clientset/versioned"
|
|
|
|
v1 "github.com/nirmata/kyverno/pkg/api/kyverno/v1"
|
|
log "sigs.k8s.io/controller-runtime/pkg/log"
|
|
)
|
|
|
|
// Policy status implementation works in the following way,
|
|
//Currently policy status maintains a cache of the status of
|
|
//each policy.
|
|
//Every x unit of time the status of policy is updated using
|
|
//the data from the cache.
|
|
//The sync exposes a listener which accepts a statusUpdater
|
|
//interface which dictates how the status should be updated.
|
|
//The status is updated by a worker that receives the interface
|
|
//on a channel.
|
|
//The worker then updates the current status using the methods
|
|
//exposed by the interface.
|
|
//Current implementation is designed to be threadsafe with optimised
|
|
//locking for each policy.
|
|
|
|
// statusUpdater defines a type to have a method which
|
|
//updates the given status
|
|
type statusUpdater interface {
|
|
PolicyName() string
|
|
UpdateStatus(status v1.PolicyStatus) v1.PolicyStatus
|
|
}
|
|
|
|
type Listener chan statusUpdater
|
|
|
|
func (l Listener) Send(s statusUpdater) {
|
|
l <- s
|
|
}
|
|
|
|
// Sync is the object which is used to initialize
|
|
//the policyStatus sync, can be considered the parent object
|
|
//since it contains access to all the persistant data present
|
|
//in this package.
|
|
type Sync struct {
|
|
cache *cache
|
|
Listener Listener
|
|
client *versioned.Clientset
|
|
lister kyvernolister.ClusterPolicyLister
|
|
}
|
|
|
|
type cache struct {
|
|
dataMu sync.RWMutex
|
|
data map[string]v1.PolicyStatus
|
|
keyToMutex *keyToMutex
|
|
}
|
|
|
|
func NewSync(c *versioned.Clientset, lister kyvernolister.ClusterPolicyLister) *Sync {
|
|
return &Sync{
|
|
cache: &cache{
|
|
dataMu: sync.RWMutex{},
|
|
data: make(map[string]v1.PolicyStatus),
|
|
keyToMutex: newKeyToMutex(),
|
|
},
|
|
client: c,
|
|
lister: lister,
|
|
Listener: make(chan statusUpdater, 20),
|
|
}
|
|
}
|
|
|
|
func (s *Sync) Run(workers int, stopCh <-chan struct{}) {
|
|
for i := 0; i < workers; i++ {
|
|
go s.updateStatusCache(stopCh)
|
|
}
|
|
|
|
wait.Until(s.updatePolicyStatus, 10*time.Second, stopCh)
|
|
<-stopCh
|
|
}
|
|
|
|
// updateStatusCache is a worker which updates the current status
|
|
//using the statusUpdater interface
|
|
func (s *Sync) updateStatusCache(stopCh <-chan struct{}) {
|
|
for {
|
|
select {
|
|
case statusUpdater := <-s.Listener:
|
|
s.cache.keyToMutex.Get(statusUpdater.PolicyName()).Lock()
|
|
|
|
s.cache.dataMu.RLock()
|
|
status, exist := s.cache.data[statusUpdater.PolicyName()]
|
|
s.cache.dataMu.RUnlock()
|
|
if !exist {
|
|
policy, _ := s.lister.Get(statusUpdater.PolicyName())
|
|
if policy != nil {
|
|
status = policy.Status
|
|
}
|
|
}
|
|
|
|
updatedStatus := statusUpdater.UpdateStatus(status)
|
|
|
|
s.cache.dataMu.Lock()
|
|
s.cache.data[statusUpdater.PolicyName()] = updatedStatus
|
|
s.cache.dataMu.Unlock()
|
|
|
|
s.cache.keyToMutex.Get(statusUpdater.PolicyName()).Unlock()
|
|
oldStatus, _ := json.Marshal(status)
|
|
newStatus, _ := json.Marshal(updatedStatus)
|
|
log.Log.V(4).Info(fmt.Sprintf("\nupdated status of policy - %v\noldStatus:\n%v\nnewStatus:\n%v\n", statusUpdater.PolicyName(), string(oldStatus), string(newStatus)))
|
|
case <-stopCh:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// updatePolicyStatus updates the status in the policy resource definition
|
|
//from the status cache, syncing them
|
|
func (s *Sync) updatePolicyStatus() {
|
|
s.cache.dataMu.Lock()
|
|
var nameToStatus = make(map[string]v1.PolicyStatus, len(s.cache.data))
|
|
for k, v := range s.cache.data {
|
|
nameToStatus[k] = v
|
|
}
|
|
s.cache.dataMu.Unlock()
|
|
|
|
for policyName, status := range nameToStatus {
|
|
policy, err := s.lister.Get(policyName)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
|
|
policy.Status = status
|
|
_, err = s.client.KyvernoV1().ClusterPolicies().UpdateStatus(policy)
|
|
if err != nil {
|
|
s.cache.dataMu.Lock()
|
|
delete(s.cache.data, policyName)
|
|
s.cache.dataMu.Unlock()
|
|
log.Log.Error(err, "failed to update policy status")
|
|
}
|
|
}
|
|
}
|