mirror of
https://github.com/kyverno/kyverno.git
synced 2025-03-09 17:37:12 +00:00
* feat: add skipImageReferences in verify images Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: chainsaw tests Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: chainsaw-test.yaml Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> * fix: typo in assert Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> --------- Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
120 lines
4.5 KiB
Go
120 lines
4.5 KiB
Go
package validation
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/go-logr/logr"
|
|
kyvernov1 "github.com/kyverno/kyverno/api/kyverno/v1"
|
|
kyvernov2beta1 "github.com/kyverno/kyverno/api/kyverno/v2beta1"
|
|
"github.com/kyverno/kyverno/pkg/config"
|
|
engineapi "github.com/kyverno/kyverno/pkg/engine/api"
|
|
"github.com/kyverno/kyverno/pkg/engine/handlers"
|
|
engineutils "github.com/kyverno/kyverno/pkg/engine/utils"
|
|
apiutils "github.com/kyverno/kyverno/pkg/utils/api"
|
|
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
|
|
"k8s.io/client-go/tools/cache"
|
|
)
|
|
|
|
type validateImageHandler struct{}
|
|
|
|
func NewValidateImageHandler(
|
|
policyContext engineapi.PolicyContext,
|
|
resource unstructured.Unstructured,
|
|
rule kyvernov1.Rule,
|
|
configuration config.Configuration,
|
|
) (handlers.Handler, error) {
|
|
if engineutils.IsDeleteRequest(policyContext) {
|
|
return nil, nil
|
|
}
|
|
ruleImages, _, err := engineutils.ExtractMatchingImages(resource, policyContext.JSONContext(), rule, configuration)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(ruleImages) == 0 {
|
|
return nil, nil
|
|
}
|
|
return validateImageHandler{}, nil
|
|
}
|
|
|
|
func (h validateImageHandler) Process(
|
|
ctx context.Context,
|
|
logger logr.Logger,
|
|
policyContext engineapi.PolicyContext,
|
|
resource unstructured.Unstructured,
|
|
rule kyvernov1.Rule,
|
|
_ engineapi.EngineContextLoader,
|
|
exceptions []kyvernov2beta1.PolicyException,
|
|
) (unstructured.Unstructured, []engineapi.RuleResponse) {
|
|
// check if there is a policy exception matches the incoming resource
|
|
exception := engineutils.MatchesException(exceptions, policyContext, logger)
|
|
if exception != nil {
|
|
key, err := cache.MetaNamespaceKeyFunc(exception)
|
|
if err != nil {
|
|
logger.Error(err, "failed to compute policy exception key", "namespace", exception.GetNamespace(), "name", exception.GetName())
|
|
return resource, handlers.WithError(rule, engineapi.Validation, "failed to compute exception key", err)
|
|
} else {
|
|
logger.V(3).Info("policy rule skipped due to policy exception", "exception", key)
|
|
return resource, handlers.WithResponses(
|
|
engineapi.RuleSkip(rule.Name, engineapi.Validation, "rule skipped due to policy exception "+key).WithException(exception),
|
|
)
|
|
}
|
|
}
|
|
|
|
skippedImages := make([]string, 0)
|
|
passedImages := make([]string, 0)
|
|
for _, v := range rule.VerifyImages {
|
|
imageVerify := v.Convert()
|
|
for _, infoMap := range policyContext.JSONContext().ImageInfo() {
|
|
for name, imageInfo := range infoMap {
|
|
image := imageInfo.String()
|
|
|
|
if !engineutils.ImageMatches(image, imageVerify.ImageReferences) {
|
|
logger.V(4).Info("image does not match", "imageReferences", imageVerify.ImageReferences)
|
|
return resource, nil
|
|
}
|
|
|
|
logger.V(4).Info("validating image", "image", image)
|
|
if v, err := validateImage(policyContext, imageVerify, name, imageInfo, logger); err != nil {
|
|
return resource, handlers.WithFail(rule, engineapi.ImageVerify, err.Error())
|
|
} else if v == engineapi.ImageVerificationSkip {
|
|
skippedImages = append(skippedImages, image)
|
|
} else if v == engineapi.ImageVerificationPass {
|
|
passedImages = append(passedImages, image)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
logger.V(4).Info("validated image", "rule", rule.Name)
|
|
if len(passedImages) > 0 || len(passedImages)+len(skippedImages) == 0 {
|
|
if len(skippedImages) > 0 {
|
|
return resource, handlers.WithPass(rule, engineapi.Validation, strings.Join(append([]string{"image verified, skipped images:"}, skippedImages...), " "))
|
|
}
|
|
return resource, handlers.WithPass(rule, engineapi.Validation, "image verified")
|
|
} else {
|
|
return resource, handlers.WithSkip(rule, engineapi.Validation, strings.Join(append([]string{"image skipped, skipped images:"}, skippedImages...), " "))
|
|
}
|
|
}
|
|
|
|
func validateImage(ctx engineapi.PolicyContext, imageVerify *kyvernov1.ImageVerification, name string, imageInfo apiutils.ImageInfo, log logr.Logger) (engineapi.ImageVerificationMetadataStatus, error) {
|
|
var verified engineapi.ImageVerificationMetadataStatus
|
|
var err error
|
|
image := imageInfo.String()
|
|
if imageVerify.VerifyDigest && imageInfo.Digest == "" {
|
|
log.V(2).Info("missing digest", "image", imageInfo.String())
|
|
return engineapi.ImageVerificationFail, fmt.Errorf("missing digest for %s", image)
|
|
}
|
|
newResource := ctx.NewResource()
|
|
if imageVerify.Required && newResource.Object != nil {
|
|
verified, err = engineutils.IsImageVerified(newResource, image, log)
|
|
if err != nil {
|
|
return engineapi.ImageVerificationFail, err
|
|
}
|
|
if verified == engineapi.ImageVerificationFail {
|
|
return engineapi.ImageVerificationFail, fmt.Errorf("unverified image %s", image)
|
|
}
|
|
}
|
|
return verified, nil
|
|
}
|