From f4f34419d9951a968cbc046d91f9cbd7e7b4e9b0 Mon Sep 17 00:00:00 2001 From: Jim Bugwadia Date: Sat, 16 Dec 2023 00:50:08 -0800 Subject: [PATCH] improve messages (#9168) * improve messages Signed-off-by: Jim Bugwadia * fix typo Signed-off-by: Jim Bugwadia --------- Signed-off-by: Jim Bugwadia --- .../validatingadmissionpolicy-generate/controller.go | 8 ++++---- pkg/validation/policy/actions.go | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/controllers/validatingadmissionpolicy-generate/controller.go b/pkg/controllers/validatingadmissionpolicy-generate/controller.go index 2ff42d52f0..9a9ed97c33 100644 --- a/pkg/controllers/validatingadmissionpolicy-generate/controller.go +++ b/pkg/controllers/validatingadmissionpolicy-generate/controller.go @@ -318,15 +318,15 @@ func (c *controller) reconcile(ctx context.Context, logger logr.Logger, key, nam // check if the controller has the required permissions to generate validating admission policies. if !validatingadmissionpolicy.HasValidatingAdmissionPolicyPermission(c.checker) { - logger.Info("doesn't have required permissions for generating ValidatingAdmissionPolicies") - c.updateClusterPolicyStatus(ctx, *policy, false, "doesn't have required permissions for generating ValidatingAdmissionPolicies") + logger.Info("insufficient permissions to generate ValidatingAdmissionPolicies") + c.updateClusterPolicyStatus(ctx, *policy, false, "insufficient permissions to generate ValidatingAdmissionPolicies") return nil } // check if the controller has the required permissions to generate validating admission policy bindings. if !validatingadmissionpolicy.HasValidatingAdmissionPolicyBindingPermission(c.checker) { - logger.Info("doesn't have required permissions for generating ValidatingAdmissionPolicyBindings") - c.updateClusterPolicyStatus(ctx, *policy, false, "doesn't have required permissions for generating ValidatingAdmissionPolicyBindings") + logger.Info("insufficient permissions to generate ValidatingAdmissionPolicyBindings") + c.updateClusterPolicyStatus(ctx, *policy, false, "insufficient permissions to generate ValidatingAdmissionPolicyBindings") return nil } diff --git a/pkg/validation/policy/actions.go b/pkg/validation/policy/actions.go index a6e458b57e..5aa363b4e4 100644 --- a/pkg/validation/policy/actions.go +++ b/pkg/validation/policy/actions.go @@ -51,12 +51,12 @@ func validateActions(idx int, rule *kyvernov1.Rule, client dclient.Interface, mo authCheck := authChecker.NewSelfChecker(client.GetKubeClient().AuthorizationV1().SelfSubjectAccessReviews()) // check if the controller has the required permissions to generate validating admission policies. if !validatingadmissionpolicy.HasValidatingAdmissionPolicyPermission(authCheck) { - return "doesn't have required permissions for generating ValidatingAdmissionPolicies", nil + return "insufficient permissions to generate ValidatingAdmissionPolicies", nil } // check if the controller has the required permissions to generate validating admission policy bindings. if !validatingadmissionpolicy.HasValidatingAdmissionPolicyBindingPermission(authCheck) { - return "doesn't have required permissions for generating ValidatingAdmissionPolicyBindings", nil + return "insufficient permissions to generate ValidatingAdmissionPolicyBindings", nil } } }