mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-31 03:45:17 +00:00
Code Activity

refactor: improve tracing package (#5391)

Browse source 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
This commit is contained in:
Charles-Edouard Brétéché 2022-11-17 15:41:49 +01:00 • committed by GitHub
parent 83a84c9d47
commit ebe8618cdc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/tracing/tracing.go
View file

@ -86,7 +86,6 @@ func DoInSpan(ctx context.Context, tracerName string, operationName string, doFn
} }
// StartSpan creates a span from a context with `operationName` name // StartSpan creates a span from a context with `operationName` name
func StartSpan(ctx context.Context, tracerName string, operationName string, attributes []attribute.KeyValue) trace.Span { func StartSpan(ctx context.Context, tracerName string, operationName string, attributes ...attribute.KeyValue) (context.Context, trace.Span) {
_, span := otel.Tracer(tracerName).Start(ctx, operationName, trace.WithAttributes(attributes...)) return otel.Tracer(tracerName).Start(ctx, operationName, trace.WithAttributes(attributes...))
return span
} }

8
pkg/webhooks/handlers/admission.go
View file

@ -70,14 +70,16 @@ func withAdmission(logger logr.Logger, inner AdmissionHandler) http.HandlerFunc
} }
// start span from request context // start span from request context
attributes := []attribute.KeyValue{ _, span := tracing.StartSpan(
ctx,
"admission_webhook_operations",
string(admissionReview.Request.Operation),
attribute.String("kind", admissionReview.Request.Kind.Kind), attribute.String("kind", admissionReview.Request.Kind.Kind),
attribute.String("namespace", admissionReview.Request.Namespace), attribute.String("namespace", admissionReview.Request.Namespace),
attribute.String("name", admissionReview.Request.Name), attribute.String("name", admissionReview.Request.Name),
attribute.String("operation", string(admissionReview.Request.Operation)), attribute.String("operation", string(admissionReview.Request.Operation)),
attribute.String("uid", string(admissionReview.Request.UID)), attribute.String("uid", string(admissionReview.Request.UID)),
} )
span := tracing.StartSpan(ctx, "admission_webhook_operations", string(admissionReview.Request.Operation), attributes)
defer span.End() defer span.End()
writer.Header().Set("Content-Type", "application/json; charset=utf-8") writer.Header().Set("Content-Type", "application/json; charset=utf-8")