mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-03-06 16:06:56 +00:00
Code Activity

Cleanup the UR for mutate policies once it's completed (#3923)

Browse source 
Signed-off-by: ShutingZhao <shuting@nirmata.com>
This commit is contained in:
shuting 2022-05-16 12:45:44 +08:00 • committed by GitHub
parent 4972f20259
commit e779cb866a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/background/common/status.go
View file

@ -13,7 +13,7 @@ import (
type StatusControlInterface interface {
Failed(ur urkyverno.UpdateRequest, message string, genResources []kyverno.ResourceSpec) error
Success(ur urkyverno.UpdateRequest, genResources []kyverno.ResourceSpec) error
Skip(gr urkyverno.UpdateRequest, genResources []kyverno.ResourceSpec) error
Skip(ur urkyverno.UpdateRequest, genResources []kyverno.ResourceSpec) error
}
// StatusControl is default implementaation of GRStatusControlInterface

4
pkg/background/request_process.go
View file

@ -47,6 +47,10 @@ func (c *Controller) UnmarkUR(ur *urkyverno.UpdateRequest) error {
return err
}
if ur.Spec.Type == urkyverno.Mutate && ur.Status.State == urkyverno.Completed {
return c.kyvernoClient.KyvernoV1beta1().UpdateRequests(config.KyvernoNamespace).Delete(context.TODO(), ur.GetName(), metav1.DeleteOptions{})
}
newUR.Status.Handler = ""
_, err = c.kyvernoClient.KyvernoV1beta1().UpdateRequests(config.KyvernoNamespace).UpdateStatus(context.TODO(), newUR, metav1.UpdateOptions{})
return err

2
pkg/background/update_request_controller.go
View file

@ -209,7 +209,7 @@ func (c *Controller) syncUpdateRequest(key string) error {
}
if err = c.UnmarkUR(ur); err != nil {
return fmt.Errorf("failed to un-mark UR %s: %v", key, err)
return fmt.Errorf("failed to unmark UR %s: %v", key, err)
}
return nil

5
pkg/webhooks/updaterequest.go
View file

@ -36,6 +36,11 @@ func (ws *WebhookServer) handleMutateExisting(request *admissionv1.AdmissionRequ
policyContext.NewResource = policyContext.OldResource
}
if request.Operation == admissionv1.Update && policyContext.NewResource.GetDeletionTimestamp() != nil {
logger.V(4).Info("skip creating UR for the trigger resource that is in termination")
return
}
var engineResponses []*response.EngineResponse
for _, policy := range policies {
if !policy.GetSpec().IsMutateExisting() {