From e454c71aa606a936996bd9f53d3e562667667ce5 Mon Sep 17 00:00:00 2001 From: Chip Zoller Date: Sat, 19 Mar 2022 21:31:54 -0400 Subject: [PATCH] PR and issue template updates per contributors' meetings (#3428) * add cherry pick requirement Signed-off-by: Chip Zoller * adopt github issue forms Signed-off-by: Chip Zoller * update PR template with test checklist reminders Signed-off-by: Chip Zoller * Add "other" issue template Signed-off-by: Chip Zoller * add "triage" label to all new issues Signed-off-by: Chip Zoller --- .github/ISSUE_TEMPLATE/bug-cli.yaml | 2 +- .github/ISSUE_TEMPLATE/bug-other.yaml | 49 +++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/bug-webhook.yaml | 2 +- .github/ISSUE_TEMPLATE/feature.yaml | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 3 +- 5 files changed, 54 insertions(+), 4 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug-other.yaml diff --git a/.github/ISSUE_TEMPLATE/bug-cli.yaml b/.github/ISSUE_TEMPLATE/bug-cli.yaml index 4205dc7844..0acd24a2fb 100644 --- a/.github/ISSUE_TEMPLATE/bug-cli.yaml +++ b/.github/ISSUE_TEMPLATE/bug-cli.yaml @@ -1,7 +1,7 @@ name: "Bug Report: CLI" description: Report a bug in the Kyverno CLI. title: "[Bug] [CLI] " -labels: ["bug", "type:cli"] +labels: ["bug", "type:cli", "triage"] body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/bug-other.yaml b/.github/ISSUE_TEMPLATE/bug-other.yaml new file mode 100644 index 0000000000..ffea8afecc --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-other.yaml @@ -0,0 +1,49 @@ +name: "Bug Report: Other" +description: Report a bug not applicable to other issue templates. +title: "[Bug] " +labels: ["bug","triage"] +body: + - type: markdown + attributes: + value: | + Please tell us about the bug, but before doing so ensure you have read the [documentation](https://kyverno.io/docs/). + - type: dropdown + id: kyverno-version + attributes: + label: Kyverno Version + description: What version of Kyverno are you running? + options: + - 1.4.x + - 1.5.x + - 1.6.x + validations: + required: true + - type: textarea + id: bug-description + attributes: + label: Description + description: Describe what happened. + # placeholder: Tell us what you see! + # value: "asdf" + validations: + required: true + - type: input + id: slack + attributes: + label: Slack discussion + description: >- + If this issue is the result of a discussion thread on Slack, please provide the link to the discussion for reference. + # placeholder: ex. email@example.com + validations: + required: false + - type: checkboxes + id: troubleshooting + attributes: + label: Troubleshooting + description: >- + By submitting this issue, you agree that you have performed some basic attempts at researching and solving your problem. + options: + - label: I have read and followed the documentation AND the [troubleshooting guide](https://kyverno.io/docs/troubleshooting/). + required: true + - label: I have searched other issues in this repository and mine is not recorded. + required: true \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/bug-webhook.yaml b/.github/ISSUE_TEMPLATE/bug-webhook.yaml index d86bab60e6..bfef88b5c0 100644 --- a/.github/ISSUE_TEMPLATE/bug-webhook.yaml +++ b/.github/ISSUE_TEMPLATE/bug-webhook.yaml @@ -1,7 +1,7 @@ name: "Bug Report: Webhook" description: Report a bug with the Kyverno webhook. title: "[Bug] " -labels: ["bug"] +labels: ["bug", "triage"] body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/feature.yaml b/.github/ISSUE_TEMPLATE/feature.yaml index bc6d01d69d..932e6ec9ff 100644 --- a/.github/ISSUE_TEMPLATE/feature.yaml +++ b/.github/ISSUE_TEMPLATE/feature.yaml @@ -1,7 +1,7 @@ name: "Feature Request" description: Suggest a new feature for Kyverno to support. title: "[Feature] " -labels: ["enhancement"] +labels: ["enhancement", "triage"] body: - type: markdown attributes: diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 56472d562a..d8b8d997da 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -86,7 +86,8 @@ them, don't hesitate to ask. We're here to help! This is simply a reminder of wh - [ ] I have read the [contributing guidelines](https://github.com/kyverno/kyverno/blob/main/CONTRIBUTING.md). - [ ] I have read the [PR documentation guide](https://github.com/kyverno/kyverno/blob/main/.github/pr_documentation.md) and followed the process including adding proof manifests to this PR. -- [ ] I have added tests that prove my fix is effective or that my feature works. +- [ ] This is a bug fix and I have added unit tests that prove my fix is effective. +- [ ] This is a feature and I have added CLI tests that are applicable. - [ ] My PR needs to be cherry picked to a specific release branch which is . - [ ] My PR contains new or altered behavior to Kyverno and - [ ] CLI support should be added and my PR doesn't contain that functionality.