fix edit failure blocked by annotation change

- as we change the patches key in annotation to "policies.kyverno.io/patches" in commit bdb3f40f15

pkg/webhooks/annotations.go

@@ -41,21 +41,15 @@ func generateAnnotationPatches(annotations map[string]string, engineResponses []
 		return nil
 	}
 
-	if _, ok := annotations[policyAnnotation]; ok {
-		// create update patch string
-		patchResponse = response{
-			Op:    "replace",
-			Path:  "/metadata/annotations/" + policyAnnotation,
-			Value: string(value),
-		}
-	} else {
-		// insert 'policies.kyverno.io' entry in annotation map
-		annotations[policyAnnotation] = string(value)
-		patchResponse = response{
-			Op:    "add",
-			Path:  "/metadata/annotations",
-			Value: annotations,
-		}
+	// Kyverno uses jsonpath to patch obejct
+	// since policyAnnotation=policies.kyverno.io/patches contains "/"
+	// the operation here should always be "add"
+	// otherwise the key when patching will be "patches" which is missing
+	annotations[policyAnnotation] = string(value)
+	patchResponse = response{
+		Op:    "add",
+		Path:  "/metadata/annotations",
+		Value: annotations,
 	}
 
 	patchByte, _ := json.Marshal(patchResponse)

pkg/webhooks/annotations_test.go

@@ -61,7 +61,7 @@ func Test_exist_kyverno_annotation(t *testing.T) {
 	engineResponse := newEngineResponse("mutate-container", "default-imagepullpolicy", []string{patchStr}, true)
 	annPatches := generateAnnotationPatches(annotation, []engine.EngineResponse{engineResponse})
 
-	expectedPatches := `{"op":"replace","path":"/metadata/annotations/policies.kyverno.io/patches","value":"[{\"policyname\":\"mutate-container\",\"patches\":[{\"rulename\":\"default-imagepullpolicy\",\"op\":\"replace\",\"path\":\"/spec/containers/0/imagePullPolicy\"}]}]"}`
+	expectedPatches := `{"op":"add","path":"/metadata/annotations","value":{"policies.kyverno.io/patches":"[{\"policyname\":\"mutate-container\",\"patches\":[{\"rulename\":\"default-imagepullpolicy\",\"op\":\"replace\",\"path\":\"/spec/containers/0/imagePullPolicy\"}]}]"}}`
 	assert.Assert(t, string(annPatches) == expectedPatches)
 }