mirrors/kyverno
mirrors/kyverno
1
0
Fork 0
mirror of https://github.com/kyverno/kyverno.git synced 2025-04-08 18:15:48 +00:00
Code Activity

Merge pull request #2643 from yashvardhan-kukreja/issue-2629/metrics-result-fix-up

Browse source 
Fix: RuleResult label to be correctly populated while registering respective metrics
This commit is contained in:
Jim Bugwadia 2021-10-31 02:19:51 -07:00 • committed by GitHub
commit de9fb567f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
pkg/metrics/policyexecutionduration/policyExecutionDuration.go
View file

@ -83,9 +83,21 @@ func (pc PromConfig) ProcessEngineResponse(policy kyverno.ClusterPolicy, engineR
for _, rule := range ruleResponses {
ruleName := rule.Name
ruleType := ParseRuleTypeFromEngineRuleResponse(rule)
ruleResult := metrics.Fail
if rule.Status == response.RuleStatusPass {
var ruleResult metrics.RuleResult
switch rule.Status {
case response.RuleStatusPass:
ruleResult = metrics.Pass
case response.RuleStatusFail:
ruleResult = metrics.Fail
case response.RuleStatusWarn:
ruleResult = metrics.Warn
case response.RuleStatusError:
ruleResult = metrics.Error
case response.RuleStatusSkip:
ruleResult = metrics.Skip
default:
ruleResult = metrics.Fail
}
ruleExecutionLatencyInSeconds := float64(rule.RuleStats.ProcessingTime) / float64(1000*1000*1000)

16
pkg/metrics/policyresults/policyResults.go
View file

@ -76,9 +76,21 @@ func (pc PromConfig) ProcessEngineResponse(policy kyverno.ClusterPolicy, engineR
for _, rule := range ruleResponses {
ruleName := rule.Name
ruleType := ParseRuleTypeFromEngineRuleResponse(rule)
ruleResult := metrics.Fail
if rule.Status == response.RuleStatusPass {
var ruleResult metrics.RuleResult
switch rule.Status {
case response.RuleStatusPass:
ruleResult = metrics.Pass
case response.RuleStatusFail:
ruleResult = metrics.Fail
case response.RuleStatusWarn:
ruleResult = metrics.Warn
case response.RuleStatusError:
ruleResult = metrics.Error
case response.RuleStatusSkip:
ruleResult = metrics.Skip
default:
ruleResult = metrics.Fail
}
if err := pc.registerPolicyResultsMetric(